Received: from localhost (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id 312C7632D4C; Tue, 20 Oct 2009 10:47:06 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 65683-10; Tue, 20 Oct 2009 13:46:46 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-pz0-f193.google.com (mail-pz0-f193.google.com [209.85.222.193]) by mail.postgresql.org (Postfix) with ESMTP id A7C3C63281F; Tue, 20 Oct 2009 10:46:54 -0300 (ADT) Received: by pzk31 with SMTP id 31so4541646pzk.28 for ; Tue, 20 Oct 2009 06:46:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=Lu3RkggS7VD+WoAnoi0ibxCX4L2ahGimUGEMA9MDhpM=; b=ojqjrmwo3Xpc9Vn5n4WIpdxjtQcsxp4qL/tdF/Pyj9aZQ4VZXYZ30X3F+57v/XXZyz XJRK1yYsT9g224vGqTkIfYoFwcO7t+10jsLgBdr98ijpBlnSKXzNfZ4uqP33OchU21/V PS4GqCzaDU6VjDT0Mil3cy9C+oGykV2l0XTvA= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=km05XihQEpgON9J477mPHTY0HfFLDPyWFBpSGKH3ZgEpmW0ZNNdfwCZ6E3uMOY3sPL mBKzgCOR6GIoOlB9F1YWtynNp3FoIEJtV5okUs0fppX9Ow/raZbtNYs6Y3qfv4U0p7Zt /O2uHwL+BdYFkMcQxqIfTp7GACOW3OEevITg8= MIME-Version: 1.0 Received: by 10.115.114.9 with SMTP id r9mr9379723wam.19.1256046412364; Tue, 20 Oct 2009 06:46:52 -0700 (PDT) In-Reply-To: References: Date: Tue, 20 Oct 2009 09:46:52 -0400 Message-ID: Subject: Re: PostgreSQL driver for Joomla review From: Merlin Moncure To: Thom Brown Cc: pgsql-php@postgresql.org, PGSQL Mailing List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.54 tagged_above=-10 required=5 tests=AWL=0.059, BAYES_00=-2.599 X-Spam-Level: X-Archive-Number: 200910/739 X-Sequence-Number: 154433 On Tue, Oct 20, 2009 at 8:02 AM, Thom Brown wrote: > If anyone has a moment, could they review the PostgreSQL driver I > wrote for Joomla's next major release? =A0The developers at Joomla have > listened to the persistent noise created about only having MySQL as an > option and are now accepting submissions for alternative database > systems. (see http://groups.google.com/group/joomla-dev-cms/browse_thread= /thread/1382dc6f4af56278#msg_9b95648941ef6fa7 > for this development) > > My submission can be found at: > http://joomlacode.org/gf/project/joomla/tracker/?action=3DTrackerItemEdit= &tracker_item_id=3D18384 > > Things to watch out for a version-dependent features and clumsy implement= ations. *) why bother with the version check in queryBatch? why not just do begin->commit always? *) no ability to delete? *) looks like typo on line 713 keep up the good work... merlin