Received: from localhost (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id 9BA2B63281F; Tue, 20 Oct 2009 11:02:51 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 68753-05; Tue, 20 Oct 2009 14:02:32 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-fx0-f210.google.com (mail-fx0-f210.google.com [209.85.220.210]) by mail.postgresql.org (Postfix) with ESMTP id 4EAF263281A; Tue, 20 Oct 2009 11:02:39 -0300 (ADT) Received: by fxm6 with SMTP id 6so6443451fxm.19 for ; Tue, 20 Oct 2009 07:02:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=H+Jd8F1zxxp1PPtMiYgpqS2V3FcJzugNYtd9T/NeLGo=; b=CiZfp0TWAQ0VGAOsCZkLLAROYY5KeMT0u6kzDSpu847cfZKLYre7+v8l9VGx8W/1qw ScTykoVhATSUPotLB4SDvqbssFip3KCeSnGsHfdWMy7haLfXgutO/2plmZQA726hwZ/3 OpaltdljRcC6guF48/e7wT8vjolDsptkvcI78= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=r3XZ3bLP9wUfxEyNXIkfn6VhJMWYVOHihrfdo07GuUJ4ZdwmB2jCGGs1lXmK/gJH+i PYTWof2L842LNCntq8f0J9ROJ3sk/sMTYkzYTdBydKN7vjR88cGD+HLnZQojZsZZzKIF Lno0KxiHtEZTDnKTmJ+4AL3GTGMTT7+ucpeyA= MIME-Version: 1.0 Received: by 10.223.5.25 with SMTP id 25mr1195042fat.38.1256047358159; Tue, 20 Oct 2009 07:02:38 -0700 (PDT) In-Reply-To: References: From: Thom Brown Date: Tue, 20 Oct 2009 15:02:18 +0100 Message-ID: Subject: Re: PostgreSQL driver for Joomla review To: Merlin Moncure Cc: pgsql-php@postgresql.org, PGSQL Mailing List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.465 tagged_above=-10 required=5 tests=AWL=0.135, BAYES_00=-2.599 X-Spam-Level: X-Archive-Number: 200910/741 X-Sequence-Number: 154435 2009/10/20 Merlin Moncure : > On Tue, Oct 20, 2009 at 8:02 AM, Thom Brown wrote: >> If anyone has a moment, could they review the PostgreSQL driver I >> wrote for Joomla's next major release? =A0The developers at Joomla have >> listened to the persistent noise created about only having MySQL as an >> option and are now accepting submissions for alternative database >> systems. (see http://groups.google.com/group/joomla-dev-cms/browse_threa= d/thread/1382dc6f4af56278#msg_9b95648941ef6fa7 >> for this development) >> >> My submission can be found at: >> http://joomlacode.org/gf/project/joomla/tracker/?action=3DTrackerItemEdi= t&tracker_item_id=3D18384 >> >> Things to watch out for a version-dependent features and clumsy implemen= tations. > > *) why bother with the version check in queryBatch? =A0why not just do > begin->commit always? To be honest, I hadn't touched that function. That's entirely inherited from the MySQL one, but you're right, for Postgres there's no need to check the version. > *) no ability to delete? The driver has to match that of the MySQL one in Joomla, so I couldn't implement functionality which wouldn't be used by every driver. The only thing I added which differed was a concatentation operator which I put in for future implementation as I believe it will be necessary if they're going to adapt the existing codebase to support multiple database systems. > *) looks like typo on line 713 Yes, that's just left over from me quickly trying to tidy up my comments as I couldn't get the proper version from the site. Please ignore it as it isn't in my actual submission. Thanks Merlin! Thom