Received: from maia.hub.org (unknown [200.46.204.183]) by mail.postgresql.org (Postfix) with ESMTP id 40F0E632E83; Tue, 20 Oct 2009 16:00:55 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by maia.hub.org (mx1.hub.org [200.46.204.183]) (amavisd-maia, port 10024) with ESMTP id 90839-05; Tue, 20 Oct 2009 19:00:47 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from fg-out-1718.google.com (fg-out-1718.google.com [72.14.220.154]) by mail.postgresql.org (Postfix) with ESMTP id E79986339A3; Tue, 20 Oct 2009 16:00:46 -0300 (ADT) Received: by fg-out-1718.google.com with SMTP id 16so2911278fgg.1 for ; Tue, 20 Oct 2009 12:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:cc:content-type; bh=g9uXMV0wlsizgw4BYGzKY6XfKoo174Hk3HszzyLnNrs=; b=bxMphJc46EB0HgP1ft74I7vC5DSQSHcJiKSg+gBCsFULPz0C7Qjnsa9n6CXvb/7gkT Frxst1zHjA6CMtisE7PoXEw6earPGcTSDUmEOL7LPFWuw8wlBLtT5JAKK2hNLhTDl44V 5HtDjGB9FnuHVWYIx1id9mtd5uaLmTTk4Rq3g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=xNmDCDfjy0g3Z6kBIIS4qLCfS2F04rgHPtAfxmTZt71Cst6NjNSxYKe7vSosyYSZMg AaSGCdVVctYTZvzV4RVwkZi+9UTs0p+VMyIuqGCXp59uiq3CL/6PblRESDsyvJRd9Ow6 vwwDQ0lHyi8tI+HLBbLz7EmZaJIJ7SGtwQA8I= MIME-Version: 1.0 Received: by 10.223.3.155 with SMTP id 27mr1321325fan.12.1256065239115; Tue, 20 Oct 2009 12:00:39 -0700 (PDT) In-Reply-To: <0C148B43-DF74-4DA6-866E-9903A540797D@solfertje.student.utwente.nl> References: <0C148B43-DF74-4DA6-866E-9903A540797D@solfertje.student.utwente.nl> From: Thom Brown Date: Tue, 20 Oct 2009 20:00:19 +0100 Message-ID: Subject: Re: PostgreSQL driver for Joomla review To: Alban Hertroys Cc: pgsql-php@postgresql.org, PGSQL Mailing List Content-Type: text/plain; charset=ISO-8859-1 X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=-2.599 tagged_above=-10 required=5 tests=BAYES_00=-2.599 X-Spam-Level: X-Archive-Number: 200910/769 X-Sequence-Number: 154463 2009/10/20 Alban Hertroys : > You miss a keyword in your query in renameTable; it should be " RENAME TO ", > not " TO ". Thanks for spotting that. I've made my amendments for next submit. > Wouldn't it be convenient to have an EXPLAIN ANALYSE version of explain()? > Maybe with a boolean parameter? The problem is, I don't see where they're using this function, so if they're using it to EXPLAIN an INSERT, UPDATE or DELETE statement, ANALYZE would execute it... unless I roll it back straight after. > In insertObject() you have a query "SELECT $keyName AS 'id' FROM $table'" - > That line contains two syntax errors: 'id' (You probably meant "id") and > $table' (spurious trailing quote). Again, you're right and well spotted. :) Fixed both of those. Cheers for helping out Alban! :D Thom