public inbox for [email protected]  

help / color / mirror / Atom feed

From: Pop, Sebastian <[email protected]>
To: Christoph Berg <[email protected]>
Cc: PostgreSQL in Debian <[email protected]>
Cc: Saidi, Ali <[email protected]>
Cc: Csoma, Csaba <[email protected]>
Subject: Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64
Date: Thu, 11 Nov 2021 17:38:03 +0000
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>

Thanks Christoph for the pointers.

I see that the source code of PostgreSQL is patched before builds:
i.e., the configure.in file has this patch applied to it https://salsa.debian.org/postgresql/postgresql/-/blob/13/debian/patches/autoconf2.69

Following the original patch from Tsahi Zidenberg,
https://www.postgresql.org/message-id/attachment/111983/0001-Support-outline-atomics-on-aarch64.patc...
I would like to add the attached patch to the list of patches applied before build.

Christoph, could you please let me know how I should test the patch?

Thanks,
Sebastian

Attachments:

  [text/x-patch] 0001-arm64-enable-moutline-atomics-flag.patch (1.1K, 2-0001-arm64-enable-moutline-atomics-flag.patch)
  download | inline diff:
From 8e959e3b96c880004626cfe5d1b8666c52ae9ba7 Mon Sep 17 00:00:00 2001
From: Sebastian Pop <[email protected]>
Date: Thu, 11 Nov 2021 17:34:12 +0000
Subject: [PATCH] [arm64] enable -moutline-atomics flag

---
 debian/patches/arm64-outline-atomics | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 debian/patches/arm64-outline-atomics

diff --git a/debian/patches/arm64-outline-atomics b/debian/patches/arm64-outline-atomics
new file mode 100644
index 0000000..741b243
--- /dev/null
+++ b/debian/patches/arm64-outline-atomics
@@ -0,0 +1,13 @@
+--- a/configure.in
++++ b/configure.in
+@@ -532,6 +532,10 @@ if test "$GCC" = yes -a "$ICC" = no; then
+   if test -n "$NOT_THE_CFLAGS"; then
+     CFLAGS="$CFLAGS -Wno-stringop-truncation"
+   fi
++  if test x"$host_cpu" == x"aarch64"; then
++    PGAC_PROG_CC_CFLAGS_OPT([-moutline-atomics])
++    PGAC_PROG_CXX_CFLAGS_OPT([-moutline-atomics])
++  fi
+ elif test "$ICC" = yes; then
+   # Intel's compiler has a bug/misoptimization in checking for
+   # division by NAN (NaN == 0), -mp1 fixes it, so add it to the CFLAGS.
-- 
2.25.1

view thread (26+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox