pg.ddx.io pgsql-pkg-debian@postgresql.org mailing list archive
help / color / mirror / Atom feedGetting Citus into (Debian) PGDG
6+ messages / 3 participants
[nested] [flat]
* Getting Citus into (Debian) PGDG
@ 2016-03-25 22:43 Jason Petersen <jason@citusdata.com>
0 siblings, 2 replies; 6+ messages in thread
From: Jason Petersen @ 2016-03-25 22:43 UTC (permalink / raw)
To: pgsql-pkg-debian
Hey all,
The latest version of Citus (5.0) is now both open-source and a PostgreSQL extension. As such, I’m looking to get it into PGDG. It appears Devrim’s already taken my RPM spec file and build packages for those distros, so all that’s left are the Debian flavors.
I’ve been collecting my packaging work in a repo at https://github.com/citusdata/packaging <https://github.com/citusdata/packaging; , though the most interesting bit is the debian directory <https://github.com/citusdata/packaging/tree/525a46c8b6ac5ab7c52015f8b74bee254559de40/debian;. Christoph already suggested I add a watch file, which I’ve tested using uscan. It has a rule for finding the upstream signing key, which I’ve included in the directory (it’s my key <https://keybase.io/jasonmp85;, which I’ve been using to sign emails and git commits for some time now). If that part is unnecessary, it can be removed. Our release candidate version numbers use a hyphen, so I’ve included a mangler for that as well (to turn it into a tilde).
The extension builds unmodified on PostgreSQL 9.4 and 9.5 on Debian Jessie/Wheezy and Ubuntu Precise/Trusty/Wily. Lintian has no warnings or errors (save the typical one about not closing an ITP bug), and we’ve been using a Jessie package built with this repo in our Docker image.
I still have two remaining questions:
What do I do about the changelog? I’ve included one, but I expect it’s not useful and will need to be replaced by the ultimate packager
I’d really like to avoid having to have a special “debian” branch upstream just to have my debian directory available. I noticed many packages (psqlodbc, check-postgres as two examples) have only a debian folder in the apt repo. Since uscan/uupdate can update solely from a downloaded tarball, it seems like this should be an option. Can I take this approach?
Thanks for any help, and looking forward to having our project in the repo!
--
Jason Petersen
Software Engineer | Citus Data
303.736.9255
jason@citusdata.com
Attachments:
[application/pgp-signature] signature.asc (495B, ../../A37C3A5E-DDEA-40C9-BB67-133B42E4E0A8@citusdata.com/3-signature.asc)
download
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Getting Citus into (Debian) PGDG
@ 2016-03-25 23:03 Jason Petersen <jason@citusdata.com>
parent: Jason Petersen <jason@citusdata.com>
1 sibling, 1 reply; 6+ messages in thread
From: Jason Petersen @ 2016-03-25 23:03 UTC (permalink / raw)
To: pgsql-pkg-debian
> On Mar 25, 2016, at 4:43 PM, Jason Petersen <jason@citusdata.com> wrote:
>
> though the most interesting bit is the debian directory <https://github.com/citusdata/packaging/tree/525a46c8b6ac5ab7c52015f8b74bee254559de40/debian;
And of course I provided a link to a stale debian directory commit. Latest is here: https://github.com/citusdata/packaging/tree/8cc20250b8df0b0d8cfb95f1a68145e5ef11a205/debian <https://github.com/citusdata/packaging/tree/8cc20250b8df0b0d8cfb95f1a68145e5ef11a205/debian;
Sorry for any confusion.
--
Jason Petersen
Software Engineer | Citus Data
303.736.9255
jason@citusdata.com
Attachments:
[application/pgp-signature] signature.asc (495B, ../../980D4281-A01F-4F5D-9874-FFED701F403F@citusdata.com/3-signature.asc)
download
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Getting Citus into (Debian) PGDG
@ 2016-04-01 19:26 Jason Petersen <jason@citusdata.com>
parent: Jason Petersen <jason@citusdata.com>
1 sibling, 0 replies; 6+ messages in thread
From: Jason Petersen @ 2016-04-01 19:26 UTC (permalink / raw)
To: pgsql-pkg-debian
> On Mar 25, 2016, at 4:43 PM, Jason Petersen <jason@citusdata.com> wrote:
>
> Thanks for any help, and looking forward to having our project in the repo!
Is there anything I need to do to kick this off?
--
Jason Petersen
Software Engineer | Citus Data
303.736.9255
jason@citusdata.com
Attachments:
[application/pgp-signature] signature.asc (495B, ../../969F63AB-CE5E-44E8-8416-A70462C13976@citusdata.com/3-signature.asc)
download
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Getting Citus into (Debian) PGDG
@ 2016-04-26 15:13 Christoph Berg <myon@debian.org>
parent: Jason Petersen <jason@citusdata.com>
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Berg @ 2016-04-26 15:13 UTC (permalink / raw)
To: Jason Petersen <jason@citusdata.com>; +Cc: pgsql-pkg-debian
Re: Jason Petersen 2016-03-26 <980D4281-A01F-4F5D-9874-FFED701F403F@citusdata.com>
> > On Mar 25, 2016, at 4:43 PM, Jason Petersen <jason@citusdata.com> wrote:
> >
> > though the most interesting bit is the debian directory <https://github.com/citusdata/packaging/tree/525a46c8b6ac5ab7c52015f8b74bee254559de40/debian;
>
> And of course I provided a link to a stale debian directory commit. Latest is here: https://github.com/citusdata/packaging/tree/8cc20250b8df0b0d8cfb95f1a68145e5ef11a205/debian <https://github.com/citusdata/packaging/tree/8cc20250b8df0b0d8cfb95f1a68145e5ef11a205/debian;
Hi Jason,
to continue here after the discussion on IRC, citus was just accepted
into Debian unstable. In other words, welcome to the wonderful world
of interesting architectures with arcane features :)
https://buildd.debian.org/status/package.php?p=citus
That said, there's a build failure on s390x:
https://buildd.debian.org/status/fetch.php?pkg=citus&arch=s390x&ver=5.0.1-1&stamp=146167...
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -I/usr/include/mit-krb5 -fPIC -pie -fpic -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wall -Wextra -Wno-unused-parameter -Wno-sign-compare -Wno-missing-field-initializers -Wno-clobbered -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wmissing-declarations -Wmissing-prototypes -shared -o citus.so ./shared_library_init.o commands/create_distributed_table.o commands/transmit.o executor/multi_utility.o executor/multi_router_executor.o executor/multi_server_executor.o executor/multi_real_time_executor.o executor/multi_executor.o executor/multi_task_tracker_executor.o executor/multi_client_executor.o master/master_stage_protocol.o master/master_metadata_utility.o master/master_delete_protocol.o master/master_repair_shards.o master/master_create_shards.o master/worker_node_manager.o master/master_node_protocol.o planner/multi_physical_planner.o planner/multi_master_planner.o planner/multi_explain.o planner/multi_logical_planner.o planner/multi_planner.o planner/multi_join_order.o planner/modify_planner.o planner/multi_logical_optimizer.o relay/relay_event_utility.o test/generate_ddl_commands.o test/connection_utils.o test/prune_shard_list.o test/distribution_metadata.o test/test_helper_functions.o test/connection_cache.o test/fake_fdw.o test/create_shards.o utils/listutils.o utils/citus_readfuncs_94.o utils/ruleutils_94.o utils/multi_resowner.o utils/resource_lock.o utils/citus_outfuncs.o utils/metadata_cache.o utils/connection_cache.o utils/citus_read.o utils/citus_ruleutils.o utils/citus_nodefuncs.o utils/citus_readfuncs_95.o utils/ruleutils_95.o worker/worker_partition_protocol.o worker/task_tracker_protocol.o worker/task_tracker.o worker/worker_file_access_protocol.o worker/worker_data_fetch_protocol.o worker/worker_merge_protocol.o -L/usr/lib/s390x-linux-gnu -Wl,-z,relro -Wl,-z,now -Wl,--as-needed -L/usr/lib/mit-krb5 -L/usr/lib/s390x-linux-gnu/mit-krb5 -Wl,--as-needed -Wl,-z,relro -L/usr/lib/s390x-linux-gnu -lpq
utils/ruleutils_95.o: In function `simple_quote_literal':
/«PKGBUILDDIR»/src/backend/distributed/utils/ruleutils_95.c:6114:(.text+0x596): relocation truncated to fit: R_390_GOT12 against undefined symbol `standard_conforming_strings'
I've had that problem before, but forgot most of it. I think the
problem is that "-fPIC -pie -fpic" isn't consistent and should
probably be "-fPIC -PIE", but I might be totally wrong. (I'll try to
dig up some docs.)
Christoph
--
Sent via pgsql-pkg-debian mailing list (pgsql-pkg-debian@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-debian
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Getting Citus into (Debian) PGDG
@ 2016-04-26 15:32 Christoph Berg <myon@debian.org>
parent: Christoph Berg <myon@debian.org>
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Berg @ 2016-04-26 15:32 UTC (permalink / raw)
To: Jason Petersen <jason@citusdata.com>; pgsql-pkg-debian
Re: To Jason Petersen 2016-04-26 <20160426151339.GF12563@msg.df7cb.de>
> I've had that problem before, but forgot most of it. I think the
> problem is that "-fPIC -pie -fpic" isn't consistent and should
> probably be "-fPIC -PIE", but I might be totally wrong. (I'll try to
> dig up some docs.)
Just talked to a s390x porter, the flags used should be -fPIC -pie",
i.e. without the lower case version.
Christoph
--
Sent via pgsql-pkg-debian mailing list (pgsql-pkg-debian@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-debian
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: Getting Citus into (Debian) PGDG
@ 2016-04-27 23:05 Andres Freund <andres@anarazel.de>
parent: Christoph Berg <myon@debian.org>
0 siblings, 0 replies; 6+ messages in thread
From: Andres Freund @ 2016-04-27 23:05 UTC (permalink / raw)
To: Christoph Berg <myon@debian.org>; Jason Petersen <jason@citusdata.com>; pgsql-pkg-debian
On 2016-04-26 17:32:35 +0200, Christoph Berg wrote:
> Re: To Jason Petersen 2016-04-26 <20160426151339.GF12563@msg.df7cb.de>
> > I've had that problem before, but forgot most of it. I think the
> > problem is that "-fPIC -pie -fpic" isn't consistent and should
> > probably be "-fPIC -PIE", but I might be totally wrong. (I'll try to
> > dig up some docs.)
>
> Just talked to a s390x porter, the flags used should be -fPIC -pie",
> i.e. without the lower case version.
Afaics, that's citus independent, and coming from postgres code.
Makefile.port:
ifeq "$(findstring sparc,$(host_cpu))" "sparc"
CFLAGS_SL = -fPIC
else
CFLAGS_SL = -fpic
endif
I'm not clear why citus triggers this, when other extensions don't?
Andres
--
Sent via pgsql-pkg-debian mailing list (pgsql-pkg-debian@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-debian
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2016-04-27 23:05 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-03-25 22:43 Getting Citus into (Debian) PGDG Jason Petersen <jason@citusdata.com>
2016-03-25 23:03 ` Jason Petersen <jason@citusdata.com>
2016-04-26 15:13 ` Christoph Berg <myon@debian.org>
2016-04-26 15:32 ` Christoph Berg <myon@debian.org>
2016-04-27 23:05 ` Andres Freund <andres@anarazel.de>
2016-04-01 19:26 ` Jason Petersen <jason@citusdata.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox