Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dyjCi-0008Fn-SZ for pgsql-pkg-debian@arkaria.postgresql.org; Sun, 01 Oct 2017 18:43:04 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dyjCi-0004DQ-9U for pgsql-pkg-debian@arkaria.postgresql.org; Sun, 01 Oct 2017 18:43:04 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dyjCc-00045X-HJ for pgsql-pkg-debian@postgresql.org; Sun, 01 Oct 2017 18:42:58 +0000 Received: from feynman.df7cb.de ([195.49.152.168]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dyjCU-0005IS-WD for pgsql-pkg-debian@postgresql.org; Sun, 01 Oct 2017 18:42:57 +0000 Received: from msg.df7cb.de (unknown [IPv6:2a02:908:1474:d80:76e5:bff:fef3:7e00]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by feynman.df7cb.de (Postfix) with ESMTPSA id 3y4vLJ0Lgpz3F1m; Sun, 1 Oct 2017 20:42:48 +0200 (CEST) Date: Sun, 1 Oct 2017 20:42:47 +0200 From: Christoph Berg To: Peter Geoghegan Cc: pgsql-pkg-debian@postgresql.org Subject: Re: amcheck packages Message-ID: <20171001184247.6behs6v6po3caizw@msg.df7cb.de> Mail-Followup-To: Christoph Berg , Peter Geoghegan , pgsql-pkg-debian@postgresql.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) X-Mailing-List: pgsql-pkg-debian List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Precedence: bulk Sender: pgsql-pkg-debian-owner@postgresql.org Re: Peter Geoghegan 2017-10-01 > I would like to make amcheck available in the pgdg apt repo, in order > to target earlier PostgreSQL versions. It's available as a contrib > extension for v10 already, but there is no reason why it cannot be > used on earlier versions. The Github version has the ability to build > deb packages already: > > https://github.com/petergeoghegan/amcheck > > I'll also want to make available the enhancement that is proposed for > Postgres 11, from the current commitfest [1]. So, the goal will be to > target Postgres 9.4, 9.5, 9.6, and 10 - v10 will not have an enhanced > version, which I believe adds significantly more value. > > Is there an acceptance process? How can I get the ball rolling on that? Hi Peter, all we need is a proper debian/ directory, which your repository already has. The packaging looks good, even including tests, cool :) I've configured the build jobs in our jenkins and gave it a go. The build almost worked, the only problem is that the topmost changelog entry in debian/changelog has a malformed timestamp which dpkg is complaining about. On Ubuntu zesty, that problem is even fatal. For the other dists, everything worked including the testsuite. Could you fix that changelog entry, possibly adding a 0.3-2 or 0.4-1 stanza? If you use "dch" (dch -i) to edit the changelog, it will take care of the timestamp. Also, if you want to build Debian packages from git repo's HEAD, it is often easier to set debian/source/format to "1.0" which will disable the "there are changes neither in the tarball nor in debian/patches" check. Christoph -- Sent via pgsql-pkg-debian mailing list (pgsql-pkg-debian@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-pkg-debian