Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dyvJP-0007LM-Gd for pgsql-pkg-debian@arkaria.postgresql.org; Mon, 02 Oct 2017 07:38:47 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dyvJP-000722-3N for pgsql-pkg-debian@arkaria.postgresql.org; Mon, 02 Oct 2017 07:38:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dyvJO-00071s-OS for pgsql-pkg-debian@postgresql.org; Mon, 02 Oct 2017 07:38:46 +0000 Received: from feynman.df7cb.de ([195.49.152.168]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dyvJL-0002Bs-8r for pgsql-pkg-debian@postgresql.org; Mon, 02 Oct 2017 07:38:46 +0000 Received: from msg.df7cb.de (unknown [IPv6:2003:5b:203b:100:7627:eaff:fe52:8e03]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by feynman.df7cb.de (Postfix) with ESMTPSA id 3y5DYZ20P2z3F3Y; Mon, 2 Oct 2017 09:38:42 +0200 (CEST) Date: Mon, 2 Oct 2017 09:38:42 +0200 From: Christoph Berg To: Peter Geoghegan Cc: pgsql-pkg-debian@postgresql.org Subject: Re: amcheck packages Message-ID: <20171002073842.yzp5i2xcihmj62co@msg.df7cb.de> Mail-Followup-To: Christoph Berg , Peter Geoghegan , pgsql-pkg-debian@postgresql.org References: <20171001184247.6behs6v6po3caizw@msg.df7cb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) X-Mailing-List: pgsql-pkg-debian List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Precedence: bulk Sender: pgsql-pkg-debian-owner@postgresql.org Re: Peter Geoghegan 2017-10-01 > > Could you fix that changelog entry, possibly adding a 0.3-2 or 0.4-1 > > stanza? If you use "dch" (dch -i) to edit the changelog, it will take > > care of the timestamp. > > I can take care of that. I'll also update the debian/copyright file, > and include the omitted sql files in the Makefile. This will become > 0.3-2. Putting this 0.3-2 on top of master will only work if you also do the "1.0" change in debian/source/format, or else dpkg will complain about differences between the 0.3 tarball and the checkout. (That's why I suggested 0.4.) > I can push a temporary branch to Github, for your review. Does that > work for you? I can point Jenkins at branches/tags for building, no problem. > > Also, if you want to build Debian packages from git repo's HEAD, it is > > often easier to set debian/source/format to "1.0" which will disable > > the "there are changes neither in the tarball nor in debian/patches" > > check. > > I thought that it would be useful to have version numbers that > deliberately don't overlap with the Postgres contrib version numbers. > Though now, maybe what I should do instead is rename the extension to > something like amcheck-next. That would probably avoid confusion, and > also allow me to use 1.0 as a version number. What do you think of > that idea? Does the extension sql file have any difference between the versions? What I'm often seeing is that extension authors will increment the extension version even for C-only changes. If it's really the same extension, just a newer codebase, why not have 1.0 in PG10, and use 1.1 here. Renaming the extension somewhat implies it would be co-installable with the original. (On diffing the SQL files, I see that the difference is that "PARALLEL RESTRICTED" got dropped, is that intended? It is not reflected in any of the amcheck--*--*.sql files.) Christoph -- Sent via pgsql-pkg-debian mailing list (pgsql-pkg-debian@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-pkg-debian