Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h99WD-0006gw-Kw for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Mar 2019 14:27:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h99WC-0007qO-DM for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Mar 2019 14:27:04 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h99WC-0007lF-1O for pgsql-hackers@lists.postgresql.org; Wed, 27 Mar 2019 14:27:04 +0000 Received: from mail-wm1-x342.google.com ([2a00:1450:4864:20::342]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h99W9-0002Qe-83 for pgsql-hackers@lists.postgresql.org; Wed, 27 Mar 2019 14:27:02 +0000 Received: by mail-wm1-x342.google.com with SMTP id 4so256312wmf.1 for ; Wed, 27 Mar 2019 07:27:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=b34l02eJDHVGXQrYYBZHoD+QlEUJ/zUeUrE/xbU3jUg=; b=JS1JQBi4X9PuoXSktZHvj9wVJ63WEka/2RuuDpU0Nhh7d6hk6ZqpCMp/7je7viKv8A YQpbaPNLdn0afIZEqrTZjXIJNtaNT1tQw2gkdk1Dton+d1Ncuvo0aQamM6kUnailXvcd u2PwqxXuj9WetoLiVA/7SBuN3jcZiwhkEsG7uVVJAMGtWfiWN4/ZnedW933Ok/nYnT2V 3y/QMWJ6w1Tlymg2TIY6YRCMEuBv7x+FeX5kXQpnc2zG9iDFM2hHNjeGfDFmaykmtcas Ny+2lyE5hB+LMPRqgC1QpZYPioPOV9V6uQ1Ga09bPZqGaOV8pcEILkG1ih4QeXKfqwoG TLgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=b34l02eJDHVGXQrYYBZHoD+QlEUJ/zUeUrE/xbU3jUg=; b=BiBIKErKIbHem64Ac83nw8OM37KgEHaWWql8VKYnnxScgFf5QkPzSvMXT2G6CNqGbO mNECPFC67V0V+QvcHxzoYJmQbwGMmfdHCwfHAvUnxHxpqaxcbqk17+W3k6PXqhonXKSZ yjbjGqpOw7bVN3CkLirLnLEkrZrnjFlw8SE3dycWldh7PpLHkBzlh3DherFHSbYafBgr d9+irceEKWkeTaYSgEN+zcOzws+5IxGiH2tcT3+GnvLANH8Fh7Xe4ulqAddhuvPcVzu+ +UeODWcIwqoZ7ZeSjtWzvD3yJczj+ZvwnuUc51OwfZxW0LW59E7IfLQBygKULmVjci2d 5XGw== X-Gm-Message-State: APjAAAUqYBmRezZBgeFQKr4t/M5NmgW1mHx/JZksPKvMiCB/zlxjdx64 A10kmMqEsSVRiwpEGQuXSH0avQ== X-Google-Smtp-Source: APXvYqzrIfpGeZ4Ex8VO9sRjA+r7xPkpjbSDC9DoR0OdRkHP6FL+LYZRu5ZkyNtk5nqgLalaieg2Uw== X-Received: by 2002:a1c:6587:: with SMTP id z129mr18005037wmb.84.1553696819814; Wed, 27 Mar 2019 07:26:59 -0700 (PDT) Received: from localhost (static-84-42-175-93.net.upcbroadband.cz. [84.42.175.93]) by smtp.gmail.com with ESMTPSA id t2sm46584109wra.9.2019.03.27.07.26.58 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 27 Mar 2019 07:26:59 -0700 (PDT) Date: Wed, 27 Mar 2019 15:26:57 +0100 From: Tomas Vondra To: Andreas Karlsson Cc: "Fred .Flintstone" , Mark Kirkwood , Tom Lane , Michael Paquier , Chris Travers , Tatsuo Ishii , Alvaro Herrera , Euler Taveira , Julien Rouhaud , Postgres hackers Subject: Re: PostgreSQL pollutes the file system Message-ID: <20190327142657.GC17983@development> References: <20190321004919.GE20192@paquier.xyz> <10036.1553176960@sss.pgh.pa.us> <20190322003611.GK20192@paquier.xyz> <31754.1553220346@sss.pgh.pa.us> <3edd2644-eaf2-41e0-aa7a-92786d25b29c@catalyst.net.nz> <20190327135116.GA17983@development> <044a865f-c0c2-70e4-f4d0-ec841d701fda@proxel.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <044a865f-c0c2-70e4-f4d0-ec841d701fda@proxel.se> User-Agent: Mutt/1.11.3 (2019-02-01) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On Wed, Mar 27, 2019 at 03:07:24PM +0100, Andreas Karlsson wrote: >On 3/27/19 2:51 PM, Tomas Vondra wrote: >>I think the consensus in this thread (and the previous ancient ones) is >>that it's not worth it. It's one thing to introduce new commands with the >>pg_ prefix, and it's a completely different thing to rename existing ones. >>That has inherent costs, and as Tom pointed out the burden would fall on >>people using PostgreSQL (and that's rather undesirable). >> >>I personally don't see why having commands without pg_ prefix would be >>an issue. Especially when placed in a separate directory, which eliminates >>the possibility of conflict with other commands. > >I buy that it may not be worth breaking tens of thousands of scripts >to fix this, but I disagree about it not being an issue. Most Linux >distributions add PostgreSQL's executables in to a directory which is >in the default $PATH (/usr/bin in the case of Debian). And even if it >would be installed into a separate directory there would still be a >conflict as soon as that directory is added to $PATH. > That is true, of course. But are there actual examples of such conflicts in practice? I mean, are there tools/packages that provide commands with a conflicting name? I'm not aware of any, and as was pointed before, we'd have ~20 years of history on any new ones. >And I think that it is also relatively easy to confuse adduser and >createuser when reading a script. Nothing about the name createuser >indicates that it will create a role in an SQL database. > Sure, and I've confused those tools too in the past. But that's not something you'll hit in a script, at least not if you test it before running it on production system. And if you're running untested scripts, this is likely the least of your problems ... cheers -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services