Date: Mon, 21 Jul 2025 23:49:59 -0700
From: Jeremy Schneider <schneider@ardentperf.com>
To: Huang Yuying <huangyy159@hotmail.com>
Cc: Christoph Berg <myon@debian.org>, "pgsql-pkg-debian@postgresql.org"
 <pgsql-pkg-debian@postgresql.org>, "bertranddrouvot.pg@gmail.com"
 <bertranddrouvot.pg@gmail.com>
Subject: Re: Request to Add New Package: pgsentinel
Message-ID: <20250721234959.12020aa2@ardentperf.com>
In-Reply-To: <468473AA-ABA8-49D1-8EAE-0C43E3968F1E@hotmail.com>
References: <394D2E6D-8779-49B3-AB29-C55DD1F7F9EB@hotmail.com>
	<aH6dyX_H4Zpx7TOj@msg.df7cb.de>
	<468473AA-ABA8-49D1-8EAE-0C43E3968F1E@hotmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/20250721234959.12020aa2%40ardentperf.com>
Precedence: bulk

On Mon, 21 Jul 2025 22:55:28 +0000
Huang Yuying <huangyy159@hotmail.com> wrote:

> Regarding the build issue you mentioned, for testing, we manually
> downloaded the code from my GitHub repository (forked repo:
> https://github.com/laurahuang106/pgsentinel) instead of letting
> Debian pull it using the watch file.

FYI - running through it just now, and Laura I think an editor turned
the tabs into spaces at some point while the files were on their way to
GitHub. Should be a quick & easy fix.

After I changed the spaces back to tabs, and updated the file
pgsentinel_1.1.0.orig.tar.gz one level up from my build directory, the
tests succeed and the packages build for me.

I think we can go ahead and send Bertrand a PR with the two Makefile
updates. I suspect the top-level Makefile is the best way to go here.

-Jeremy


-- 
To know the thoughts and deeds that have marked man's progress is to
feel the great heart throbs of humanity through the centuries; and if
one does not feel in these pulsations a heavenward striving, one must
indeed be deaf to the harmonies of life.

Helen Keller. Let Us Have Faith. Doubleday, Doran & Company, 1940.