Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFkZL-0002rT-A0 for pgsql-hackers@arkaria.postgresql.org; Tue, 30 May 2017 17:04:31 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dFkZK-0001kg-Qw for pgsql-hackers@arkaria.postgresql.org; Tue, 30 May 2017 17:04:30 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dFkZI-0001fw-O1; Tue, 30 May 2017 17:04:28 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dFkZF-0004kr-IF; Tue, 30 May 2017 17:04:28 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v4UH463D025132; Tue, 30 May 2017 13:04:06 -0400 From: Tom Lane To: Christoph Berg cc: Andres Freund , Jason Petersen , pgsql-pkg-debian@postgresql.org, PostgreSQL Hackers Subject: Re: [PATCH] relocation truncated to fit: citus build failure on s390x In-reply-to: <20170530165258.ptkt2u457wqfmqye@msg.df7cb.de> References: <980D4281-A01F-4F5D-9874-FFED701F403F@citusdata.com> <20160426151339.GF12563@msg.df7cb.de> <20160426153235.GA2862@msg.df7cb.de> <20160427230516.44fuzdxlifch2wwp@alap3.anarazel.de> <20160428080824.GA22412@msg.df7cb.de> <20170529155850.qojdfrwkkqnjb3ap@msg.df7cb.de> <27883.1496087111@sss.pgh.pa.us> <20170530161541.koj5xbvvovrrtxtd@alap3.anarazel.de> <20170530165258.ptkt2u457wqfmqye@msg.df7cb.de> Comments: In-reply-to Christoph Berg message dated "Tue, 30 May 2017 18:52:58 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <25130.1496163846.1@sss.pgh.pa.us> Date: Tue, 30 May 2017 13:04:06 -0400 Message-ID: <25131.1496163846@sss.pgh.pa.us> X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Christoph Berg writes: > My main point here would be that we are already setting this for all > extensions for sparc and sparc64, so s390(x) would just follow suit. For some values of "we", sure ;-). But I think what is really under discussion here is whether to change -fpic to -fPIC for all platforms. It looks like Makefile.netbsd and Makefile.openbsd would be affected along with Makefile.linux. Some other platforms such as freebsd are already in the fPIC-always camp. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers