Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFQbg-0006fv-0t for pgsql-hackers@arkaria.postgresql.org; Mon, 29 May 2017 19:45:36 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1dFQbf-0001jt-Jj for pgsql-hackers@arkaria.postgresql.org; Mon, 29 May 2017 19:45:35 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dFQbd-0001ai-1D; Mon, 29 May 2017 19:45:33 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dFQbS-0005V9-Sq; Mon, 29 May 2017 19:45:32 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id v4TJjBbH027884; Mon, 29 May 2017 15:45:11 -0400 From: Tom Lane To: Christoph Berg cc: Andres Freund , Jason Petersen , pgsql-pkg-debian@postgresql.org, PostgreSQL Hackers Subject: Re: [PATCH] relocation truncated to fit: citus build failure on s390x In-reply-to: <20170529155850.qojdfrwkkqnjb3ap@msg.df7cb.de> References: <980D4281-A01F-4F5D-9874-FFED701F403F@citusdata.com> <20160426151339.GF12563@msg.df7cb.de> <20160426153235.GA2862@msg.df7cb.de> <20160427230516.44fuzdxlifch2wwp@alap3.anarazel.de> <20160428080824.GA22412@msg.df7cb.de> <20170529155850.qojdfrwkkqnjb3ap@msg.df7cb.de> Comments: In-reply-to Christoph Berg message dated "Mon, 29 May 2017 17:58:50 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <27882.1496087111.1@sss.pgh.pa.us> Date: Mon, 29 May 2017 15:45:11 -0400 Message-ID: <27883.1496087111@sss.pgh.pa.us> X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Christoph Berg writes: > Re: To Andres Freund 2016-04-28 <20160428080824.GA22412@msg.df7cb.de> >>> I'm not clear why citus triggers this, when other extensions don't? >> Maybe it's simply because citus.so is bigger than all the other >> extension .so files: I wonder what the overhead is of using -fPIC when -fpic would be sufficient. Whatever it is, the proposed patch imposes it on every shlib or extension, to accommodate one single extension that isn't even one we ship. Maybe this is small enough to not be something we need to worry about, but I'm wondering if we should ask citus and other large .so's to set some additional make flag that would cue usage of -fPIC over -fpic. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers