Subject: Re: Confusing message on server install
To: pgsql-pkg-debian@postgresql.org, Christoph Berg <myon@debian.org>
References: <b79c377c-f629-2ef0-29a9-fedb686fe997@gmail.com>
From: Alexander Lakhin <exclusion@gmail.com>
Message-ID: <5df468f5-243e-f1b6-8944-27ef94f41648@gmail.com>
Date: Tue, 29 Oct 2019 10:00:00 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.2
MIME-Version: 1.0
In-Reply-To: <b79c377c-f629-2ef0-29a9-fedb686fe997@gmail.com>
Content-Type: multipart/mixed;
 boundary="------------18CAA82DB85130B91B7E6B2D"
Content-Language: en-US
Precedence: bulk

This is a multi-part message in MIME format.
--------------18CAA82DB85130B91B7E6B2D
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

Hello,

18.10.2019 13:19, Alexander Lakhin wrote:
> While installing the postgresql-12 server package on Debian Buster I see
> the following output:
> # apt-get install postgresql-12
> ...
> Creating new PostgreSQL cluster 12/main ...
> /usr/lib/postgresql/12/bin/initdb -D /var/lib/postgresql/12/main
> --auth-local peer --auth-host md5
> ...
> performing post-bootstrap initialization ... ok
> syncing data to disk ... ok
>
> Success. You can now start the database server using:
>
>     pg_ctlcluster 12 main start
> So I see the message "Success. You can now start the database server
> using:", but in fact the server is running.
Please look at the proposed improvement that suppresses this confusing
message.

Best regards,
Alexander

--------------18CAA82DB85130B91B7E6B2D
Content-Type: text/x-patch;
 name="pg_createcluster.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="pg_createcluster.diff"

--- a/pg_createcluster	2019-07-09 16:57:45.000000000 +0300
+++ b/pg_createcluster	2019-10-29 06:16:00.935081461 +0300
@@ -351,7 +351,9 @@
 } else {
     print "Creating new PostgreSQL cluster $version/$cluster ...\n";
     # ask initdb to print a different cluster start command (Debian patch)
-    $ENV{CLUSTER_START_COMMAND} = "pg_ctlcluster $version $cluster start";
+    if (!defined $ENV{CLUSTER_START_COMMAND}) {
+        $ENV{CLUSTER_START_COMMAND} = "pg_ctlcluster $version $cluster start";
+    }
     init_db $version, $datadir, $owneruid, $ownergid, \@initdb_opts_from_cli;
     $newcluster = 1;
 }

--------------18CAA82DB85130B91B7E6B2D
Content-Type: text/x-patch;
 name="maintscripts-functions.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="maintscripts-functions.diff"

--- a/maintscripts-functions	2018-09-20 17:02:06.000000000 +0300
+++ b/maintscripts-functions	2019-10-29 07:41:55.892583740 +0300
@@ -86,6 +86,7 @@
         create=$(pg_conftool /etc/postgresql-common/createcluster.conf show -bs create_main_cluster || :)
         if [ -z "$2" ] && [ "$create" != "off" ]; then
             set_system_locale
+            export CLUSTER_START_COMMAND=""
             pg_createcluster -u postgres $VERSION main ||
                 echo "Error: could not create default cluster. Please create it manually with
 

--------------18CAA82DB85130B91B7E6B2D
Content-Type: text/plain; charset=UTF-8;
 name="initdb-startup-message"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="initdb-startup-message"

QXV0aG9yOiBDaHJpc3RvcGggQmVyZyA8bXlvbkBkZWJpYW4ub3JnPgpEZXNjcmlwdGlvbjog
RGViaWFuLXNwZWNpZmljIGNsdXN0ZXIgc3RhcnR1cCBtZXNzYWdlIGZyb20gaW5pdGRiCkZv
cndhcmRlZDogTm8sIERlYmlhbiBzcGVjaWZpYwoKLS0tIGEvc3JjL2Jpbi9pbml0ZGIvaW5p
dGRiLmMKKysrIGIvc3JjL2Jpbi9pbml0ZGIvaW5pdGRiLmMKQEAgLTMzNjEsOSArMzM2MSwx
MCBAQAogCS8qIHRyYW5zbGF0b3I6IFRoaXMgaXMgYSBwbGFjZWhvbGRlciBpbiBhIHNoZWxs
IGNvbW1hbmQuICovCiAJYXBwZW5kUFFFeHBCdWZmZXIoc3RhcnRfZGJfY21kLCAiIC1sICVz
IHN0YXJ0IiwgXygibG9nZmlsZSIpKTsKIAotCXByaW50ZihfKCJcblN1Y2Nlc3MuIFlvdSBj
YW4gbm93IHN0YXJ0IHRoZSBkYXRhYmFzZSBzZXJ2ZXIgdXNpbmc6XG5cbiIKKwlpZiAoIWdl
dGVudigiQ0xVU1RFUl9TVEFSVF9DT01NQU5EIikgfHwgc3RybGVuKGdldGVudigiQ0xVU1RF
Ul9TVEFSVF9DT01NQU5EIikpID4gMCkKKwkJcHJpbnRmKF8oIlxuU3VjY2Vzcy4gWW91IGNh
biBub3cgc3RhcnQgdGhlIGRhdGFiYXNlIHNlcnZlciB1c2luZzpcblxuIgogCQkJICIgICAg
JXNcblxuIiksCi0JCSAgIHN0YXJ0X2RiX2NtZC0+ZGF0YSk7CisJCQkgICBnZXRlbnYoIkNM
VVNURVJfU1RBUlRfQ09NTUFORCIpID8gZ2V0ZW52KCJDTFVTVEVSX1NUQVJUX0NPTU1BTkQi
KSA6IHN0YXJ0X2RiX2NtZC0+ZGF0YSk7CiAKIAlkZXN0cm95UFFFeHBCdWZmZXIoc3RhcnRf
ZGJfY21kKTsKIAo=
--------------18CAA82DB85130B91B7E6B2D--