Content-Type: multipart/alternative;
 boundary="------------nXV0OPvjurIcS0mM0dnEw5Go"
Message-ID: <75679669-4482-3f16-bd4d-6ec1f9950941@abcsql.com>
Date: Wed, 7 Jun 2023 17:50:59 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.11.0
Subject: Re: Packaging request MobilityDB
Content-Language: fr, en-US
To: Esteban Zimanyi <estebanzimanyi@gmail.com>,
 Bradford Boyle <bradford.d.boyle@gmail.com>
Cc: pgsql-pkg-debian@lists.postgresql.org,
 SCHOEMANS Maxime <Maxime.Schoemans@ulb.be>
References: 
 <CAPqRbE716D3gpD0JDbaFAb72ELaJrPpG1LUZvobELNBgL3R0+g@mail.gmail.com>
 <CAOMoQbRMo5HM4eMsUmcQ+5_eGUZK6zycMgifnEehbooee+L5HA@mail.gmail.com>
 <CAOMoQbQPOs827ZNk2atm0JHQYDJ4iW339a8HxovxUZzpa4RjtA@mail.gmail.com>
 <CAPqRbE7W2ifWkjAGZ36cAE1kd23m0gmz5sgn_49MWam2kA+=CQ@mail.gmail.com>
From: =?UTF-8?Q?C=c3=a9dric_Villemain?= <cedric.villemain@abcsql.com>
Organization: Data Bene
In-Reply-To: 
 <CAPqRbE7W2ifWkjAGZ36cAE1kd23m0gmz5sgn_49MWam2kA+=CQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/75679669-4482-3f16-bd4d-6ec1f9950941%40abcsql.com>
Precedence: bulk

This is a multi-part message in MIME format.
--------------nXV0OPvjurIcS0mM0dnEw5Go
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Le 07/06/2023 à 17:16, Esteban Zimanyi a écrit :
> Dear Bradford
>
> Many thanks for your work.


Seconded! and tks for MobilityDB too !


> * We solved the stack smashing problem you found.
> * We set the log_error_verbosity to terse for the tests and removed 
> the special treatment of ERROR, CONTEXT, and WARNING that may vary 
> across PostgreSQL and PostGIS versions.
> * For the tests, we can easily switch to the settings 'PST8PDT' for 
> the timezone and 'Postgres, MDY' for the date style if this is the 
> general way to do things. We simply need to regenerate all tests and 
> push them in a new commit. We just wonder if the same settings are 
> equally valid for all other distributions. Please advise.
>
Yeah, 'PST8PDT' is the way to go for PostgreSQL test [1]

I believe it's valid for other distributions.

Apparently datestyle is not documented here, but pg_regress does:

      /*
       * Set timezone and datestyle for datetime-related tests
       */
      setenv("PGTZ", "PST8PDT", 1);
      setenv("PGDATESTYLE", "Postgres, MDY", 1);

see also [2] which might be useful as it mentions some corner cases for 
other systems.


[1]: 
https://www.postgresql.org/docs/current/regress-evaluation.html#id-1.6.20.6.8

[2]: https://doxygen.postgresql.org/pg__regress_8c_source.html#l00702

---
Cédric Villemain +33 (0)6 20 30 22 52
https://Data-Bene.io
PostgreSQL: Expertise - Formation - Développement - Assistance Technique

--------------nXV0OPvjurIcS0mM0dnEw5Go
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: 8bit

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body>
    <div class="moz-cite-prefix">Le 07/06/2023 à 17:16, Esteban Zimanyi
      a écrit :<br>
    </div>
    <blockquote type="cite"
cite="mid:CAPqRbE7W2ifWkjAGZ36cAE1kd23m0gmz5sgn_49MWam2kA+=CQ@mail.gmail.com">
      <div dir="ltr">
        <div dir="ltr">Dear Bradford
          <div><br>
          </div>
          <div>Many thanks for your work. <br>
          </div>
        </div>
      </div>
    </blockquote>
    <p><br>
    </p>
    <p>Seconded! and tks for MobilityDB too !<br>
    </p>
    <p><br>
    </p>
    <blockquote type="cite"
cite="mid:CAPqRbE7W2ifWkjAGZ36cAE1kd23m0gmz5sgn_49MWam2kA+=CQ@mail.gmail.com">
      <div dir="ltr">
        <div dir="ltr">
          <div>* We solved the stack smashing problem you found.</div>
          <div>* We set the log_error_verbosity to terse for the tests
            and removed the special treatment of ERROR, CONTEXT, and
            WARNING that may vary across PostgreSQL and PostGIS
            versions.</div>
          <div>* For the tests, we can easily switch to the settings
            'PST8PDT' for the timezone and 'Postgres, MDY' for the date
            style if this is the general way to do things. We simply
            need to regenerate all tests and push them in a new commit.
            We just wonder if the same settings are equally valid for
            all other distributions. Please advise.</div>
          <div><br>
          </div>
        </div>
      </div>
    </blockquote>
    <p>Yeah, 'PST8PDT' is the way to go for PostgreSQL test [1]<br>
    </p>
    <p>I believe it's valid for other distributions. <br>
    </p>
    <p>Apparently datestyle is not documented here, but pg_regress does:</p>
    <p>     /*<br>
            * Set timezone and datestyle for datetime-related tests<br>
            */<br>
           setenv("PGTZ", "PST8PDT", 1);<br>
           setenv("PGDATESTYLE", "Postgres, MDY", 1);<br>
    </p>
    <p>see also [2] which might be useful as it mentions some corner
      cases for other systems.</p>
    <p><br>
    </p>
    <p><br>
    </p>
    <p>[1]:
<a class="moz-txt-link-freetext" href="https://www.postgresql.org/docs/current/regress-evaluation.html#id-1.6.20.6.8">https://www.postgresql.org/docs/current/regress-evaluation.html#id-1.6.20.6.8</a></p>
    <p>[2]:
      <a class="moz-txt-link-freetext" href="https://doxygen.postgresql.org/pg__regress_8c_source.html#l00702">https://doxygen.postgresql.org/pg__regress_8c_source.html#l00702</a></p>
    <pre class="moz-signature" cols="72">---
Cédric Villemain +33 (0)6 20 30 22 52
<a class="moz-txt-link-freetext" href="https://Data-Bene.io">https://Data-Bene.io</a>
PostgreSQL: Expertise - Formation - Développement - Assistance Technique</pre>
    <div id="grammalecte_menu_main_button_shadow_host" style="width:
      0px; height: 0px;"></div>
  </body>
</html>

--------------nXV0OPvjurIcS0mM0dnEw5Go--