Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.120.23.2.7\))
Subject: Re: Adding packages fro WAL-G and Odyssey
From: Andrey Borodin <x4mmm@yandex-team.ru>
In-Reply-To: <YOMyXyErQ50je0zh@msg.df7cb.de>
Date: Mon, 6 Dec 2021 12:09:55 +0500
Cc: pgsql-pkg-debian@postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <A8A5F8DD-F9A8-4407-9381-815C4B54A8E6@yandex-team.ru>
References: <5FDAF3A4-4C0D-47F5-821F-20CFD578B3C6@yandex-team.ru>
 <YDAvu3qeDUXbiwdB@msg.df7cb.de>
 <54DCFC65-56DE-43AE-8219-B9D19B5AA311@yandex-team.ru>
 <YOMyXyErQ50je0zh@msg.df7cb.de>
To: Christoph Berg <myon@debian.org>
Archived-At: 
 <https://www.postgresql.org/message-id/A8A5F8DD-F9A8-4407-9381-815C4B54A8E6%40yandex-team.ru>
Precedence: bulk


> 5 =D0=B8=D1=8E=D0=BB=D1=8F 2021 =D0=B3., =D0=B2 21:25, Christoph Berg =
<myon@debian.org> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0):
>=20
> Re: Andrey Borodin
>>> we'd need a proper debian/ directory for these, either in the =
upstream
>>> repo or in a separate one.
>> Odyssey had debian/ dir =
https://github.com/yandex/odyssey/tree/master/scripts/debian
>=20
> Hi,
>=20
> that directory would need to be /debian, not somewhere deeper in the
> tree. (Interestingly, you already have a /debian, just with less
> files.)
>=20
>> WAL-G is simply one Go binary. =
https://github.com/wal-g/wal-g/tree/master/cmd/pg
>> Though it's a separate Go binary for each DB: PG, MySQL, MSSQL, =
MongoDB etc. But I think it's better to start from PG anyway.
>> We used to build this binary and create almost empty debian/ dir with =
a script (FPA). We can commit this dir it it's better to have it in =
source tree.
>=20
> FPA usually doesn't produce "proper" packages with a curated
> debian/changelog (no throwing away of old entries, and sensible log
> messages) and the other bits.
>=20
> debian/rules shouldn't try to build a -dbg package these days
>=20
> debian/control shouldn't depend on postgresql-server-dev-13 but on
> postgresql-server-dev-all if you really need server headers instead of
> just the client ones.
>=20
> The Description needs more content
>=20
> Standards-Version is outdated
>=20
> Consider using debhelper-compat (=3D 13) instead of debian/compat 9
>=20
> Consider providing a systemd .service file along the init script

Thanks, Christoph!
We have updated /debian stuff in Odyssey. Can you please take a look =
again?
https://github.com/yandex/odyssey/pull/372/files

Best regards, Andrey Borodin.=