MIME-Version: 1.0
References: 
 <CAOMoQbT0VmMZFRA68Geff9MScuGRTwokCf81O-0dqja8hmjNpQ@mail.gmail.com>
In-Reply-To: 
 <CAOMoQbT0VmMZFRA68Geff9MScuGRTwokCf81O-0dqja8hmjNpQ@mail.gmail.com>
From: Brian Cosgrove <cosgroveb@gmail.com>
Date: Sun, 12 Jan 2025 06:47:05 -0600
Message-ID: 
 <CAGKCzNBZO-AQMfmbfbn20wvE+63j50YuPBKJupYLiDCmc84OeA@mail.gmail.com>
Subject: Re: PgBouncer 1.24.0 - New upstream version
To: Bradford Boyle <bradford.d.boyle@gmail.com>
Cc: pgsql-pkg-debian@postgresql.org
Content-Type: multipart/alternative; boundary="0000000000004cf14b062b81baf6"
Archived-At: 
 <https://www.postgresql.org/message-id/CAGKCzNBZO-AQMfmbfbn20wvE%2B63j50YuPBKJupYLiDCmc84OeA%40mail.gmail.com>
Precedence: bulk

--0000000000004cf14b062b81baf6
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hey Bradford,

I haven't run into that issue myself but will poke at it today and see if I
can reproduce it.

Unrelated to autopkgtest, I noticed in October that during debbuild the
package does not run the main pytest suite for pgbouncer? Is that
intentional? It appears that before the tests were rewritten in python that
the package ran the shell-based suite properly.

I submitted a patch that should be able to be incorporated as-is:
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D1085109


On Sat, Jan 11, 2025 at 2:46=E2=80=AFAM Bradford Boyle <bradford.d.boyle@gm=
ail.com>
wrote:

> Hi All,
>
> PgBouncer 1.24.0 was recently released [0]. I've updated the Debian
> package with this new version but I am running into some issues with the
> autopkgtests. The autopkgtests passes on Salsa's CI but is failing on
> my both my local system and jengus [1].
>
> On my local system, the test fails to create a new regress cluster
> because port 5432 is already in use. I recently switched my sbuild
> configuration from schroot to unshare. It looks like the unshare backend
> doesn't create a new network namespace when running the autopkgtests.
> If I stop the main postgres cluster on my machine before running
> sbuild/autopkgtest, then the test passes. After reviewing the
> autopkgtest docs [2] and the test script, I think we might need to add
> isolation-container to the test's restrictions. On my local system, this
> causes the test to be skipped since the unshare backend doesn't provide
> this capability.
>
> I will try to look in to this some more in the next few days, but I
> wanted to check and see if anyone had run into similar issues with
> building and testing other packages.
>
> -- Bradford
>
> [0]: https://github.com/pgbouncer/pgbouncer/releases/tag/pgbouncer_1_24_0
> [1]:
> https://jengus.postgresql.org/job/pgbouncer-binaries/101/architecture=3Da=
md64,distribution=3Dsid/
> [2]: https://people.debian.org/~eriberto/README.package-tests.html
>
>
>

--=20
Brian Cosgrove

--0000000000004cf14b062b81baf6
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hey Bradford,<div><br></div><div>I haven&#39;t run into th=
at issue myself but will poke at it today and see if I can reproduce it.</d=
iv><div><br></div><div>Unrelated to autopkgtest, I noticed in October that =
during debbuild the package does not run the main pytest suite for pgbounce=
r? Is that intentional? It appears that before the tests were rewritten in =
python that the package ran the shell-based suite properly.</div><div><br><=
/div><div>I submitted a patch that should be able to be incorporated as-is:=
=C2=A0<a href=3D"https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D108510=
9">https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D1085109</a></div><di=
v><br></div><div><br></div></div><br><div class=3D"gmail_quote gmail_quote_=
container"><div dir=3D"ltr" class=3D"gmail_attr">On Sat, Jan 11, 2025 at 2:=
46=E2=80=AFAM Bradford Boyle &lt;<a href=3D"mailto:bradford.d.boyle@gmail.c=
om">bradford.d.boyle@gmail.com</a>&gt; wrote:<br></div><blockquote class=3D=
"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(2=
04,204,204);padding-left:1ex">Hi All,<br>
<br>
PgBouncer 1.24.0 was recently released [0]. I&#39;ve updated the Debian<br>
package with this new version but I am running into some issues with the<br=
>
autopkgtests. The autopkgtests passes on Salsa&#39;s CI but is failing on<b=
r>
my both my local system and jengus [1].<br>
<br>
On my local system, the test fails to create a new regress cluster<br>
because port 5432 is already in use. I recently switched my sbuild<br>
configuration from schroot to unshare. It looks like the unshare backend<br=
>
doesn&#39;t create a new network namespace when running the autopkgtests.<b=
r>
If I stop the main postgres cluster on my machine before running<br>
sbuild/autopkgtest, then the test passes. After reviewing the<br>
autopkgtest docs [2] and the test script, I think we might need to add<br>
isolation-container to the test&#39;s restrictions. On my local system, thi=
s<br>
causes the test to be skipped since the unshare backend doesn&#39;t provide=
<br>
this capability.<br>
<br>
I will try to look in to this some more in the next few days, but I<br>
wanted to check and see if anyone had run into similar issues with<br>
building and testing other packages.<br>
<br>
-- Bradford<br>
<br>
[0]: <a href=3D"https://github.com/pgbouncer/pgbouncer/releases/tag/pgbounc=
er_1_24_0" rel=3D"noreferrer" target=3D"_blank">https://github.com/pgbounce=
r/pgbouncer/releases/tag/pgbouncer_1_24_0</a><br>
[1]: <a href=3D"https://jengus.postgresql.org/job/pgbouncer-binaries/101/ar=
chitecture=3Damd64,distribution=3Dsid/" rel=3D"noreferrer" target=3D"_blank=
">https://jengus.postgresql.org/job/pgbouncer-binaries/101/architecture=3Da=
md64,distribution=3Dsid/</a><br>
[2]: <a href=3D"https://people.debian.org/~eriberto/README.package-tests.ht=
ml" rel=3D"noreferrer" target=3D"_blank">https://people.debian.org/~eribert=
o/README.package-tests.html</a><br>
<br>
<br>
</blockquote></div><div><br clear=3D"all"></div><div><br></div><span class=
=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_s=
ignature">Brian Cosgrove</div>

--0000000000004cf14b062b81baf6--