MIME-Version: 1.0
References: 
 <CAGKCzNBZO-AQMfmbfbn20wvE+63j50YuPBKJupYLiDCmc84OeA@mail.gmail.com>
 <CAOMoQbROhu7WG9LnyjHb1RXJrax_HKKMBbwaou+jps0uZgqHFw@mail.gmail.com>
 <CAOMoQbQzutP0UMU3KUZAE4A9Jf8bS=uSBRdUX7g=9xxoBbosmQ@mail.gmail.com>
 <CAGKCzNAQKMKJ_BQcF=uzcfcM=vx8QYnT+jtzuv_yp=76zbhn7g@mail.gmail.com>
 <CAGKCzNAW4BFq_cSKpnPvG6hRF65G3HptjUvWVW=DefPaPMF2pg@mail.gmail.com>
 <CAGKCzNAJzhzxJ809y9e6ttYbL0k6id5KmkzmBrz5xZROd79etQ@mail.gmail.com>
 <CAGKCzNC6RkY54TrkqqQ9K83AF=vrYe+CB14-PUSLTF5YMbzrmA@mail.gmail.com>
 <CAOMoQbT3zRuL+YLeiUrOG5-vYsvrZ2MJF_DQoa3E94cBfdv6xw@mail.gmail.com>
 <Z6Is1o56psB3-TMT@msg.df7cb.de>
 <CAOMoQbTA2qOo+f_4JE+oYGupZANh-0msn_Pw36qb7v3PfT1e0w@mail.gmail.com>
 <Z6Mq3xL_VpiNwOFm@msg.df7cb.de>
In-Reply-To: <Z6Mq3xL_VpiNwOFm@msg.df7cb.de>
From: Brian Cosgrove <cosgroveb@gmail.com>
Date: Wed, 5 Feb 2025 06:40:41 -0600
Message-ID: 
 <CAGKCzNCKAEEJmd5Fn5Be4zu1YxS9okBoeqBX15_RijvBgouqzA@mail.gmail.com>
Subject: Re: PgBouncer 1.24.0 - New upstream version
To: Christoph Berg <cb@df7cb.de>, Bradford Boyle <bradford.d.boyle@gmail.com>,
	pgsql-pkg-debian@postgresql.org
Content-Type: multipart/alternative; boundary="0000000000008fecc5062d646f4b"
Archived-At: 
 <https://www.postgresql.org/message-id/CAGKCzNCKAEEJmd5Fn5Be4zu1YxS9okBoeqBX15_RijvBgouqzA%40mail.gmail.com>
Precedence: bulk

--0000000000008fecc5062d646f4b
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Skipping this release for bullseye is not entirely unreasonable with Trixie
pending.

Skipping the entire suite feels unreasonable if the Postgres Debian team
releases 1.24.

I am working up a patch that will skip only these tests that will likely be
accepted upstream as well, should Debian choose to release 1.24 for
bullseye.

https://github.com/pgbouncer/pgbouncer/pull/1266


On Wed, Feb 5, 2025 at 3:10=E2=80=AFAM Christoph Berg <cb@df7cb.de> wrote:

> Re: Bradford Boyle
> > I think we could go without tests on bullseye since it seems like we ar=
e
> > nearing the trixie release and bullseye will become old old stable.
> > (Correct me if I am wrong on this point, I'm making this assumption
> > based on the trixie freeze dates). There's probably little value in
> > creating extra work here.
>
> Or we just don't update the package on bullseye, leaving it at 1.23.1.
> But there is still the autopkgtest, so we still have test coverage
> there.
>
> > It looks like d/rules for pgbouncer will skip the tests if nocheck is i=
n
> > DEB_BUILD_OPTIONS -- is this something that can be configured via the
> Jenkins
> > YAML? I am not very familiar with the Jenkins job builder YAML and I
> didn't see
> > any usages of that in the current set of jobs. Or would I need to updat=
e
> > generate-pgdg-source to include an additional tweak to disable the test=
s
> on
> > older platforms?
>
> Any of these would work.
>
> DEB_BUILD_OPTIONS=3Dnocheck would have to be set in the sbuild-package
> script. That's probably the easiest way forward.
>
> The extra test dependencies need annotating with <!nocheck> so the
> build doesn't try to install them.
>
> Christoph
>
>
>

--=20
Brian Cosgrove

--0000000000008fecc5062d646f4b
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Skipping this release for bullseye is not entirely unreaso=
nable with Trixie pending.=C2=A0<div><br></div><div>Skipping the entire sui=
te feels unreasonable if the Postgres Debian team releases 1.24.=C2=A0</div=
><div><br></div><div>I am working up a patch that will skip only these test=
s that will likely be accepted upstream as well,=C2=A0should Debian choose =
to release 1.24 for bullseye.=C2=A0</div><div><br></div><div><a href=3D"htt=
ps://github.com/pgbouncer/pgbouncer/pull/1266">https://github.com/pgbouncer=
/pgbouncer/pull/1266</a><br><div><br></div><div><br></div></div></div><br><=
div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, Feb=
 5, 2025 at 3:10=E2=80=AFAM Christoph Berg &lt;<a href=3D"mailto:cb@df7cb.d=
e" target=3D"_blank">cb@df7cb.de</a>&gt; wrote:<br></div><blockquote class=
=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid rg=
b(204,204,204);padding-left:1ex">Re: Bradford Boyle<br>
&gt; I think we could go without tests on bullseye since it seems like we a=
re<br>
&gt; nearing the trixie release and bullseye will become old old stable.<br=
>
&gt; (Correct me if I am wrong on this point, I&#39;m making this assumptio=
n<br>
&gt; based on the trixie freeze dates). There&#39;s probably little value i=
n<br>
&gt; creating extra work here.<br>
<br>
Or we just don&#39;t update the package on bullseye, leaving it at 1.23.1.<=
br>
But there is still the autopkgtest, so we still have test coverage<br>
there.<br>
<br>
&gt; It looks like d/rules for pgbouncer will skip the tests if nocheck is =
in<br>
&gt; DEB_BUILD_OPTIONS -- is this something that can be configured via the =
Jenkins<br>
&gt; YAML? I am not very familiar with the Jenkins job builder YAML and I d=
idn&#39;t see<br>
&gt; any usages of that in the current set of jobs. Or would I need to upda=
te<br>
&gt; generate-pgdg-source to include an additional tweak to disable the tes=
ts on<br>
&gt; older platforms?<br>
<br>
Any of these would work.<br>
<br>
DEB_BUILD_OPTIONS=3Dnocheck would have to be set in the sbuild-package<br>
script. That&#39;s probably the easiest way forward.<br>
<br>
The extra test dependencies need annotating with &lt;!nocheck&gt; so the<br=
>
build doesn&#39;t try to install them.<br>
<br>
Christoph<br>
<br>
<br>
</blockquote></div><div><br clear=3D"all"></div><div><br></div><span class=
=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_s=
ignature">Brian Cosgrove</div>

--0000000000008fecc5062d646f4b--