MIME-Version: 1.0
References: 
 <CAGKCzNBZO-AQMfmbfbn20wvE+63j50YuPBKJupYLiDCmc84OeA@mail.gmail.com>
 <CAOMoQbROhu7WG9LnyjHb1RXJrax_HKKMBbwaou+jps0uZgqHFw@mail.gmail.com>
 <CAOMoQbQzutP0UMU3KUZAE4A9Jf8bS=uSBRdUX7g=9xxoBbosmQ@mail.gmail.com>
 <CAGKCzNAQKMKJ_BQcF=uzcfcM=vx8QYnT+jtzuv_yp=76zbhn7g@mail.gmail.com>
 <CAGKCzNAW4BFq_cSKpnPvG6hRF65G3HptjUvWVW=DefPaPMF2pg@mail.gmail.com>
 <CAGKCzNAJzhzxJ809y9e6ttYbL0k6id5KmkzmBrz5xZROd79etQ@mail.gmail.com>
 <CAGKCzNC6RkY54TrkqqQ9K83AF=vrYe+CB14-PUSLTF5YMbzrmA@mail.gmail.com>
 <CAOMoQbT3zRuL+YLeiUrOG5-vYsvrZ2MJF_DQoa3E94cBfdv6xw@mail.gmail.com>
 <Z6Is1o56psB3-TMT@msg.df7cb.de>
 <CAOMoQbTA2qOo+f_4JE+oYGupZANh-0msn_Pw36qb7v3PfT1e0w@mail.gmail.com>
 <Z6Mq3xL_VpiNwOFm@msg.df7cb.de>
 <CAGKCzNCKAEEJmd5Fn5Be4zu1YxS9okBoeqBX15_RijvBgouqzA@mail.gmail.com>
In-Reply-To: 
 <CAGKCzNCKAEEJmd5Fn5Be4zu1YxS9okBoeqBX15_RijvBgouqzA@mail.gmail.com>
From: Brian Cosgrove <cosgroveb@gmail.com>
Date: Wed, 5 Feb 2025 11:01:39 -0600
Message-ID: 
 <CAGKCzND9R131b2MB1tHBqTbgCdV9TkReRYLqE3KLxTt6fbhrXA@mail.gmail.com>
Subject: Re: PgBouncer 1.24.0 - New upstream version
To: Christoph Berg <cb@df7cb.de>, Bradford Boyle <bradford.d.boyle@gmail.com>,
	pgsql-pkg-debian@postgresql.org
Content-Type: multipart/mixed; boundary="000000000000f0d53c062d6814e2"
Archived-At: 
 <https://www.postgresql.org/message-id/CAGKCzND9R131b2MB1tHBqTbgCdV9TkReRYLqE3KLxTt6fbhrXA%40mail.gmail.com>
Precedence: bulk

--000000000000f0d53c062d6814e2
Content-Type: multipart/alternative; boundary="000000000000f0d53b062d6814e0"

--000000000000f0d53b062d6814e0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Attached in DEP-3 format, I think, if it helps at all.

On Wed, Feb 5, 2025 at 6:40=E2=80=AFAM Brian Cosgrove <cosgroveb@gmail.com>=
 wrote:

> Skipping this release for bullseye is not entirely unreasonable with
> Trixie pending.
>
> Skipping the entire suite feels unreasonable if the Postgres Debian team
> releases 1.24.
>
> I am working up a patch that will skip only these tests that will likely
> be accepted upstream as well, should Debian choose to release 1.24 for
> bullseye.
>
> https://github.com/pgbouncer/pgbouncer/pull/1266
>
>
>
> On Wed, Feb 5, 2025 at 3:10=E2=80=AFAM Christoph Berg <cb@df7cb.de> wrote=
:
>
>> Re: Bradford Boyle
>> > I think we could go without tests on bullseye since it seems like we a=
re
>> > nearing the trixie release and bullseye will become old old stable.
>> > (Correct me if I am wrong on this point, I'm making this assumption
>> > based on the trixie freeze dates). There's probably little value in
>> > creating extra work here.
>>
>> Or we just don't update the package on bullseye, leaving it at 1.23.1.
>> But there is still the autopkgtest, so we still have test coverage
>> there.
>>
>> > It looks like d/rules for pgbouncer will skip the tests if nocheck is =
in
>> > DEB_BUILD_OPTIONS -- is this something that can be configured via the
>> Jenkins
>> > YAML? I am not very familiar with the Jenkins job builder YAML and I
>> didn't see
>> > any usages of that in the current set of jobs. Or would I need to upda=
te
>> > generate-pgdg-source to include an additional tweak to disable the
>> tests on
>> > older platforms?
>>
>> Any of these would work.
>>
>> DEB_BUILD_OPTIONS=3Dnocheck would have to be set in the sbuild-package
>> script. That's probably the easiest way forward.
>>
>> The extra test dependencies need annotating with <!nocheck> so the
>> build doesn't try to install them.
>>
>> Christoph
>>
>>
>>
>
> --
> Brian Cosgrove
>


--=20
Brian Cosgrove

--000000000000f0d53b062d6814e0
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Attached in DEP-3 format, I think, if it helps at all.</di=
v><br><div class=3D"gmail_quote gmail_quote_container"><div dir=3D"ltr" cla=
ss=3D"gmail_attr">On Wed, Feb 5, 2025 at 6:40=E2=80=AFAM Brian Cosgrove &lt=
;<a href=3D"mailto:cosgroveb@gmail.com">cosgroveb@gmail.com</a>&gt; wrote:<=
br></div><blockquote class=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8e=
x;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir=3D"ltr"=
>Skipping this release for bullseye is not entirely unreasonable with Trixi=
e pending.=C2=A0<div><br></div><div>Skipping the entire suite feels unreaso=
nable if the Postgres Debian team releases 1.24.=C2=A0</div><div><br></div>=
<div>I am working up a patch that will skip only these tests that will like=
ly be accepted upstream as well,=C2=A0should Debian choose to release 1.24 =
for bullseye.=C2=A0</div><div><br></div><div><a href=3D"https://github.com/=
pgbouncer/pgbouncer/pull/1266" target=3D"_blank">https://github.com/pgbounc=
er/pgbouncer/pull/1266</a><br><div><br></div><div><br></div></div></div><br=
><div class=3D"gmail_quote"><div dir=3D"ltr" class=3D"gmail_attr">On Wed, F=
eb 5, 2025 at 3:10=E2=80=AFAM Christoph Berg &lt;<a href=3D"mailto:cb@df7cb=
.de" target=3D"_blank">cb@df7cb.de</a>&gt; wrote:<br></div><blockquote clas=
s=3D"gmail_quote" style=3D"margin:0px 0px 0px 0.8ex;border-left:1px solid r=
gb(204,204,204);padding-left:1ex">Re: Bradford Boyle<br>
&gt; I think we could go without tests on bullseye since it seems like we a=
re<br>
&gt; nearing the trixie release and bullseye will become old old stable.<br=
>
&gt; (Correct me if I am wrong on this point, I&#39;m making this assumptio=
n<br>
&gt; based on the trixie freeze dates). There&#39;s probably little value i=
n<br>
&gt; creating extra work here.<br>
<br>
Or we just don&#39;t update the package on bullseye, leaving it at 1.23.1.<=
br>
But there is still the autopkgtest, so we still have test coverage<br>
there.<br>
<br>
&gt; It looks like d/rules for pgbouncer will skip the tests if nocheck is =
in<br>
&gt; DEB_BUILD_OPTIONS -- is this something that can be configured via the =
Jenkins<br>
&gt; YAML? I am not very familiar with the Jenkins job builder YAML and I d=
idn&#39;t see<br>
&gt; any usages of that in the current set of jobs. Or would I need to upda=
te<br>
&gt; generate-pgdg-source to include an additional tweak to disable the tes=
ts on<br>
&gt; older platforms?<br>
<br>
Any of these would work.<br>
<br>
DEB_BUILD_OPTIONS=3Dnocheck would have to be set in the sbuild-package<br>
script. That&#39;s probably the easiest way forward.<br>
<br>
The extra test dependencies need annotating with &lt;!nocheck&gt; so the<br=
>
build doesn&#39;t try to install them.<br>
<br>
Christoph<br>
<br>
<br>
</blockquote></div><div><br clear=3D"all"></div><div><br></div><span class=
=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_s=
ignature">Brian Cosgrove</div>
</blockquote></div><div><br clear=3D"all"></div><div><br></div><span class=
=3D"gmail_signature_prefix">-- </span><br><div dir=3D"ltr" class=3D"gmail_s=
ignature">Brian Cosgrove</div>

--000000000000f0d53b062d6814e0--

--000000000000f0d53c062d6814e2
Content-Type: application/octet-stream;
	name="fix-bullseye-pgbouncer-1.24.patch"
Content-Disposition: attachment;
	filename="fix-bullseye-pgbouncer-1.24.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_m6s5oelu0>
X-Attachment-Id: f_m6s5oelu0

ZGlmZiAtLWdpdCBhL2RlYmlhbi9wYXRjaGVzL2ZpeC1wc3ljb3BnLWNsb3NlLXRlc3RzLnBhdGNo
IGIvZGViaWFuL3BhdGNoZXMvZml4LXBzeWNvcGctY2xvc2UtdGVzdHMucGF0Y2gKbmV3IGZpbGUg
bW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMC4uOWI2OWQ4OQotLS0gL2Rldi9udWxsCisrKyBiL2Rl
Ymlhbi9wYXRjaGVzL2ZpeC1wc3ljb3BnLWNsb3NlLXRlc3RzLnBhdGNoCkBAIC0wLDAgKzEsMjkg
QEAKK0Rlc2NyaXB0aW9uOiBTa2lwIHRlc3RzIGZvciBDbG9zZSBtZXNzYWdlcyBvbiBwc3ljb3Bn
IDwgMy4yCitPcmlnaW46IHVwc3RyZWFtLCBodHRwczovL2dpdGh1Yi5jb20vcGdib3VuY2VyL3Bn
Ym91bmNlci9wdWxsLzEyNjYKK0xhc3QtVXBkYXRlOiAyMDI1LTAyLTA1CistLS0KK1RoaXMgcGF0
Y2ggaGVhZGVyIGZvbGxvd3MgREVQLTM6IGh0dHA6Ly9kZXAuZGViaWFuLm5ldC9kZXBzL2RlcDMv
CistLS0gYS90ZXN0L3Rlc3RfcHJlcGFyZWQucHkKKysrKyBiL3Rlc3QvdGVzdF9wcmVwYXJlZC5w
eQorQEAgLTMxMSw2ICszMTEsMTAgQEAgZGVmIHRlc3RfZGVzY3JpYmVfbm9uX2V4aXN0ZW50X3By
ZXBhcmVkX3N0YXRlbWVudChib3VuY2VyKToKKworICMgbGlicHEgYmVmb3JlIFBHMTcgZG9lcyBu
b3Qgc3VwcG9ydCBzZW5kaW5nIENsb3NlIG1lc3NhZ2VzCisgQHB5dGVzdC5tYXJrLnNraXBpZigi
cHN5Y29wZy5wcS52ZXJzaW9uKCkgPCAxNzAwMDAiKQorK0BweXRlc3QubWFyay5za2lwaWYoCisr
ICAgICJwc3ljb3BnLl9fdmVyc2lvbl9fIDwgJzMuMi4wJyIsCisrICAgIHJlYXNvbj0iRGViaWFu
IG9sZHN0YWJsZSBkb2Vzbid0IHN1cHBvcnQgYSB2ZXJzaW9uIG9mIHBzeWNvcGcgd2l0aCAnY2xv
c2VfcHJlcGFyZWQnIHN1cHBvcnQiLAorKykKKyBkZWYgdGVzdF9jbG9zZV9wcmVwYXJlZF9zdGF0
ZW1lbnQoYm91bmNlcik6CisgICAgIHdpdGggYm91bmNlci5jb25uKCkgYXMgY29ubjoKKyAgICAg
ICAgIHJlc3VsdCA9IGNvbm4ucGdjb25uLnByZXBhcmUoYiJ0ZXN0IiwgYiJTRUxFQ1QgMSIpCitA
QCAtMzM4LDggKzM0Miw5IEBAIGRlZiB0ZXN0X3N0YXRlbWVudF9uYW1lX2xvbmdlcl90aGFuX3Br
dF9idWYoYm91bmNlcik6CisgICAgICAgICBhc3NlcnQgcmVzdWx0LnN0YXR1cyA9PSBwcS5FeGVj
U3RhdHVzLlRVUExFU19PSworICAgICAgICAgYXNzZXJ0IHJlc3VsdC5nZXRfdmFsdWUoMCwgMCkg
PT0gYiJhYmMiCisKKy0gICAgICAgIGlmIHBzeWNvcGcucHEudmVyc2lvbigpID49IDE3MDAwMDoK
KysgICAgICAgIGlmIHBzeWNvcGcucHEudmVyc2lvbigpID49IDE3MDAwMCBhbmQgcHN5Y29wZy5f
X3ZlcnNpb25fXyA+PSAiMy4yLjAiOgorICAgICAgICAgICAgICMgbGlicHEgYmVmb3JlIFBHMTcg
ZG9lcyBub3Qgc3VwcG9ydCBzZW5kaW5nIENsb3NlIG1lc3NhZ2VzCisrICAgICAgICAgICAgIyBE
ZWJpYW4gb2xkc3RhYmxlIGRvZXMgbm90IHBhY2thZ2UgcHN5Y29wZyB3aXRoICdjbG9zZV9wcmVw
YXJlZCcKKyAgICAgICAgICAgICByZXN1bHQgPSBjb25uLnBnY29ubi5jbG9zZV9wcmVwYXJlZChu
YW1lKQorICAgICAgICAgICAgIGFzc2VydCByZXN1bHQuc3RhdHVzID09IHBxLkV4ZWNTdGF0dXMu
Q09NTUFORF9PSworICAgICAgICAgICAgICMgRW5zdXJlIHRoYXQgdGhlIGNsb3NlIHdhcyBzdWNj
ZXNzZnVsCmRpZmYgLS1naXQgYS9kZWJpYW4vcGF0Y2hlcy9zZXJpZXMgYi9kZWJpYW4vcGF0Y2hl
cy9zZXJpZXMKaW5kZXggMTlmNzkwZS4uNWQ3ODY1MSAxMDA2NDQKLS0tIGEvZGViaWFuL3BhdGNo
ZXMvc2VyaWVzCisrKyBiL2RlYmlhbi9wYXRjaGVzL3NlcmllcwpAQCAtMSwyICsxLDMgQEAKK2Zp
eC1wc3ljb3BnLWNsb3NlLXRlc3RzLnBhdGNoCiBkZWJpYW4tY29uZmlnCiB1cGRhdGUtdGVzdC1h
c3NlcnRpb25zLnBhdGNoCg==
--000000000000f0d53c062d6814e2--