MIME-Version: 1.0
From: Don Seiler <don@seiler.us>
Date: Tue, 26 Jul 2022 12:21:39 -0500
Message-ID: 
 <CAHJZqBDLW7F=rxCoTQKd1n4+P_OVBcVA1MCbYfGOS7FVAmHZtg@mail.gmail.com>
Subject: Fix for pgbackrest systemd service file
To: pgsql-pkg-debian@postgresql.org
Cc: David Steele <david@pgmasters.net>
Content-Type: multipart/alternative; boundary="00000000000033e46105e4b8891e"
Archived-At: 
 <https://www.postgresql.org/message-id/CAHJZqBDLW7F%3DrxCoTQKd1n4%2BP_OVBcVA1MCbYfGOS7FVAmHZtg%40mail.gmail.com>
Precedence: bulk

--00000000000033e46105e4b8891e
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Good afternoon,

I was talking with David Steele and pointed out errors I saw in the
pgbackrest service file when doing some early TLS file. It looks like the
errors stem from line 15 where the kill command doesn't have the absolute
path, and should be /bin/kill. I confirmed the errors go away when I
specify the full path to the kill binary.

I've given David this info and he is updating their documentation to
reflect the change also.

Before:

$ sudo systemctl status pgbackrest
=E2=97=8F pgbackrest.service - pgBackRest Server
   Loaded: loaded (/lib/systemd/system/pgbackrest.service; disabled; vendor
preset: enabled)
   Active: inactive (dead)

Jul 19 16:37:44 postgres-history0-az-eastus2 systemd[1]:
/lib/systemd/system/pgbackrest.service:15: Executable path is not absolute:
kill -HUP $MAINPID

After:

$ sudo systemctl status pgbackrest
=E2=97=8F pgbackrest.service - pgBackRest Server
   Loaded: loaded (/lib/systemd/system/pgbackrest.service; disabled; vendor
preset: enabled)
   Active: inactive (dead)


Diff on an Ubuntu 18.04 system:

$ sudo diff -u pgbackrest.service.old /lib/systemd/system/pgbackrest.servic=
e
--- pgbackrest.service.old      2022-07-26 17:19:37.321260963 +0000
+++ /lib/systemd/system/pgbackrest.service      2022-07-26
15:34:51.100155390 +0000
@@ -12,7 +12,7 @@
 ExecStart=3D/usr/bin/pgbackrest server
 ExecStartPost=3D/bin/sleep 3
 ExecStartPost=3D/bin/bash -c "[ ! -z $MAINPID ]"
-ExecReload=3Dkill -HUP $MAINPID
+ExecReload=3D/bin/kill -HUP $MAINPID

 [Install]
 WantedBy=3Dmulti-user.target
--=20
Don Seiler
www.seiler.us

--00000000000033e46105e4b8891e
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Good afternoon,<div><br></div><div>I was talking with Davi=
d Steele and pointed out errors I saw in the pgbackrest service file when d=
oing some early TLS file. It looks like the errors stem from line 15 where =
the=C2=A0<font face=3D"monospace">kill</font>=C2=A0command doesn&#39;t have=
 the absolute path, and should be=C2=A0<font face=3D"monospace">/bin/kill</=
font>. I confirmed the errors go away when I specify the full path to the=
=C2=A0<font face=3D"monospace">kill</font>=C2=A0binary.</div><div><br></div=
><div>I&#39;ve given David this info and he is updating their documentation=
 to reflect the change also.</div><div><br></div><div>Before:</div><div><br=
></div><div><font face=3D"monospace">$ sudo systemctl status pgbackrest<br>=
=E2=97=8F pgbackrest.service - pgBackRest Server<br>=C2=A0 =C2=A0Loaded: lo=
aded (/lib/systemd/system/pgbackrest.service; disabled; vendor preset: enab=
led)<br>=C2=A0 =C2=A0Active: inactive (dead)<br><br>Jul 19 16:37:44 postgre=
s-history0-az-eastus2 systemd[1]: /lib/systemd/system/pgbackrest.service:15=
: Executable path is not absolute: kill -HUP $MAINPID</font><br></div><div>=
<br></div><div>After:</div><div><br></div><div><font face=3D"monospace">$ s=
udo systemctl status pgbackrest<br>=E2=97=8F pgbackrest.service - pgBackRes=
t Server<br>=C2=A0 =C2=A0Loaded: loaded (/lib/systemd/system/pgbackrest.ser=
vice; disabled; vendor preset: enabled)<br>=C2=A0 =C2=A0Active: inactive (d=
ead)</font></div><div><br></div><div><br></div><div>Diff on an Ubuntu 18.04=
 system:</div><div><br></div><div><font face=3D"monospace">$ sudo diff -u p=
gbackrest.service.old /lib/systemd/system/pgbackrest.service<br>--- pgbackr=
est.service.old =C2=A0 =C2=A0 =C2=A02022-07-26 17:19:37.321260963 +0000<br>=
+++ /lib/systemd/system/pgbackrest.service =C2=A0 =C2=A0 =C2=A02022-07-26 1=
5:34:51.100155390 +0000<br>@@ -12,7 +12,7 @@<br>=C2=A0ExecStart=3D/usr/bin/=
pgbackrest server<br>=C2=A0ExecStartPost=3D/bin/sleep 3<br>=C2=A0ExecStartP=
ost=3D/bin/bash -c &quot;[ ! -z $MAINPID ]&quot;<br>-ExecReload=3Dkill -HUP=
 $MAINPID<br>+ExecReload=3D/bin/kill -HUP $MAINPID<br><br>=C2=A0[Install]<b=
r>=C2=A0WantedBy=3Dmulti-user.target</font><br></div>-- <br><div dir=3D"ltr=
" class=3D"gmail_signature" data-smartmail=3D"gmail_signature"><div dir=3D"=
ltr"><div>Don Seiler<br><a href=3D"http://www.seiler.us" target=3D"_blank">=
www.seiler.us</a></div></div></div></div>

--00000000000033e46105e4b8891e--