MIME-Version: 1.0
References: 
 <CAPqRbE716D3gpD0JDbaFAb72ELaJrPpG1LUZvobELNBgL3R0+g@mail.gmail.com>
 <CAOMoQbRMo5HM4eMsUmcQ+5_eGUZK6zycMgifnEehbooee+L5HA@mail.gmail.com>
In-Reply-To: 
 <CAOMoQbRMo5HM4eMsUmcQ+5_eGUZK6zycMgifnEehbooee+L5HA@mail.gmail.com>
From: Bradford Boyle <bradford.d.boyle@gmail.com>
Date: Sun, 4 Jun 2023 19:37:05 -0700
Message-ID: 
 <CAOMoQbQPOs827ZNk2atm0JHQYDJ4iW339a8HxovxUZzpa4RjtA@mail.gmail.com>
Subject: Re: Packaging request MobilityDB
To: Esteban Zimanyi <estebanzimanyi@gmail.com>
Cc: pgsql-pkg-debian@lists.postgresql.org
Content-Type: multipart/mixed; boundary="000000000000ecc30405fd58c7d8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAOMoQbQPOs827ZNk2atm0JHQYDJ4iW339a8HxovxUZzpa4RjtA%40mail.gmail.com>
Precedence: bulk

--000000000000ecc30405fd58c7d8
Content-Type: text/plain; charset="UTF-8"

I've spent some time looking at packaging MobilityDB for inclusion in
the Debian archive and PGDG. Here is a high-level summary of what I've
done so far:

* Opened an ITP bug against wnpp for MobilityDB [1]
* Created an initial source package with dh make_pgxs
  - Replaced default autopkgtest with customized one (see below for
    discussion)
* Created a new project on salsa under the PostgreSQL team [2]
  - I have not updated the CI/CD settings to point at d/gitlab-ci.yml
    (see below for discussion)
* Added a job for MobilityDB to the pgapt Jenkins jobs (patch attached)

Upstream isn't using pgxs for its build system and does not have an
installcheck target. The build system does have tests but these tests
are run with cmake and running that in autopkgtest would require
re-building the source package (or using the 'build-needed'
restriction). Additionally, the upstream tests include creating,
starting, and stoping a test cluster. I decided to replace the generated
'installcheck' script with a custom one that uses pg_virtualenv and
pg_regress to run upstream's test cases. I was able to (automatically)
reuse the test SQL queries from upstream but I was not able to reuse the
expected responses. This is because upstream's test uses UTC timezone
while pg_regress sets PGTZ to PST8PDT. Additionally, upstream's test
includes pre- and post-processing of the expected results to standardize
ERROR messages along with removing WARNING and CONTEXT lines. I have had
to skip one test case (052_tpoint.test) because it is currently failing
with the following error message in the Postgres log:

> *** stack smashing detected ***: terminated
> 2023-06-04 02:59:18.383 UTC [25831] LOG:  server process (PID 25852) was terminated by signal 6: Aborted
> 2023-06-04 02:59:18.383 UTC [25831] DETAIL:  Failed process was running: SELECT tgeompoint(Instant,PointZ,5676,1234) 'SRID=5676;Point(0 0 0)@2000-01-01';

I think this indicates a potential buffer overflow bug [3] but I haven't
had a chance to look into it.

I have skipped setting up the CI/CD settings for the packaging
repository on Salsa for now. The intent is to package the upcoming
release of MobilityDB 1.1 and since the release hasn't happened yet,
there is no upstream source archive to fetch with uscan. For my local
development and testing of the package, I've just used a "fake" source
archive that I created with git archive. Until the upstream release of
1.1, I'd expect the default GitLab pipeline to fail. This is why I have
added the package to pgapt's Jenkins jobs with the job group of
"git+upstream-snapshot".


[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1037101
[2]: https://salsa.debian.org/postgresql/mobilitydb
[3]: https://stackoverflow.com/a/1347464

--000000000000ecc30405fd58c7d8
Content-Type: application/octet-stream; name="0001-Add-MobilityDB.patch"
Content-Disposition: attachment; filename="0001-Add-MobilityDB.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lii8qp2w0>
X-Attachment-Id: f_lii8qp2w0

RnJvbSAwZWJhNWUxYzE0NGU4ZDRiZmY3NmRiMGEzNjBkODQ2NWU0MmM0YzUzIE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiAiQnJhZGZvcmQgRC4gQm95bGUiIDxicmFkZm9yZC5kLmJveWxl
QGdtYWlsLmNvbT4KRGF0ZTogU3VuLCA0IEp1biAyMDIzIDE5OjI3OjE3IC0wNzAwClN1YmplY3Q6
IFtQQVRDSF0gQWRkIE1vYmlsaXR5REIKCi0tLQogamVua2lucy9wYWNrYWdlcyAgICAgICAgICAg
fCAxICsKIGplbmtpbnMvcGFja2FnZXMuYmV0YXRlc3RzIHwgMSArCiBqZW5raW5zL3BnYXB0LWpv
YnMueWFtbCAgICB8IDkgKysrKysrKysrCiAzIGZpbGVzIGNoYW5nZWQsIDExIGluc2VydGlvbnMo
KykKCmRpZmYgLS1naXQgYS9qZW5raW5zL3BhY2thZ2VzIGIvamVua2lucy9wYWNrYWdlcwppbmRl
eCA3MTcwMTEzLi40YWZkZWQ0IDEwMDY0NAotLS0gYS9qZW5raW5zL3BhY2thZ2VzCisrKyBiL2pl
bmtpbnMvcGFja2FnZXMKQEAgLTIzLDYgKzIzLDcgQEAgbGlic3RyaW5ncHJlcC1qYXZhCiBsaWJ0
YXAtcGFyc2VyLXNvdXJjZWhhbmRsZXItcGd0YXAtcGVybAogbG9uZGlzdGUKIG1pbWVvCittb2Jp
bGl0eWRiCiBvbW5pZGIKIG9tbmlkYi1wbHBnc3FsLWRlYnVnZ2VyCiBvcmEycGcKZGlmZiAtLWdp
dCBhL2plbmtpbnMvcGFja2FnZXMuYmV0YXRlc3RzIGIvamVua2lucy9wYWNrYWdlcy5iZXRhdGVz
dHMKaW5kZXggZDgxNDY1OS4uZjIwZjFhNiAxMDA2NDQKLS0tIGEvamVua2lucy9wYWNrYWdlcy5i
ZXRhdGVzdHMKKysrIGIvamVua2lucy9wYWNrYWdlcy5iZXRhdGVzdHMKQEAgLTIzLDYgKzIzLDcg
QEAgbGlic3RyaW5ncHJlcC1qYXZhCiBsaWJ0YXAtcGFyc2VyLXNvdXJjZWhhbmRsZXItcGd0YXAt
cGVybAogbG9uZGlzdGUKIG1pbWVvCittb2JpbGl0eWRiCiBvbW5pZGIKIG9tbmlkYi1wbHBnc3Fs
LWRlYnVnZ2VyCiBvcmEycGcKZGlmZiAtLWdpdCBhL2plbmtpbnMvcGdhcHQtam9icy55YW1sIGIv
amVua2lucy9wZ2FwdC1qb2JzLnlhbWwKaW5kZXggYmFiMGJmOS4uZmIxN2VkZiAxMDA2NDQKLS0t
IGEvamVua2lucy9wZ2FwdC1qb2JzLnlhbWwKKysrIGIvamVua2lucy9wZ2FwdC1qb2JzLnlhbWwK
QEAgLTExNDksNiArMTE0OSwxNSBAQAogICAgICAgICBqb2JzOgogICAgICAgICAgICAgICAgIC0g
Z2l0LXBhY2thZ2VzLXdpdGgtYmV0YQogCistIHByb2plY3Q6CisgICAgICAgIG5hbWU6IG1vYmls
aXR5ZGIKKyAgICAgICAgZ2l0LXVybDogaHR0cHM6Ly9zYWxzYS5kZWJpYW4ub3JnL3Bvc3RncmVz
cWwvbW9iaWxpdHlkYi5naXQKKyAgICAgICAgZ2l0LWJyYW5jaDogbWFpbgorICAgICAgICB1cHN0
cmVhbS11cmw6IGh0dHBzOi8vZ2l0aHViLmNvbS9Nb2JpbGl0eURCL01vYmlsaXR5REIuZ2l0Cisg
ICAgICAgIHVwc3RyZWFtLWJyYW5jaDogZGV2ZWxvcAorICAgICAgICBqb2JzOgorICAgICAgICAg
ICAgICAgIC0gZ2l0K3Vwc3RyZWFtLXNuYXBzaG90CisKIC0gcHJvamVjdDoKICAgICAgICAgbmFt
ZTogb21uaWRiCiAgICAgICAgIGdpdC11cmw6IGh0dHBzOi8vc2Fsc2EuZGViaWFuLm9yZy9wb3N0
Z3Jlc3FsL29tbmlkYi5naXQKLS0gCjIuNDEuMAoK
--000000000000ecc30405fd58c7d8--