Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tXBq2-004dWi-Vz for pgsql-pkg-debian@arkaria.postgresql.org; Mon, 13 Jan 2025 04:14:07 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tXBq0-006ccY-Qc for pgsql-pkg-debian@arkaria.postgresql.org; Mon, 13 Jan 2025 04:14:05 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tXBq0-006ccQ-K0 for pgsql-pkg-debian@lists.postgresql.org; Mon, 13 Jan 2025 04:14:05 +0000 Received: from mail-oa1-x29.google.com ([2001:4860:4864:20::29]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tXBpz-0006tu-2f for pgsql-pkg-debian@postgresql.org; Mon, 13 Jan 2025 04:14:04 +0000 Received: by mail-oa1-x29.google.com with SMTP id 586e51a60fabf-29fcbf3d709so1265353fac.2 for ; Sun, 12 Jan 2025 20:14:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1736741643; x=1737346443; darn=postgresql.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=LNPo4KC9MUTsCtWquycsfCj8t6DaxoNi7Aw28ZETRWY=; b=WZZuZIdddK9ptIX3TXGl/rsqnprV3+/fq9PfFBnWOftjk46StNTWbo2xduzihko7bT 95Wx9pzSEgZ0by/TjSsh78Hiuly7QdYOXYDlc8j4vXDztvuNGna2aB5diEuax2HOnZoP t5txwBHAehmPu1cThJXxhAyujDz5ZGbj6Y016Ufl6orRj2YP5WsYevHAhCUXQqsqW8Bv KWHAEKW2T01kauvD9itMH7J+hPCiu9y5aGsXUbcuOrLRpvRBWUAS3cvLUL/p31AxSEOt ozZdMfgKmM70LVPAscD9FzrXK6OY7IsVPWX31QpoZDCs6lHzheo6UEEPB1C8CVcVl0p/ vQOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736741643; x=1737346443; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LNPo4KC9MUTsCtWquycsfCj8t6DaxoNi7Aw28ZETRWY=; b=h1zkpHDHl3eO5KDVQgzOUXPn//J+VTRm+AW6RNbpBFKt1xOYjM/rPYXgCJyhQ94NXH GmdkeorwjQffW5Jhy3XYz+5Do38501XHM14sigOIo8M5sbltnhzqv9+ufiqFP3iW719x XpOrvqpYttBfxdQVofWA5C81BzZPGfKAk0mGFmkRqVici/wILT4Ei50D23FsyBVuB4s1 arU5cvTrJx1MEp9r746it3Wrz+MP3LWsZNAwfnkYFTeiPRez+eoUNUze3Bz05+5/qiKz HeRxI6dIAmMEC5dxrno2J56s/mNLv5hbY1EuNFqVoQ3a86Tzck3wWSzsgSJADWIXR9SE gsOw== X-Gm-Message-State: AOJu0YzG4veD2pwDs7pdkigXKlW2Q6vaDs59T/iokas5zst2taR+QRsf SLleQWXEmTx+iWRed0aCFqO5bOL+2OWt8YkE929HePEa46TaZwaEbYLVkk3BMdq/lzWYua8gKGd q8DizlWnwSrhEl6Y1IrYiqM8a0OM= X-Gm-Gg: ASbGncvSy3oISlXOmhIlFEOueppsuqmVp0AV3ObbAqhP+m7Irdz+FfiC08ln9VLnh3q IVW2Xi2i81fB4gxqq0rewIzhuAs1+93hfeDly3w== X-Google-Smtp-Source: AGHT+IGZpFxdA0WdcoNwcojygf9cBTQHznTEzD7/Kt2oGs/usDYjOrjakUKa7WyniEdYcrK6/d1CnNQwPFYSpnP5NPg= X-Received: by 2002:a05:6870:6e82:b0:29e:3c14:2bb0 with SMTP id 586e51a60fabf-2aa06922e46mr11539125fac.30.1736741642600; Sun, 12 Jan 2025 20:14:02 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Bradford Boyle Date: Sun, 12 Jan 2025 20:13:51 -0800 X-Gm-Features: AbW1kvbG0QOriM2qHJDTgs-eyL5VoHwoF46MUI1lrq-JxaEVI1fqPJY2hHD7PoI Message-ID: Subject: Re: PgBouncer 1.24.0 - New upstream version To: Brian Cosgrove Cc: pgsql-pkg-debian@postgresql.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Brian, On Sun, Jan 12, 2025 at 4:47=E2=80=AFAM Brian Cosgrove wrote: > > Unrelated to autopkgtest, I noticed in October that during debbuild > the package does not run the main pytest suite for pgbouncer? Is that > intentional? It appears that before the tests were rewritten in python > that the package ran the shell-based suite properly. Looking at the history for d/rules, I think disabling the main test suite during the build was intended to be a temporary fix for a missing file in the upstream source archive [0],[1]. It looks like the tests weren't re-enabled when the issue was fixed upstream. > I submitted a patch that should be able to be incorporated as-is: > https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=3D1085109 I've applied your patch to the package and pushed the changes to Salsa. I did have to drop the b-d on python3-contextlib2 since this package is not available (and not needed) in unstable. I also had to add tzdata-legacy in order for the tests to pass. We'll probably need to add some tweaks for the pgdg packages to build on older distributions. [0]: https://salsa.debian.org/postgresql/pgbouncer/-/commit/74f05a0#8756c63= 497c8dc39f7773438edf53b220c773f67_22_25 [1]: https://github.com/pgbouncer/pgbouncer/issues/431