public inbox for [email protected]  

help / color / mirror / Atom feed

Fix 1064956 for libh3
4+ messages / 2 participants
[nested] [flat]

* Fix 1064956 for libh3
@ 2024-05-01 03:35  Bradford Boyle <[email protected]>
  0 siblings, 1 reply; 4+ messages in thread

From: Bradford Boyle @ 2024-05-01 03:35 UTC (permalink / raw)
  To: [email protected]

Hello All,
Hello All,

I've pushed a change to libh3 to address bug #1064956 [1]. The Salsa CI
pipeline is green and I don't anticipate any distribution- or
architecture-specific issues with the fix since it's a minor tweak to
the build.

Let me know if anything needs to be changed.

Thanks,
--Bradford

[1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1064956





^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: Fix 1064956 for libh3
@ 2024-05-01 07:56  Christoph Berg <[email protected]>
  parent: Bradford Boyle <[email protected]>
  0 siblings, 1 reply; 4+ messages in thread

From: Christoph Berg @ 2024-05-01 07:56 UTC (permalink / raw)
  To: Bradford Boyle <[email protected]>; +Cc: [email protected]

Re: Bradford Boyle
> I've pushed a change to libh3 to address bug #1064956 [1]. The Salsa CI
> pipeline is green and I don't anticipate any distribution- or
> architecture-specific issues with the fix since it's a minor tweak to
> the build.

Hi Bradford,

thanks! The inner workings of cmake are still a complete mystery to
me, so that would likely have taken me a very long time to figure out.

Is that something that we should submit upstream?

Cheers,
Christoph





^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: Fix 1064956 for libh3
@ 2024-05-02 05:31  Bradford Boyle <[email protected]>
  parent: Christoph Berg <[email protected]>
  0 siblings, 1 reply; 4+ messages in thread

From: Bradford Boyle @ 2024-05-02 05:31 UTC (permalink / raw)
  To: Christoph Berg <[email protected]>; +Cc: [email protected]

Hi Christoph,

> Is that something that we should submit upstream?

I jumped right in to fixing this and didn't look at recent commits
upstream. It looks like upstream already merged a similar fix for this
[1]. However there hasn't been a release with this change included.

--Bradford

[1]: https://github.com/uber/h3/pull/819





^ permalink  raw  reply  [nested|flat] 4+ messages in thread

* Re: Fix 1064956 for libh3
@ 2024-05-02 07:36  Christoph Berg <[email protected]>
  parent: Bradford Boyle <[email protected]>
  0 siblings, 0 replies; 4+ messages in thread

From: Christoph Berg @ 2024-05-02 07:36 UTC (permalink / raw)
  To: Bradford Boyle <[email protected]>; +Cc: [email protected]

Re: Bradford Boyle
> > Is that something that we should submit upstream?
> 
> I jumped right in to fixing this and didn't look at recent commits
> upstream. It looks like upstream already merged a similar fix for this
> [1]. However there hasn't been a release with this change included.

Ack, thanks for checking!

Christoph






^ permalink  raw  reply  [nested|flat] 4+ messages in thread

end of thread, other threads:[~2024-05-02 07:36 UTC | newest]

Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2024-05-01 03:35 Fix 1064956 for libh3 Bradford Boyle <[email protected]>
2024-05-01 07:56 ` Christoph Berg <[email protected]>
2024-05-02 05:31   ` Bradford Boyle <[email protected]>
2024-05-02 07:36     ` Christoph Berg <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox