MIME-Version: 1.0
References: <OHgV4rO--F-9@tutamail.com> <Z5jc1WnEUfIwU-M9@msg.df7cb.de>
 <OHhPj4x--J-9@tutamail.com> <Z5j5MLQpRuQpsqSd@msg.df7cb.de>
 <CAOMoQbRufJVJT7dPSU9djrLyTpEmxeVeCJB=pZAy5KT-9SHtdQ@mail.gmail.com>
 <OI9j0Ge--F-9@tutamail.com>
In-Reply-To: <OI9j0Ge--F-9@tutamail.com>
From: Bradford Boyle <bradford.d.boyle@gmail.com>
Date: Mon, 3 Feb 2025 21:29:41 -0800
Message-ID: 
 <CAOMoQbSPKsuuXK260RTZ7x6a2Vb0VtiWdXpMJa98McMabze35Q@mail.gmail.com>
Subject: Re: Redis & SQLite FDW packages
To: pgsqlitegis@tutamail.com, pgsql-pkg-debian@lists.postgresql.org
Content-Type: text/plain; charset="UTF-8"
Archived-At: 
 <https://www.postgresql.org/message-id/CAOMoQbSPKsuuXK260RTZ7x6a2Vb0VtiWdXpMJa98McMabze35Q%40mail.gmail.com>
Precedence: bulk

Hi Michel,

I've reviewed your branch and here is my feedback:

* d/changelog is for the Debian version of the package

Since the first packaged version of the extension is 2.5.0, the
changelog should start with that version. Older versions are not
included since they haven't been uploaded to the Debian archive.

* Potentially incorrect version format

This depends on whether the package is intended to be a native or
non-native package; see [0] for a summary of the differences between
the two. The majority of PostgreSQL Debian packages that I have
reviewed/worked on have been non-native. For a non-native package,
the Debian package version is a combination of the upstream version
(e.g., 2.5.0) and a Debian component (e.g., 2.5.0-1).

* Invalid Source and Package name

Per Debian policy [1]:

> Package names (both source and binary, see Package) must consist
> only of lower case letters (a-z), digits (0-9), plus (+) and minus
> (-) signs, and periods (.). They must be at least two characters
> long and must start with an alphanumeric character.

So the correct name for the source package would be sqlite-fdw and
for the binary package postgresql-PGVERSION-sqlite-fdw

* Missing some common Build-Depends that dh_make_pgxs includes when
creating a new source package

* Incorrect matching pattern in d/watch

The matching pattern needs to match hrefs in the web page at found
at the URL. In this case, it needs to match the tag format of
v(x.y.z).tar.gz

* Additional packages are required for running the installcheck test

I needed to include locales-all, sqlite3, and tzdata-legacy in the
tests dependencies for the test to run

* Needed to pass REGRESS_PREFIX to make when running installcheck

The latest version of PostgreSQL in Debian unstable is 17.2. When
running the installcheck target, this version was expanded into a
directory path to specify which SQL queries to run during testing
but the there is no 17.2 directory under expected. This will
probably require a change to upstream sqlite_fdw in order for the
test to successfully run on the full matrix of supported PG
versions.

I have pushed my work-in-progress (which incorporates your work) to a
personal repo on salsa.debian.org [3].

To try building the binary package localy, you can install the
devscripts package and then try running debuild -i -us -uc -b. I have my
development environment setup to build packages with sbuild [2] so I
haven't tested this. I wouldn't recommend setting up sbuild unless you
intend to really get involved with broader Debian packaging work.

Regards,
-- Bradford

[0]: https://www.debian.org/doc/debian-policy/ch-source.html
[1]: https://www.debian.org/doc/debian-policy/ch-controlfields.html#source
[2]: https://salsa.debian.org/bradfordboyle/sqlite-fdw
[3]: https://wiki.debian.org/sbuild