public inbox for [email protected]help / color / mirror / Atom feed
Fix FTBFS for prometheus-sql-exporter 3+ messages / 2 participants [nested] [flat]
* Fix FTBFS for prometheus-sql-exporter @ 2024-04-04 06:52 Bradford Boyle <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Bradford Boyle @ 2024-04-04 06:52 UTC (permalink / raw) To: [email protected] Hello All, I've pushed some changes to prometheus-sql-exporter to address bug #1067292 [1]. The Salsa CI pipelines are green. I'd like to request a review and upload as cycles permit. Let me know if anything needs changes. Thanks, --Bradford [1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1067292 ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Fix FTBFS for prometheus-sql-exporter @ 2024-04-04 08:52 Christoph Berg <[email protected]> parent: Bradford Boyle <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Christoph Berg @ 2024-04-04 08:52 UTC (permalink / raw) To: Bradford Boyle <[email protected]>; +Cc: [email protected] Re: Bradford Boyle > I've pushed some changes to prometheus-sql-exporter to address bug > #1067292 [1]. The Salsa CI pipelines are green. I'd like to request a > review and upload as cycles permit. Hi Bradford, thanks for the update, uploaded! I had to revert the patch on the older distributions since go was unhappy: https://pgdgbuild.dus.dg-i.net/job/prometheus-sql-exporter-binaries/31/ I'm a bit worried that Ubuntu noble also needed the revert; we might need to un-revert it there if they change the toolchain before the release. https://git.postgresql.org/gitweb/?p=pgapt.git;a=blobdiff;f=jenkins/generate-pgdg-source;h=1164b5340... Christoph ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Fix FTBFS for prometheus-sql-exporter @ 2024-04-05 03:07 Bradford Boyle <[email protected]> parent: Christoph Berg <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Bradford Boyle @ 2024-04-05 03:07 UTC (permalink / raw) To: Christoph Berg <[email protected]>; +Cc: [email protected] Hi Christoph, > I had to revert the patch on the older distributions since go was > unhappy: I forgot to mention it in my original email, but I thought the patch might be an issue on older distributions. In the future, is there a way I can trigger a snapshot build on pgdgbuild before notifying the mailing list? > I'm a bit worried that Ubuntu noble also needed the revert; we might > need to un-revert it there if they change the toolchain before the > release. It looks like the replacement API is only available in github.com/prometheus/[email protected] and Ubuntu noble (as of 20240404) still is on 1.18.0. Unless 1.19.0 gets uploaded to noble, the patch shouldn't need to be un-reverted. I will keep an eye on this. --Bradford ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2024-04-05 03:07 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2024-04-04 06:52 Fix FTBFS for prometheus-sql-exporter Bradford Boyle <[email protected]> 2024-04-04 08:52 ` Christoph Berg <[email protected]> 2024-04-05 03:07 ` Bradford Boyle <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox