MIME-Version: 1.0
References: 
 <CAOMoQbTzXVT+LhShQW4uQpwmp5kGrhWCPincsrSvd3S1Qn16UA@mail.gmail.com>
 <CAOMoQbQkL6yDJB2-vZur0S1uiuuzh6KqtdoxhtVEHfqLaeJcGQ@mail.gmail.com>
 <Zl4pwMOUE1Vd8bV4@msg.df7cb.de>
 <CAOMoQbT0rewgfaLNah69MLCkieKBBVD3V_DH5QpzGd5gq9RpyA@mail.gmail.com>
 <213838ba-a1bb-4187-841a-1eed809e73e4@pgmasters.net>
In-Reply-To: <213838ba-a1bb-4187-841a-1eed809e73e4@pgmasters.net>
From: Bradford Boyle <bradford.d.boyle@gmail.com>
Date: Mon, 3 Jun 2024 20:36:17 -0700
Message-ID: 
 <CAOMoQbT04hcG90CYqYp3X7V+DzZ0iec28KV6AffUvFDkWmai5g@mail.gmail.com>
Subject: Re: pgBackRest 2.52 - New upstream version
To: David Steele <david@pgmasters.net>
Cc: Christoph Berg <myon@debian.org>, pgsql-pkg-debian@lists.postgresql.org
Content-Type: multipart/mixed; boundary="000000000000b941a4061a0827f1"
Archived-At: 
 <https://www.postgresql.org/message-id/CAOMoQbT04hcG90CYqYp3X7V%2BDzZ0iec28KV6AffUvFDkWmai5g%40mail.gmail.com>
Precedence: bulk

--000000000000b941a4061a0827f1
Content-Type: text/plain; charset="UTF-8"

Hi David and Christoph,

> This is actually a bug/typo in older versions of meson. What is actually
> required (in some cases) is python3-distutils.

I found [this issue][1] on GitHub repo for meson which indicates that
meson 0.48.0 added a dependency on python's setuptools module. This
issue is quite old but it was referenced by a [newer pull request][2]
that seems to indicate that at some point meson depended on python's
distutils module. This PR was referenced by an even [newer PR][3] that
seems to indicate that meson moved away from using the distutils module.
This is probably why this is only an issue in bullseye or focal and not
older or newer dists.

> It's a bit of a mess, but looks like we need to install
> python3-distutils just for bullseye and focal as a build dependency. Is
> that possible?

Adding python3-distutils for just bullseye and focal should be doable. I
believe the scripts used to build the packages for the PGDG apt repo has
an existing pattern for tweaking the package. Attached is a patch that
should add python3-distutils to pgbackrest's list of build dependencies
only on bullseye or focal.

--Bradford


[1]: https://github.com/mesonbuild/meson/issues/4267
[2]: https://github.com/mesonbuild/meson/pull/9288
[3]: https://github.com/mesonbuild/meson/pull/11133

--000000000000b941a4061a0827f1
Content-Type: application/octet-stream;
	name="0001-pgbackrest-Add-python3-distutils-dependency.patch"
Content-Disposition: attachment;
	filename="0001-pgbackrest-Add-python3-distutils-dependency.patch"
Content-Transfer-Encoding: base64
Content-ID: <f_lwzuktz50>
X-Attachment-Id: f_lwzuktz50

RnJvbSA3NmY5YjM3YzllZWMyY2QwZTc3OGU1NjYzNjNkZWE1ZjZjMmU4Nzg0IE1vbiBTZXAgMTcg
MDA6MDA6MDAgMjAwMQpGcm9tOiAiQnJhZGZvcmQgRC4gQm95bGUiIDxicmFkZm9yZC5kLmJveWxl
QGdtYWlsLmNvbT4KRGF0ZTogTW9uLCAzIEp1biAyMDI0IDIwOjMxOjEyIC0wNzAwClN1YmplY3Q6
IFtQQVRDSF0gcGdiYWNrcmVzdDogQWRkIHB5dGhvbjMtZGlzdHV0aWxzIGRlcGVuZGVuY3kKCi0t
LQogamVua2lucy9nZW5lcmF0ZS1wZ2RnLXNvdXJjZSB8IDkgKysrKysrKysrCiAxIGZpbGUgY2hh
bmdlZCwgOSBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvamVua2lucy9nZW5lcmF0ZS1wZ2Rn
LXNvdXJjZSBiL2plbmtpbnMvZ2VuZXJhdGUtcGdkZy1zb3VyY2UKaW5kZXggMTUxYjFjZC4uNmI1
NzkxYSAxMDA3NTUKLS0tIGEvamVua2lucy9nZW5lcmF0ZS1wZ2RnLXNvdXJjZQorKysgYi9qZW5r
aW5zL2dlbmVyYXRlLXBnZGctc291cmNlCkBAIC0yOTAsNiArMjkwLDE1IEBAIGNhc2UgJFBBQ0tB
R0UgaW4KICAgICBlc2FjCiAgICAgOzsKIAorICBwZ2JhY2tyZXN0KQorICAgIGNhc2UgJGRpc3Ry
aWJ1dGlvbiBpbgorICAgICAgYnVsbHNleWV8Zm9jYWwpCisgICAgICAgIHNlZCAtaSAtRSAncy8o
ICspKHBrZ2NvbmYsKS9cMVwyXG5cMXB5dGhvbjMtZGlzdHV0aWxzLC8nIGRlYmlhbi9jb250cm9s
CisgICAgICAgIFRXRUFLKz0oIkFkZCBweXRob24zLWRpc3R1dGlscyBkZXBlbmRlbmN5IikKKyAg
ICAgICAgOzsKKyAgICBlc2FjCisgICAgOzsKKwogICBwb3N0Z2lzKQogICAgIGNhc2UgJHtkaXN0
cmlidXRpb246LX0gaW4KICAgICAgIGJ1c3RlcnxzdHJldGNofGZvY2FsfGVvYW58YmlvbmljfHhl
bmlhbCkKLS0gCjIuNDUuMgoK
--000000000000b941a4061a0827f1--