Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6vzb-0000jo-9x for pgsql-pkg-debian@arkaria.postgresql.org; Wed, 07 Jun 2023 16:26:39 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1q6vza-0000kA-8I for pgsql-pkg-debian@arkaria.postgresql.org; Wed, 07 Jun 2023 16:26:38 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q6vza-0000k1-0g for pgsql-pkg-debian@lists.postgresql.org; Wed, 07 Jun 2023 16:26:38 +0000 Received: from mail-lj1-x22a.google.com ([2a00:1450:4864:20::22a]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1q6vzW-000oqD-St for pgsql-pkg-debian@lists.postgresql.org; Wed, 07 Jun 2023 16:26:37 +0000 Received: by mail-lj1-x22a.google.com with SMTP id 38308e7fff4ca-2b1fe3a1a73so11612301fa.1 for ; Wed, 07 Jun 2023 09:26:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686155194; x=1688747194; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5N9ws738a1AolEs6ptjzlOktkMEVQdWGbvvbXwOLVXo=; b=TSz/0+xyyMFwlmhkUiXYac9nQSXHD5HLToCW7gSdRrl8UcmrcTGY5f93YiYY0j5yVp 0XYh0u58yvT07BkqoOaOMblEDr1fAWv8wyw+tvzmkPcXyhO4IKO28YGWudNc9+cPEV+V RpAzOfAOcak8lpl0HGIgxEZiHwCjh9fDEybBQHX4N4b/kcM22dtpha7axJ95tQzL862Q Vt7UItvJykt+s8zsZixuC6gVRO36w7lHrXOqX/fwHdu2fj1z3unV/CuPTDv8s1lXkdAN JRysmOC8fEOPbF7ysfUN3NDZocjTa+qd0ZzXlvCTQgUVfgQ8QItZPRhBeOuXCE5+P/o9 d4kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686155194; x=1688747194; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5N9ws738a1AolEs6ptjzlOktkMEVQdWGbvvbXwOLVXo=; b=Y0xKnldc0bnSITX4LmlUMEQwjQxG6uU5ujm5I/AiNBxfa0n/5rS8ujvvW69Y9ipQvv BMywrGPX6/cAwwssUXMmv0DDkxKxKxl+uw+ORWg4K7pUec7A939v//UTOnh2c9O7jwUf MDnUm27+hrkaKa7Y2C4k6rZl1bH//mxLay5Vq/PW/MwW6O/qSdfcEdzCj21DAnrivwQF rZvXAlevayrdYtkK6puxV95SBTavDfvgL2IvLToqdKqYfUn2mb2Sx2pN70I85KnKpguN WzV3l9jr40JUHyJvxmtmiMzEhAluEUKP3HYZxLDIl7+AKl7PqmH9NqzWNJ95V0eGoKip aqJQ== X-Gm-Message-State: AC+VfDy/U64VnZV1/OHfvQb5BOfMZxnV2hNeiBQUSDtQmMX7hvP+NvQr kbhc4vOmbUSyG18sUWq3RSeRhZEWPAviou1SOEE= X-Google-Smtp-Source: ACHHUZ7JWJ9xehx2/Hp3LTZKHxeVhclMaAHcuKOYU9kFg37Y+uWSHo154aKkoLouhXkFMOEPkxIPKmwcJmeLQ/u8APA= X-Received: by 2002:a2e:9f42:0:b0:2ad:93c4:417a with SMTP id v2-20020a2e9f42000000b002ad93c4417amr2386218ljk.28.1686155193533; Wed, 07 Jun 2023 09:26:33 -0700 (PDT) MIME-Version: 1.0 References: <75679669-4482-3f16-bd4d-6ec1f9950941@abcsql.com> In-Reply-To: <75679669-4482-3f16-bd4d-6ec1f9950941@abcsql.com> From: Esteban Zimanyi Date: Wed, 7 Jun 2023 18:25:57 +0200 Message-ID: Subject: Re: Packaging request MobilityDB To: =?UTF-8?Q?C=C3=A9dric_Villemain?= Cc: Bradford Boyle , pgsql-pkg-debian@lists.postgresql.org, SCHOEMANS Maxime Content-Type: multipart/alternative; boundary="00000000000058c92805fd8c99cf" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --00000000000058c92805fd8c99cf Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable We regenerated all the tests using timezone =3D 'PST8PDT' and datestyle =3D 'Postgres, MDY' https://github.com/estebanzimanyi/MobilityDB/blob/pst/mobilitydb/test/scrip= ts/test.cmake#L100 https://github.com/estebanzimanyi/MobilityDB/commit/d67b817b079ea7340774c88= a0a6aaf577a2f3292 and all the test passed for ubuntu but not for macOS https://github.com/estebanzimanyi/MobilityDB/actions/runs/5202100740/jobs/9= 383217151 https://github.com/estebanzimanyi/MobilityDB/actions/runs/5202100734/jobs/9= 383216304 Any idea how to solve this ? Thanks for your help Esteban On Wed, Jun 7, 2023 at 5:51=E2=80=AFPM C=C3=A9dric Villemain wrote: > Le 07/06/2023 =C3=A0 17:16, Esteban Zimanyi a =C3=A9crit : > > Dear Bradford > > Many thanks for your work. > > > Seconded! and tks for MobilityDB too ! > > > * We solved the stack smashing problem you found. > * We set the log_error_verbosity to terse for the tests and removed the > special treatment of ERROR, CONTEXT, and WARNING that may vary across > PostgreSQL and PostGIS versions. > * For the tests, we can easily switch to the settings 'PST8PDT' for the > timezone and 'Postgres, MDY' for the date style if this is the general wa= y > to do things. We simply need to regenerate all tests and push them in a n= ew > commit. We just wonder if the same settings are equally valid for all oth= er > distributions. Please advise. > > Yeah, 'PST8PDT' is the way to go for PostgreSQL test [1] > > I believe it's valid for other distributions. > > Apparently datestyle is not documented here, but pg_regress does: > > /* > * Set timezone and datestyle for datetime-related tests > */ > setenv("PGTZ", "PST8PDT", 1); > setenv("PGDATESTYLE", "Postgres, MDY", 1); > > see also [2] which might be useful as it mentions some corner cases for > other systems. > > > > [1]: > https://www.postgresql.org/docs/current/regress-evaluation.html#id-1.6.20= .6.8 > > [2]: https://doxygen.postgresql.org/pg__regress_8c_source.html#l00702 > > --- > C=C3=A9dric Villemain +33 (0)6 20 30 22 52https://Data-Bene.io > PostgreSQL: Expertise - Formation - D=C3=A9veloppement - Assistance Techn= ique > > --00000000000058c92805fd8c99cf Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

We regenerated all the tests using timezone= =3D 'PST8PDT' and datestyle =3D 'Postgres, MDY'
and all the test passe= d for ubuntu but not for macOS

Any idea how to solve this ?

Thanks for your= help

Esteban


<= /div>
O= n Wed, Jun 7, 2023 at 5:51=E2=80=AFPM C=C3=A9dric Villemain <cedric.villemain@abcs= ql.com> wrote:
=20 =20 =20
Le 07/06/2023 =C3=A0 17:16, Esteban Zimanyi a =C3=A9crit=C2=A0:
Dear Bradford

Many thanks for your work.


Seconded! and tks for MobilityDB too !


* We solved the stack smashing problem you found.
* We set the log_error_verbosity to terse for the tests and removed the special treatment of ERROR, CONTEXT, and WARNING that may vary across PostgreSQL and PostGIS versions.
* For the tests, we can easily switch to the settings 'PST8PDT' for the timezone and 'Postgres, MDY' = for the date style if this is the general way to do things. We simply need to regenerate all tests and push them in a new commit. We just wonder if the same settings are equally valid for all other distributions. Please advise.

Yeah, 'PST8PDT' is the way to go for PostgreSQL test [1]

I believe it's valid for other distributions.

Apparently datestyle is not documented here, but pg_regress does:

=C2=A0=C2=A0=C2=A0=C2=A0 /*
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * Set timezone and datestyle for datet= ime-related tests
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */
=C2=A0=C2=A0=C2=A0=C2=A0 setenv("PGTZ", "PST8PDT"= , 1);
=C2=A0=C2=A0=C2=A0=C2=A0 setenv("PGDATESTYLE", "Postgr= es, MDY", 1);

see also [2] which might be useful as it mentions some corner cases for other systems.



[1]: https://www.postgresql.org/docs/current/re= gress-evaluation.html#id-1.6.20.6.8

[2]: https://doxygen.postgresql.org/pg__regress_8c_sou= rce.html#l00702

---
C=C3=A9dric Villemain +33 (0)6 20 30 22 52
https://Data-Bene.io
PostgreSQL: Expertise - Formation - D=C3=A9veloppement - Assistance Techniq=
ue
--00000000000058c92805fd8c99cf--