Date: Mon, 5 Jul 2021 18:25:03 +0200
From: Christoph Berg <myon@debian.org>
To: Andrey Borodin <x4mmm@yandex-team.ru>
Cc: pgsql-pkg-debian@postgresql.org
Subject: Re: Adding packages fro WAL-G and Odyssey
Message-ID: <YOMyXyErQ50je0zh@msg.df7cb.de>
Mail-Followup-To: Christoph Berg <myon@debian.org>,
	Andrey Borodin <x4mmm@yandex-team.ru>,
	pgsql-pkg-debian@postgresql.org
References: <5FDAF3A4-4C0D-47F5-821F-20CFD578B3C6@yandex-team.ru>
 <YDAvu3qeDUXbiwdB@msg.df7cb.de>
 <54DCFC65-56DE-43AE-8219-B9D19B5AA311@yandex-team.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <54DCFC65-56DE-43AE-8219-B9D19B5AA311@yandex-team.ru>
Archived-At: 
 <https://www.postgresql.org/message-id/YOMyXyErQ50je0zh%40msg.df7cb.de>
Precedence: bulk

Re: Andrey Borodin
> > we'd need a proper debian/ directory for these, either in the upstream
> > repo or in a separate one.
> Odyssey had debian/ dir https://github.com/yandex/odyssey/tree/master/scripts/debian

Hi,

that directory would need to be /debian, not somewhere deeper in the
tree. (Interestingly, you already have a /debian, just with less
files.)

> WAL-G is simply one Go binary. https://github.com/wal-g/wal-g/tree/master/cmd/pg
> Though it's a separate Go binary for each DB: PG, MySQL, MSSQL, MongoDB etc. But I think it's better to start from PG anyway.
> We used to build this binary and create almost empty debian/ dir with a script (FPA). We can commit this dir it it's better to have it in source tree.

FPA usually doesn't produce "proper" packages with a curated
debian/changelog (no throwing away of old entries, and sensible log
messages) and the other bits.

debian/rules shouldn't try to build a -dbg package these days

debian/control shouldn't depend on postgresql-server-dev-13 but on
postgresql-server-dev-all if you really need server headers instead of
just the client ones.

The Description needs more content

Standards-Version is outdated

Consider using debhelper-compat (= 13) instead of debian/compat 9

Consider providing a systemd .service file along the init script


Christoph