Date: Tue, 16 Nov 2021 14:50:34 +0100
From: Christoph Berg <myon@debian.org>
To: "Pop, Sebastian" <spop@amazon.com>,
	PostgreSQL in Debian <pgsql-pkg-debian@postgresql.org>,
	"Saidi, Ali" <alisaidi@amazon.com>,
	"Csoma, Csaba" <csabac@amazon.com>
Subject: Re: [PATCH] audo-detect and use -moutline-atomics compilation flag
 for aarch64
Message-ID: <YZO3Kmk9PwUw3Mi4@msg.df7cb.de>
Mail-Followup-To: Christoph Berg <myon@debian.org>,
	"Pop, Sebastian" <spop@amazon.com>,
	PostgreSQL in Debian <pgsql-pkg-debian@postgresql.org>,
	"Saidi, Ali" <alisaidi@amazon.com>,
	"Csoma, Csaba" <csabac@amazon.com>
References: <1635266397152.45198@amazon.com>
 <YY1LHr9YYQb0Ds8h@msg.df7cb.de>
 <1636650661046.35954@amazon.com>
 <YY1PP8GLFqBqJppX@msg.df7cb.de>
 <1636652282183.80790@amazon.com>
 <YY2E5tuURTBkkTmd@msg.df7cb.de>
 <1636665927494.4426@amazon.com>
 <1636667644644.16019@amazon.com>
 <1636669594714.41068@amazon.com>
 <YZOIMv4qfPPU6R+z@msg.df7cb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YZOIMv4qfPPU6R+z@msg.df7cb.de>
Archived-At: 
 <https://www.postgresql.org/message-id/YZO3Kmk9PwUw3Mi4%40msg.df7cb.de>
Precedence: bulk

Re: To Pop, Sebastian
> > I also run the above steps on bionic - ubuntu 18.04 - to check that the patch passes when gcc does not have the -moutline-atomics flag.
> > All checks pass on bionic on a c6g instance.
> > Thanks Ali for recommending the extra test.
> 
> Thanks for verifying that part as well, I'll try throwing in the patch
> now.

Things are looking good on PG14, but PG10 and 9.6 fail:

configure.in:485: error: possibly undefined macro: PGAC_PROG_CXX_CFLAGS_OPT

https://pgdgbuild.dus.dg-i.net/job/postgresql-10-binaries/architecture=ppc64el,distribution=focal/76/console

So we'll have it on PG 11 .. 14, unless the regression tests act up.

Christoph