= I wanted to check and see if you were still interested in packaging

sqlite_fdw and redis_fdw for Debian and Ubuntu.

Yes.

I spent some time
looking at sqlite_fdw and I can help with prepari= ng the package.

Thanks! I am = ready to fix my draft repo and support PR to sqlite_fdw mainstream after yo= ur review.

I have
prepared an = initial package that builds locally but before pushing
anything, I wanted to check and see if you have started the packagin= g
effort.

Does in means I should try some .deb production commands on my lo= cal copy of repository?

=
If not, I can setup the package r= epo under the PostgreSQL team
on salsa.debian.or= g.

Are you about some automat= ed additions to some metadata? In this case I can add all needed to PR for = mainstream.

Regards,=

Michel

<= /body> ------=_Part_155844_933850253.1738555333816-- From bradford.d.boyle@gmail.com Mon May 25 07:21:23 2026 Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tfBVX-000GoV-0E for pgsql-pkg-debian@arkaria.postgresql.org; Tue, 04 Feb 2025 05:29:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tfBVV-001RiP-Hg for pgsql-pkg-debian@arkaria.postgresql.org; Tue, 04 Feb 2025 05:29:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tfBVV-001RiH-Bd for pgsql-pkg-debian@lists.postgresql.org; Tue, 04 Feb 2025 05:29:57 +0000 Received: from mail-oa1-x2f.google.com ([2001:4860:4864:20::2f]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tfBVS-003ADf-0Q for pgsql-pkg-debian@lists.postgresql.org; Tue, 04 Feb 2025 05:29:56 +0000 Received: by mail-oa1-x2f.google.com with SMTP id 586e51a60fabf-2b7f09611a9so10588fac.3 for ; Mon, 03 Feb 2025 21:29:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1738646992; x=1739251792; darn=lists.postgresql.org; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :from:to:cc:subject:date:message-id:reply-to; bh=MAeXoSSlNyS95RddM4wENtqZ6OVefEe+SFUd4+VC1hk=; b=Iw+fQzoWIQaLgFW/B1B/Mmvz+5vGFfNfXFq5OOJJPd1vC9Z0moURQk/FlFDhOF4/9G U6gM3JxhaPw868jZz5wB4inaWMWlqtFHWb6Tuz+vJMMsdK415Mg15rkQe9CCMGjFseCN UDGvq/r68BYoe0CrphOI8TJaUUXR6Hx41goQTPRGqQRqaw4S7iQ2xSPWwOnNDrUsvT9D ZQlTPaaM1Z5ugRXW9QgtKfKyJwyEybrZM755itwtURiy97VuLySr1rqm1dvB0Wgni+FI VRTT57Ta6q56iJu8L8yQiXdLRruBHeTX6IFtMDcZkQRK+/ic7UESBf/9nZZverpxcR8a 7w7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738646992; x=1739251792; h=to:subject:message-id:date:from:in-reply-to:references:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MAeXoSSlNyS95RddM4wENtqZ6OVefEe+SFUd4+VC1hk=; b=PZjtDGbxxDUoNyCl9LNTJchupUE3SkgQaXaqP2l2h5jaau4UuUeJZqq3kr2AD+qf0V WLNMYS5SCEOl7t9IbrNTlj68ZDFWZ3OowY1bg0REKw3wcNyy2kYtPg7HlFN0vw1uIGA4 GF9XHGp7ZxVLSOTI533A2slQWH7OW781d9AivYWY9PXjCSPRwlbvvvCN28On2jmTdCZK QYT9yISPDEDXko5OaA0PYFBvP+HeSv7TafzKLwm0L1XXH/qR8HhLI3HfXmT7y7E2B7ut iIk/T/QBpfyiDR8TmPZS6DrCbvLz0L1oNaTPUJCowuu0WL+DuU4/Puv+bJfiswTHIcAq OziQ== X-Forwarded-Encrypted: i=1; AJvYcCVc1N4zTzN335Z+Udj8weC/AtCubA/kQgyVMzYoa7AeRb2kwdTd2kCxwf3eYDdGO3xkwpPhK6xmjB7P/su0/FZN@lists.postgresql.org X-Gm-Message-State: AOJu0YzBwlrJCvY7qtMUXgtCnAjurxJ9uBb+LB3YLF+EAreoZ5bLAakN 17pbzG6huW2lJfY4rjpLnU86DeMMMzpcdXHTnjKe8qKt6tu+BVzsTodmSaL7LFuB1dibmF8Vdf6 NurS2BIBLDW1k3KeUfrfsKypNvRWiMBU/ X-Gm-Gg: ASbGncvRFsiAF0f/UDxf5bDuWmpAZmt9NrU/tpY+E52g8TXHB3/I5Y8ZtVOu8ZKhFgK vuJpoV71yM88I0nZ0VWy14ntChlJGHuwQ0zQdjqm/3nXSqcGmrsLKyOIWnQlwnjx7eNge2Pou X-Google-Smtp-Source: AGHT+IGPTO77l6W0z5mw5hQ2uVHAYyIgCMmxRpbL3aezGGJOWPvZdNRVSUVveAe7qrJtvOyEb5QQ6fAszX/K4ix/UIM= X-Received: by 2002:a05:6870:7d09:b0:29e:290f:7aea with SMTP id 586e51a60fabf-2b32f2e93c7mr16229077fac.34.1738646992622; Mon, 03 Feb 2025 21:29:52 -0800 (PST) MIME-Version: 1.0 References:

In-Reply-To: From: Bradford Boyle Date: Mon, 3 Feb 2025 21:29:41 -0800 X-Gm-Features: AWEUYZkkvrvZATbnB5sUIAQkz2LeHSXKhEKHzW2qusuWAHw6wU0CkXv2u6cW9to Message-ID: Subject: Re: Redis & SQLite FDW packages To: pgsqlitegis@tutamail.com, pgsql-pkg-debian@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Michel, I've reviewed your branch and here is my feedback: * d/changelog is for the Debian version of the package Since the first packaged version of the extension is 2.5.0, the changelog should start with that version. Older versions are not included since they haven't been uploaded to the Debian archive. * Potentially incorrect version format This depends on whether the package is intended to be a native or non-native package; see [0] for a summary of the differences between the two. The majority of PostgreSQL Debian packages that I have reviewed/worked on have been non-native. For a non-native package, the Debian package version is a combination of the upstream version (e.g., 2.5.0) and a Debian component (e.g., 2.5.0-1). * Invalid Source and Package name Per Debian policy [1]: > Package names (both source and binary, see Package) must consist > only of lower case letters (a-z), digits (0-9), plus (+) and minus > (-) signs, and periods (.). They must be at least two characters > long and must start with an alphanumeric character. So the correct name for the source package would be sqlite-fdw and for the binary package postgresql-PGVERSION-sqlite-fdw * Missing some common Build-Depends that dh_make_pgxs includes when creating a new source package * Incorrect matching pattern in d/watch The matching pattern needs to match hrefs in the web page at found at the URL. In this case, it needs to match the tag format of v(x.y.z).tar.gz * Additional packages are required for running the installcheck test I needed to include locales-all, sqlite3, and tzdata-legacy in the tests dependencies for the test to run * Needed to pass REGRESS_PREFIX to make when running installcheck The latest version of PostgreSQL in Debian unstable is 17.2. When running the installcheck target, this version was expanded into a directory path to specify which SQL queries to run during testing but the there is no 17.2 directory under expected. This will probably require a change to upstream sqlite_fdw in order for the test to successfully run on the full matrix of supported PG versions. I have pushed my work-in-progress (which incorporates your work) to a personal repo on salsa.debian.org [3]. To try building the binary package localy, you can install the devscripts package and then try running debuild -i -us -uc -b. I have my development environment setup to build packages with sbuild [2] so I haven't tested this. I wouldn't recommend setting up sbuild unless you intend to really get involved with broader Debian packaging work. Regards, -- Bradford [0]: https://www.debian.org/doc/debian-policy/ch-source.html [1]: https://www.debian.org/doc/debian-policy/ch-controlfields.html#source [2]: https://salsa.debian.org/bradfordboyle/sqlite-fdw [3]: https://wiki.debian.org/sbuild From bradford.d.boyle@gmail.com Mon May 25 07:21:23 2026 Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tjmzl-00DRCm-Ht for pgsql-pkg-debian@arkaria.postgresql.org; Sun, 16 Feb 2025 22:20:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tjmzk-00BBHH-2W for pgsql-pkg-debian@arkaria.postgresql.org; Sun, 16 Feb 2025 22:20:12 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tjmzj-00BBGQ-Lu for pgsql-pkg-debian@lists.postgresql.org; Sun, 16 Feb 2025 22:20:11 +0000 Received: from mail-oo1-xc2e.google.com ([2607:f8b0:4864:20::c2e]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1tjmzh-001CIB-2b for pgsql-pkg-debian@lists.postgresql.org; Sun, 16 Feb 2025 22:20:10 +0000 Received: by mail-oo1-xc2e.google.com with SMTP id 006d021491bc7-5fcae429587so1088992eaf.3 for ; Sun, 16 Feb 2025 14:20:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739744409; x=1740349209; darn=lists.postgresql.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=SyaoNnb3LveFEOJ8YsMCWysdwvHksKsE7OAdANqsipI=; b=V3F/VWKja+FilA6jdO2HuCsjY9ILdXnM9pck98bIu+6GzNCuyXZGjru/wENLloOifY XvnRnD7LTCAoB/LnTsERIDt8r1HGz2gLuRmsPD6K58gK9mBEPH021l0TUB1Zr7zvMkfD FYGxqxY9Ji6oI6ffoJvXLV5EAJIgjL9Bcbnr4Tg9ad9hmb4IdKbSC5huAh/3Gx5EDIOT UWbKXjClY65X2a38pDlTeKmy52c2Q3/ohV9NgIMiRIC7+QPTeyErksMDN0AZ4kCl15pZ 4IgduYvKaxShtiDZioIWEkL+sHwImXqfjnWwkuAq1BmMhEBGtrkDlSDzZvja7c6dyP1Q 4rSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739744409; x=1740349209; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=SyaoNnb3LveFEOJ8YsMCWysdwvHksKsE7OAdANqsipI=; b=kFF+gM6RdOng3+W3tJwDVNDJulUaX3Q7kxTkJ6REZYcnoYbLpG+axWqRUDl/bZxsY7 pr4xsZ9vT+01rwZ8eauqJ4mub3iKbq2g0ZK22AvzurABzIXo1OH/ABNM1nSyexAg7QEf cQmsM6e2zUCmo/j1ESw/269DhJZ4c55U3jeGWm/AEpHtPJDnxj5B8LFoJ9QRS9HRrGwv F9G4aNcEfXfIkFOJP21iJAC8KSqZMOOwNQZ/coVx2W4bAVpulsoujE4LQdbxk4dQWetb ULSKDv6tDFTmPYyyO50+8m41QL4Ymd18WOJbgC59403mJCR6OQ6GyMe6YhO02ors+Rx5 UrWw== X-Gm-Message-State: AOJu0YyxseCsbCYxfd1Wv7XYUcpWbH2B/R76mTCT+CIu8n4ZL0CvK5PM 5O+R1HgAvaYoBf5pUaHgKNOGaUo8NEkmD+JsGR9kzI0Y/xVgcH2sklIOA9xhnS6UV18YiYYh4gc kTSvFSLHoeKDKH7XmoyZgdUWEU/c= X-Gm-Gg: ASbGncuMQ3hddJAXy2ivR4si+c9FuBMdpXOIhz0jeOO451qPGpJhu1Gs+8qYaDJgcqw InIQo0op6lUJamvnWhdCun0qVIYxiIvH9fo0fqaa18/ukMhLT0CV7R+hfLhegjxBvJ+rULkuB X-Google-Smtp-Source: AGHT+IF2ESWT652GQAdHjDhJUDHZ5/tMBPxVQOp9N/Y3ULKsIwnEonnTCBP2SiKSc/Z8kNXVRWMhgmZL2e/IP/uUQ6A= X-Received: by 2002:a05:6808:210c:b0:3f3:c417:a2e8 with SMTP id 5614622812f47-3f3eb0b128dmr4624806b6e.9.1739744408785; Sun, 16 Feb 2025 14:20:08 -0800 (PST) MIME-Version: 1.0 References:

In-Reply-To: From: Bradford Boyle Date: Sun, 16 Feb 2025 14:19:57 -0800 X-Gm-Features: AWEUYZmPb4CzsxzLH_EVatUhLF-_aDPdvgFu-y8hS1imqs-uTBHy_HDBorFebuE Message-ID: Subject: Re: Redis & SQLite FDW packages To: pgsqlitegis@tutamail.com Cc: pgsql-pkg-debian@lists.postgresql.org Content-Type: text/plain; charset="UTF-8" List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi Michel, I have provided a some detailed comments about the files under debian/ below. However, as a high-level comment I am somewhat confused about the layout of the repository. It looks like have both the unpacked source package form and the original upstream source are being tracked in the same repo. I know that it is mentioned that this is possible in the postgresql-debian-packaging [1] documentation but I don't think I have seen this done of additional tooling like gbp [2] which it doesn't look like is the case here. When I attempt to build the package using either sbuild or dpkg-buildpackge, it complains that no upstream tarball can be found. What I've seen most commonly with packages maintained by the Debian PostgreSQL Maintainers is that unpacked source format only is maintained in a separate git repo (usually hosted on salsa.debian.org). As a concrete example, the source package for pgvector is maintained at https://salsa.debian.org/postgresql/pgvector and it only contains the content of the debian/ directory. The upstream source tar archive is downloaded from the GitHub repo for pgvector https://github.com/pgvector/pgvector. This downloading can be done wither manually or with uscan. Assuming the desired end-goal is that the sqlite_fdw is available for download and installation from the PGDG archive for all supported versions of PostgreSQL, these are the steps that need to be done: 1. File an intent-to-package (ITP) bug [3] with bugs.debian.org * This will be the source of the bug number that will be referenced in the d/changelog line "Initial release. (Closes: #XXXXXX)" 2. Set up a Git repo on salsa.debian.org for maintaining the unpacked source package form and get that passing Salsa's standard CI/CD pipeline * Most the work creating the unpacked source package form is done and hosting on s.d.o is not strictly required but follows the convention most other PostgreSQL packages are following. Passing Salsa's standard CI/CD pipeline will give a good indication of whether the package will successfully upload to the Debian archive 3. Add configuration to pgapt [4] to configure the PGDG archive to build and publish the package for all supported Debian/Ubuntu distributions and all supported PostgreSQL versions 1. d/NEWS * You do not need the asterisk per [5] 2. d/changelog * should be UNRELEASED since the package has not been uploaded to the Debian archive yet. In my experience as a non-uploading team member, this is changed to unstable when the uploader uploads to the archive. It is set to unstable because that's the distribution that the upload is going to; it will automatically enter testing based on a set of criteria outlined in [6]. These terms are referring to the Debian distribution and not a reflection of the state of the upstream project. When the package is re-uploaded to the PGDG repos, a new changelog entry will be automatically appended with the appropriate distribution substituted. * The content of d/changelog is the changelog for the Debian source package not the upstream project -- I would not include content from any of the releases prior to the initial release version but this is my opinion/preference and not hard technical requirement. 3. d/control * The Maintainer field should be set to the package maintainer's name and email address [7] * The Maintainer field is currently just as "Taiga Katayama" but this field is intended for the individual(s) who are maintaining the Debian package, not necessarily the upstream maintainer. This could either be set to yourself or to the Debian PostgreSQL Maintainers. Either way, you will most likely need to also include an Uploaders field which includes the name and email address of a uploader. [8] * There should only be one binary package for PostgreSQL 17 listed in d/control. The Debian archive only has one version of the PostgreSQL server packages available which for unstable is currently 17. Including the other versions and their build dependencies in the source package will fail to build when uploading to the archive. The archive hosted at PGDG will use d/control.in to re-build the package for all PostgreSQL versions available in the PGDG archive. 4. d/copyright * I am unsure about the use of 'PostgreSQL_like' in the License field. My overly cautious reading of [9] indicates that this field should use a standard short name and this name is not referenced in either [9] or [10]. Based on a quick reading of [11], I think the short name should be either 'PostgreSQL License' or 'PostgreSQL'. However, I am not an expert on copyright matters and this is my opinion informed by the referenced links. 5. d/tests * I anticipate that the autopkgtests will fail as-is when building the packages on PGDG because of the hard-coding of the minor version in the paths to the SQL queries. I have a patch that uses wildcards to match the PostgreSQL major version to the appropriate tests. [1]: https://salsa.debian.org/postgresql/postgresql-common/-/blob/master/doc/postgresql-debian-packaging.md [2]: https://wiki.debian.org/PackagingWithGit [3]: https://wiki.debian.org/ITP [4]: https://git.postgresql.org/gitweb/?p=pgapt.git;a=summary [5]: https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.en.html#supplementing-changelogs-with-news-debian-files [6]: https://wiki.debian.org/DebianTesting [7]: https://www.debian.org/doc/debian-policy/ch-controlfields.html#maintainer [8]: https://www.debian.org/doc/debian-policy/ch-binary.html#s-maintainer [9]: https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-short-name [10]: https://spdx.org/licenses/ [11]: https://spdx.org/licenses/PostgreSQL.html