Date: Wed, 5 Feb 2025 10:09:51 +0100
From: Christoph Berg <cb@df7cb.de>
To: Bradford Boyle <bradford.d.boyle@gmail.com>
Cc: pgsql-pkg-debian@postgresql.org
Subject: Re: PgBouncer 1.24.0 - New upstream version
Message-ID: <Z6Mq3xL_VpiNwOFm@msg.df7cb.de>
Mail-Followup-To: Christoph Berg <cb@df7cb.de>,
	Bradford Boyle <bradford.d.boyle@gmail.com>,
	pgsql-pkg-debian@postgresql.org
References: 
 <CAGKCzNBZO-AQMfmbfbn20wvE+63j50YuPBKJupYLiDCmc84OeA@mail.gmail.com>
 <CAOMoQbROhu7WG9LnyjHb1RXJrax_HKKMBbwaou+jps0uZgqHFw@mail.gmail.com>
 <CAOMoQbQzutP0UMU3KUZAE4A9Jf8bS=uSBRdUX7g=9xxoBbosmQ@mail.gmail.com>
 <CAGKCzNAQKMKJ_BQcF=uzcfcM=vx8QYnT+jtzuv_yp=76zbhn7g@mail.gmail.com>
 <CAGKCzNAW4BFq_cSKpnPvG6hRF65G3HptjUvWVW=DefPaPMF2pg@mail.gmail.com>
 <CAGKCzNAJzhzxJ809y9e6ttYbL0k6id5KmkzmBrz5xZROd79etQ@mail.gmail.com>
 <CAGKCzNC6RkY54TrkqqQ9K83AF=vrYe+CB14-PUSLTF5YMbzrmA@mail.gmail.com>
 <CAOMoQbT3zRuL+YLeiUrOG5-vYsvrZ2MJF_DQoa3E94cBfdv6xw@mail.gmail.com>
 <Z6Is1o56psB3-TMT@msg.df7cb.de>
 <CAOMoQbTA2qOo+f_4JE+oYGupZANh-0msn_Pw36qb7v3PfT1e0w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAOMoQbTA2qOo+f_4JE+oYGupZANh-0msn_Pw36qb7v3PfT1e0w@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/Z6Mq3xL_VpiNwOFm%40msg.df7cb.de>
Precedence: bulk

Re: Bradford Boyle
> I think we could go without tests on bullseye since it seems like we are
> nearing the trixie release and bullseye will become old old stable.
> (Correct me if I am wrong on this point, I'm making this assumption
> based on the trixie freeze dates). There's probably little value in
> creating extra work here.

Or we just don't update the package on bullseye, leaving it at 1.23.1.
But there is still the autopkgtest, so we still have test coverage
there.

> It looks like d/rules for pgbouncer will skip the tests if nocheck is in
> DEB_BUILD_OPTIONS -- is this something that can be configured via the Jenkins
> YAML? I am not very familiar with the Jenkins job builder YAML and I didn't see
> any usages of that in the current set of jobs. Or would I need to update
> generate-pgdg-source to include an additional tweak to disable the tests on
> older platforms?

Any of these would work.

DEB_BUILD_OPTIONS=nocheck would have to be set in the sbuild-package
script. That's probably the easiest way forward.

The extra test dependencies need annotating with <!nocheck> so the
build doesn't try to install them.

Christoph