Date: Mon, 31 Jul 2023 16:59:37 +0200
From: Christoph Berg <myon@debian.org>
To: Bradford Boyle <bradford.d.boyle@gmail.com>
Cc: Esteban Zimanyi <estebanzimanyi@gmail.com>,
	=?iso-8859-1?Q?C=E9dric?= Villemain <cedric.villemain@abcsql.com>,
	pgsql-pkg-debian@lists.postgresql.org,
	SCHOEMANS Maxime <Maxime.Schoemans@ulb.be>
Subject: Re: Packaging request MobilityDB
Message-ID: <ZMfMWcLtZIVxbDYj@msg.df7cb.de>
References: 
 <CAOMoQbQPOs827ZNk2atm0JHQYDJ4iW339a8HxovxUZzpa4RjtA@mail.gmail.com>
 <CAPqRbE7W2ifWkjAGZ36cAE1kd23m0gmz5sgn_49MWam2kA+=CQ@mail.gmail.com>
 <75679669-4482-3f16-bd4d-6ec1f9950941@abcsql.com>
 <CAPqRbE4QXeno00wdRU6dy8h9AFr8z1o1keSpxN6=T8eW8jCM_A@mail.gmail.com>
 <CAOMoQbTCo1_+0A07qROHqdifiCnev8iAZmbVvJt4omvO7SdG4w@mail.gmail.com>
 <CAPqRbE5q7e1angCk9Gzy9TQzSTPAyVgQ=yOURoj62vgVBL0qxg@mail.gmail.com>
 <CAPqRbE7sVQmhFy2icHV6eN9HRuAdCcL6mx_V5RnxYkQn3yDWkw@mail.gmail.com>
 <CAOMoQbSRRmq6rj-99zoj=f3YX74nXuLp6Mnnc0CrGP_bp_PyvQ@mail.gmail.com>
 <CAPqRbE5TAvpPxkW_AJrbbVKu1bPbk7-Du444CTya9mTrajaGBQ@mail.gmail.com>
 <CAOMoQbSGU0PJmOd4n76B8_DG4LTj9FHqEAxcdMCoA1gNXabCvg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAOMoQbSGU0PJmOd4n76B8_DG4LTj9FHqEAxcdMCoA1gNXabCvg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/ZMfMWcLtZIVxbDYj%40msg.df7cb.de>
Precedence: bulk

Hi,

I've finally found the time to look at MobilityDB.

Re: Bradford Boyle
> * Debian 13 (trixie/testing)
> - builds successfully
> - piuparts passes
> - autopkgtests fail for trixie (testing)
> * test failure looks to be an issue with the newer libproj (9.2.1)
> included in trixie

When I run the tests on unstable I get this:

$ debian/tests/installcheck
Creating new PostgreSQL cluster 15/regress ...
test 001_set                      ... *** /tmp/pg_virtualenv.ye3HhD/log/postgresql-15-regress.log (last 100 lines) ***
2023-07-31 14:44:57.593 UTC [321171] LOG:  starting PostgreSQL 15.3 (Debian 15.3-0+deb12u1) on x86_64-pc-linux-gnu, compiled by gcc (Debian 12.2.0-14) 12.2.0, 64-bit
2023-07-31 14:44:57.593 UTC [321171] LOG:  listening on IPv4 address "127.0.0.1", port 5433
2023-07-31 14:44:57.594 UTC [321171] LOG:  could not bind IPv4 address "127.0.0.1": Address already in use
2023-07-31 14:44:57.594 UTC [321171] HINT:  Is another postmaster already running on port 5433? If not, wait a few seconds and retry.
2023-07-31 14:44:57.594 UTC [321171] LOG:  listening on Unix socket "/tmp/.s.PGSQL.5433"
2023-07-31 14:44:57.595 UTC [321174] LOG:  database system was shut down at 2023-07-31 14:44:57 UTC
2023-07-31 14:44:57.597 UTC [321171] LOG:  database system is ready to accept connections
2023-07-31 14:45:00.903 UTC [321209] myon@postgres ERROR:  Could not parse the set: Missing open brace at character 29
2023-07-31 14:45:00.903 UTC [321209] myon@postgres STATEMENT:  /* Errors */
	SELECT tstzset '2000-01-01, 2000-01-02';
Dropping cluster 15/regress ...

(After setting : ${AUTOPKGTEST_TMP:=/tmp} )

debian/copyright: LICENSE mentions the ULB - haven't checked the rest
of the source yet

debian/tests/installcheck: Why is that .so trickery necessary? If
mobilitydb needs postgis that way, it should link against it.

debian/control.in: This would be the first package to use PGVERSION in
the Build-Depends list. I'm slightly surprised it works, but
apparently I coded the logic in pg_buildext correctly. ;)

Is the postgis version used at build time relevant? There is a
postgresql-postgis package that could be used instead. (If the version
is relevant, we need a solution that works when more than one version
is targeted.)

Christoph