Date: Sun, 5 Nov 2023 12:02:13 +0100
From: Christoph Berg <myon@debian.org>
To: Devrim =?iso-8859-1?B?R/xuZPx6?= <devrim@gunduz.org>
Cc: Regina Obe <lr@pcorp.us>, pgsql-pkg-debian@lists.postgresql.org
Subject: Re: Include h3-pg extension
Message-ID: <ZUd2NbAg9AsnihLq@msg.df7cb.de>
References: <000601da0ec8$d7cc27e0$876477a0$@pcorp.us>
 <ZUYT7yQnNIj2RmSi@msg.df7cb.de>
 <d6b178efba9a98e12eb631491f1c240fbd20c61e.camel@gunduz.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <d6b178efba9a98e12eb631491f1c240fbd20c61e.camel@gunduz.org>
Archived-At: 
 <https://www.postgresql.org/message-id/ZUd2NbAg9AsnihLq%40msg.df7cb.de>
Precedence: bulk

Re: Devrim Gündüz
> There are some overlapping files between h3 and h3-pg. I did not check
> closely, but you may not have to package h3. Just a FYI.

It took me a while to figure out because it was hidden in an
unexpected location, but the reason h3-pg can be compiled without h3
is that it downloads it at build time:

CMakeLists.txt:
# Include core library
add_subdirectory(cmake/h3)

cmake/h3/CMakeLists.txt:
FetchContent_Declare(
  h3
  URL      https://github.com/uber/h3/archive/refs/tags/v${H3_CORE_VERSION}.tar.gz
  URL_HASH SHA256=${H3_CORE_SHA256}
)
FetchContent_MakeAvailable(h3)

Deleting the line from CMakeLists.txt made it properly use the
system-installed libh3.

Regina: postgresql-NN-h3 packages are in the repository.

Christoph