Date: Mon, 21 Jul 2025 22:06:33 +0200
From: Christoph Berg <myon@debian.org>
To: Huang Yuying <huangyy159@hotmail.com>
Cc: "pgsql-pkg-debian@postgresql.org" <pgsql-pkg-debian@postgresql.org>,
	"schneider@ardentperf.com" <schneider@ardentperf.com>,
	"bertranddrouvot.pg@gmail.com" <bertranddrouvot.pg@gmail.com>
Subject: Re: Request to Add New Package: pgsentinel
Message-ID: <aH6dyX_H4Zpx7TOj@msg.df7cb.de>
Mail-Followup-To: Christoph Berg <myon@debian.org>,
	Huang Yuying <huangyy159@hotmail.com>,
	"pgsql-pkg-debian@postgresql.org" <pgsql-pkg-debian@postgresql.org>,
	"schneider@ardentperf.com" <schneider@ardentperf.com>,
	"bertranddrouvot.pg@gmail.com" <bertranddrouvot.pg@gmail.com>
References: <394D2E6D-8779-49B3-AB29-C55DD1F7F9EB@hotmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <394D2E6D-8779-49B3-AB29-C55DD1F7F9EB@hotmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aH6dyX_H4Zpx7TOj%40msg.df7cb.de>
Precedence: bulk

Re: Huang Yuying
> The packaging code is publicly available at: https://salsa.debian.org/laurah159/pgsentinel/.
> 
> To support packaging, we made the following changes to the upstream pgsentinel code:
> 
>   1.  Added a top-Level Makefile

Hi,

this doesn't to be present yet in the 1.1.0 tarball. How did you
invoke the build such that it actually worked?

$ dpkg-buildpackage -rfakeroot -us -uc -i -I -j20
dpkg-buildpackage: info: source package pgsentinel
dpkg-buildpackage: info: source version 1.1.0-1
dpkg-buildpackage: info: source distribution UNRELEASED
dpkg-buildpackage: info: source changed by Laura H. <huangyy159@hotmail.com>
dpkg-buildpackage: info: host architecture amd64
 dpkg-source -i -I --before-build .
 debian/rules clean
dh clean --with pgxs_loop
   dh_auto_clean --buildsystem=pgxs_loop
	pg_buildext clean build-%v postgresql-%v-pgsentinel
rm -rf build-*/
rm -rf debian/postgresql-17-pgsentinel/ debian/postgresql-*-pgsentinel.substvars
   dh_clean
   pg_buildext checkcontrol
 dpkg-source -i -I -b .
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building pgsentinel using existing ./pgsentinel_1.1.0.orig.tar.gz
dpkg-source: info: building pgsentinel in pgsentinel_1.1.0-1.debian.tar.xz
dpkg-source: info: building pgsentinel in pgsentinel_1.1.0-1.dsc
 debian/rules binary
dh binary --with pgxs_loop
   dh_update_autotools_config
   dh_autoreconf
   dh_auto_build --buildsystem=pgxs_loop
   create-stamp debian/debhelper-build-stamp
   dh_prep
   dh_auto_install --buildsystem=pgxs_loop --destdir=debian/postgresql-17-pgsentinel/
	pg_buildext loop postgresql-%v-pgsentinel
### PostgreSQL 17 loop ###
# 17: make
make[1]: Entering directory '/home/myon/projects/postgresql/pgsentinel/pgsentinel'
make[1]: *** No targets specified and no makefile found.  Stop.
make[1]: Leaving directory '/home/myon/projects/postgresql/pgsentinel/pgsentinel'
### End 17 loop (FAILED with exit code 2) ###
dh_auto_install: error: pg_buildext loop postgresql-%v-pgsentinel returned exit code 2
make: *** [debian/rules:10: binary] Error 2
dpkg-buildpackage: error: debian/rules binary subprocess returned exit status 2


> By the way, in the debian/control.in file, is it possible to add two uploaders? Jeremy will probably be the ongoing maintainer, and I would like to include him as an uploader.

It's a comma-separated list.

Christoph