Date: Wed, 30 Jul 2025 16:53:16 +0200
From: Christoph Berg <myon@debian.org>
To: Huang Yuying <huangyy159@hotmail.com>
Cc: "pgsql-pkg-debian@postgresql.org" <pgsql-pkg-debian@postgresql.org>,
	"bertranddrouvot.pg@gmail.com" <bertranddrouvot.pg@gmail.com>,
	Jeremy Schneider <schneider@ardentperf.com>
Subject: Re: Request to Add New Package: pgsentinel
Message-ID: <aIox3At331Tczeq2@msg.df7cb.de>
Mail-Followup-To: Christoph Berg <myon@debian.org>,
	Huang Yuying <huangyy159@hotmail.com>,
	"pgsql-pkg-debian@postgresql.org" <pgsql-pkg-debian@postgresql.org>,
	"bertranddrouvot.pg@gmail.com" <bertranddrouvot.pg@gmail.com>,
	Jeremy Schneider <schneider@ardentperf.com>
References: <394D2E6D-8779-49B3-AB29-C55DD1F7F9EB@hotmail.com>
 <aH6dyX_H4Zpx7TOj@msg.df7cb.de>
 <468473AA-ABA8-49D1-8EAE-0C43E3968F1E@hotmail.com>
 <20250721234959.12020aa2@ardentperf.com>
 <SA1PR02MB8608ACD0EE5A90574B3C97688724A@SA1PR02MB8608.namprd02.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: 
 <SA1PR02MB8608ACD0EE5A90574B3C97688724A@SA1PR02MB8608.namprd02.prod.outlook.com>
Archived-At: 
 <https://www.postgresql.org/message-id/aIox3At331Tczeq2%40msg.df7cb.de>
Precedence: bulk

Re: Huang Yuying
> Just wanted to give you a quick update that a new version of pgsentinel h=
as been released with the changes needed to support the Debian build proces=
s, as mentioned in the previous email. We=E2=80=99ve also updated the Salsa=
 repo to reflect this new release.

Hi,

thanks for preparing that, everything looks just fine and I already
built and uploaded the packages.

The repo is now located at https://salsa.debian.org/postgresql/pgsentinel,
I gave you maintainer access to it.

First bugreport: PG18 doesn't work yet :)

16:45:03 gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after=
-statement -Werror=3Dvla -Wendif-labels -Wmissing-format-attribute -Wimplic=
it-fallthrough=3D3 -Wcast-function-type -Wshadow=3Dcompatible-local -Wforma=
t-security -Wmissing-variable-declarations -fno-strict-aliasing -fwrapv -fe=
xcess-precision=3Dstandard -Wno-format-truncation -Wno-stringop-truncation =
-g -g -O2 -Werror=3Dimplicit-function-declaration -fstack-protector-strong =
-fstack-clash-protection -Wformat -Werror=3Dformat-security -fcf-protection=
 -fno-omit-frame-pointer -g -O2 -Werror=3Dimplicit-function-declaration -ff=
ile-prefix-map=3D/<<PKGBUILDDIR>>=3D. -fstack-protector-strong -fstack-clas=
h-protection -Wformat -Werror=3Dformat-security -fcf-protection -fPIC -fvis=
ibility=3Dhidden -std=3Dc99 -Wall -Wextra -Werror -Wno-unused-parameter -Wn=
o-implicit-fallthrough -Iinclude -I. -I./ -I/usr/include/postgresql/18/serv=
er -I/usr/include/postgresql/internal    -Wdate-time -D_FORTIFY_SOURCE=3D2 =
-D_GNU_SOURCE -I/usr/include/libxml2   -c -o pgsentinel.o pgsentinel.c
16:45:03 pgsentinel.c:77:7: error: no previous declaration for =E2=80=98pgs=
entinelDbName=E2=80=99 [-Werror=3Dmissing-variable-declarations]
16:45:03    77 | char *pgsentinelDbName =3D "postgres";
16:45:03       |       ^~~~~~~~~~~~~~~~
16:45:03 cc1: all warnings being treated as errors

https://jengus.postgresql.org/job/pgsentinel-binaries-beta/1/architecture=
=3Damd64,distribution=3Dsid/console

Christoph