Date: Thu, 31 Jul 2025 05:04:05 +0000
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Christoph Berg <myon@debian.org>, Huang Yuying <huangyy159@hotmail.com>,
	"pgsql-pkg-debian@postgresql.org" <pgsql-pkg-debian@postgresql.org>,
	Jeremy Schneider <schneider@ardentperf.com>
Subject: Re: Request to Add New Package: pgsentinel
Message-ID: <aIr5RYlvKYGhh5U/@ip-10-97-1-34.eu-west-3.compute.internal>
References: <394D2E6D-8779-49B3-AB29-C55DD1F7F9EB@hotmail.com>
 <aH6dyX_H4Zpx7TOj@msg.df7cb.de>
 <468473AA-ABA8-49D1-8EAE-0C43E3968F1E@hotmail.com>
 <20250721234959.12020aa2@ardentperf.com>
 <SA1PR02MB8608ACD0EE5A90574B3C97688724A@SA1PR02MB8608.namprd02.prod.outlook.com>
 <aIox3At331Tczeq2@msg.df7cb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <aIox3At331Tczeq2@msg.df7cb.de>
Archived-At: 
 <https://www.postgresql.org/message-id/aIr5RYlvKYGhh5U/%40ip-10-97-1-34.eu-west-3.compute.internal>
Precedence: bulk

Hi,

On Wed, Jul 30, 2025 at 04:53:16PM +0200, Christoph Berg wrote:
> Re: Huang Yuying
> > Just wanted to give you a quick update that a new version of pgsentinel=
 has been released with the changes needed to support the Debian build proc=
ess, as mentioned in the previous email. We=E2=80=99ve also updated the Sal=
sa repo to reflect this new release.

Thanks for doing this!

> Hi,
>=20
> thanks for preparing that, everything looks just fine and I already
> built and uploaded the packages.
>=20
> The repo is now located at https://salsa.debian.org/postgresql/pgsentinel,
> I gave you maintainer access to it.
>=20
> First bugreport: PG18 doesn't work yet :)

Thanks for the report! ;-)

> 16:45:03 gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-aft=
er-statement -Werror=3Dvla -Wendif-labels -Wmissing-format-attribute -Wimpl=
icit-fallthrough=3D3 -Wcast-function-type -Wshadow=3Dcompatible-local -Wfor=
mat-security -Wmissing-variable-declarations -fno-strict-aliasing -fwrapv -=
fexcess-precision=3Dstandard -Wno-format-truncation -Wno-stringop-truncatio=
n -g -g -O2 -Werror=3Dimplicit-function-declaration -fstack-protector-stron=
g -fstack-clash-protection -Wformat -Werror=3Dformat-security -fcf-protecti=
on -fno-omit-frame-pointer -g -O2 -Werror=3Dimplicit-function-declaration -=
ffile-prefix-map=3D/<<PKGBUILDDIR>>=3D. -fstack-protector-strong -fstack-cl=
ash-protection -Wformat -Werror=3Dformat-security -fcf-protection -fPIC -fv=
isibility=3Dhidden -std=3Dc99 -Wall -Wextra -Werror -Wno-unused-parameter -=
Wno-implicit-fallthrough -Iinclude -I. -I./ -I/usr/include/postgresql/18/se=
rver -I/usr/include/postgresql/internal    -Wdate-time -D_FORTIFY_SOURCE=3D=
2 -D_GNU_SOURCE -I/usr/include/libxml2   -c -o pgsentinel.o pgsentinel.c
> 16:45:03 pgsentinel.c:77:7: error: no previous declaration for =E2=80=98p=
gsentinelDbName=E2=80=99 [-Werror=3Dmissing-variable-declarations]
> 16:45:03    77 | char *pgsentinelDbName =3D "postgres";
> 16:45:03       |       ^~~~~~~~~~~~~~~~
> 16:45:03 cc1: all warnings being treated as errors
>=20

Just pushed a fix.

Best,
Bertrand