Message-ID: <ccc86697fadc1b11297ce1981e49d4d2cc9bff0e.camel@credativ.de>
Subject: Re: Fixed port 65432 in pglogical_create_subscriber
From: Michael Banck <michael.banck@credativ.de>
To: William Ivanski <william.ivanski@2ndquadrant.com>
Cc: pgsql-pkg-debian@postgresql.org
Date: Fri, 25 Sep 2020 13:29:08 +0200
In-Reply-To: 
 <CAG7+Lq__342Y7GMzhmmspPRmE=SuPRcEvPhEsMJcg9o6PjWt8A@mail.gmail.com>
References: 
	<CAG7+Lq__342Y7GMzhmmspPRmE=SuPRcEvPhEsMJcg9o6PjWt8A@mail.gmail.com>
Organization: credativ GmbH
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.5-1.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Hi,

Am Freitag, den 25.09.2020, 01:18 -0300 schrieb William Ivanski:
> As you can see below (sensitive information redacted), I have
> configured to start local PostgreSQL database on port 5433. File
> /etc/postgresql/9.4/main/postgresql.conf confirms port is set to
> 5433.h
> 
> postgres@subserver ~ $ /usr/lib/postgresql/9.4/bin/pglogical_create_subscriber \
> >  -D /var/lib/postgresql/9.4/main/ -n subserver \
> >  --subscriber-dsn='host=127.0.0.1 port=5433 dbname=mydb user=pglogical' \
> >  --provider-dsn='host=192.168.0.100 port=5432 dbname=mydb user=pglogical' \
> >  --hba-conf=/etc/postgresql/9.4/main/pg_hba.conf \
> >  --postgresql-conf=/etc/postgresql/9.4/main/postgresql.conf \
> >  --drop-slot-if-exists -s -v
> pglogical_create_subscriber: starting ...
> Getting information for database mydb ...
> Creating replication slot in database mydb ...
> Creating restore point "pglogical_create_subscriber_59e1d7bc" on remote node ...
> Bringing subscriber node to the restore point ...
> Waiting for PostgreSQL to accept connections ....
> Waiting for PostgreSQL to become primary...Waiting for PostgreSQL to accept connections ...
> 
> Removing old pglogical configuration ...
> Waiting for PostgreSQL to shutdown ...
> Initializing pglogical on the subscriber node:
> Waiting for PostgreSQL to accept connections ................[never ends]
> 
> pglogical_create_subscriber started the local PostgreSQL instance on
> port 65432, but it's expecting to connect to port 5433, so it will
> never be able to connect.

If I take out that patch, pglogical_create_subscriber seems to start
postgres on the default port (5432), without looking at subscriber-dsn,
so I'm unsure it would work for your 5433 port. Did you test it with
upstream pglogical and/or how is this supposed to work?

I get a process with
"/usr/lib/postgresql/12/bin/pglogical_create_subscriber -D
/tmp/regresscheck.R5THTZ/tmp_check/tmp_backupdir --subscriber-
name=test_subscriber --subscriber-
dsn=host=/tmp/regresscheck.R5THTZ/tmp_check/tmp_socketdir user=super
port=65432 dbname=postgres --provider-
dsn=host=/tmp/regresscheck.R5THTZ/tmp_check/tmp_socketdir user=super
port=65431 dbname=postgres --drop-slot-if-exists -v --hba-conf=regress-
pg_hba.conf --postgresql-
conf=/tmp/regresscheck.R5THTZ/tmp_check/tmp_datadir/postgresql.conf"

but in /tmp/regresscheck.R5THTZ/tmp_check/tmp_socketdir the sockets are:

.s.PGSQL.5432  .s.PGSQL.5432.lock  .s.PGSQL.65431  .s.PGSQL.65431.lock

and the t/010_pglogical_create_subscriber.pl TAP test hangs.


Michael

-- 
Michael Banck
Projektleiter / Senior Berater
Tel.: +49 2166 9901-171
Fax:  +49 2166 9901-100
Email: michael.banck@credativ.de

credativ GmbH, HRB Mönchengladbach 12080
USt-ID-Nummer: DE204566209
Trompeterallee 108, 41189 Mönchengladbach
Geschäftsführung: Dr. Michael Meskes, Jörg Folz, Sascha Heuer

Unser Umgang mit personenbezogenen Daten unterliegt
folgenden Bestimmungen: https://www.credativ.de/datenschutz