Message-ID: <d8ac51a2-6684-0966-a898-aeb4e27038d6@sourcepole.ch>
Date: Thu, 12 May 2022 10:46:27 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: Breakage: pgbouncer has changed the user under which it runs
 between 1.16.1 and 1.17.0
Content-Language: en-GB
To: Christoph Berg <myon@debian.org>
Cc: pgsql-pkg-debian@lists.postgresql.org
References: <c2d6beff-ab80-ad76-930f-05e4ddd9578c@sourcepole.ch>
 <YnvJcRmgVTTQCtFZ@msg.df7cb.de>
From: Tomas Pospisek <tpo2@sourcepole.ch>
In-Reply-To: <YnvJcRmgVTTQCtFZ@msg.df7cb.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/d8ac51a2-6684-0966-a898-aeb4e27038d6%40sourcepole.ch>
Precedence: bulk

Hi Christoph,

before anything: thanks a lot for your reply and thanks a lot for your 
OSS work <3 !!! Am very thankful for that!

On 11.05.22 16:34, Christoph Berg wrote:
> Re: Tomas Pospisek
>> Due to the change of user under which pgbouncer runs (before: user
>> pgbouncer, new: user postgres), an upgrade from 1.16.1 to 1.17.0 will break
>> systems.
> 
> Hi Tomas,
> 
> the Debian pgbouncer package has always been using the postgres user:
> 
> $ grep USER debian/init
> RUNASUSER="postgres"
>      $SSD --start --chuid $RUNASUSER --oknodo -- $OPTS 2> /dev/null
>          su -c "$DAEMON -R $OPTS 2> /dev/null" - ${RUNASUSER%:*}
> 
> Maybe you were editing the init.d or defaults file before?

indeed my /etc/default/pgbouncer contains `RUNASUSER="pgbouncer"`. I do 
set that explicitly via ansible. However I'm not sure where that line 
originated from. I am quite sure that it's not me who came up with the 
idea of running the daemon as `pgbouncer`, but instead that came from 
the package (which package - if from Debian or from pgdg - I don't know 
I would have to dig further, but maybe I could figure it out).

>>      Upgrade: pgbouncer:amd64 (1.16.1-1.pgdg20.04+1,
>>               1.17.0-3.pgdg20.04+1)
> 
> The effective change between these versions is that we are now
> shipping a .service file.

So what is happening after the introduction of the `.service` file is 
that either `/etc/default/pgbouncer` is now beeing ignored or it is 
being overriden. That breaks installations that had 
`RUNASUSER="pgbouncer"` set in `/etc/default/pgbouncer` when upgrading 
to 1.17.x.

Do you concur with that conclusion?

*t