Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2102\))
Subject: Re: systemd service files vs. postgresql9x-setup 
From: Jeff Frost <jeff@pgexperts.com>
In-Reply-To: <0EDD19E44F05669CE0D68F45@eje.credativ.lan>
Date: Wed, 12 Aug 2015 16:54:41 -0700
Cc: pgsql-pkg-yum@postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <0AC9AAC9-0B01-47E3-860F-620C5F0912F1@pgexperts.com>
References: <0EDD19E44F05669CE0D68F45@eje.credativ.lan>
To: Bernd Helmle <mailings@oopsware.de>
Precedence: bulk
Sender: pgsql-pkg-yum-owner@postgresql.org

>=20
> On Aug 12, 2015, at 7:18 AM, Bernd Helmle <mailings@oopsware.de> wrote:
>=20
> Hi,
>=20
> Looks like postgresql9[45]-setup is careless when someone tries to use th=
em
> in customized
> systemd environments (e.g. via drop-in configurations[1]). Currently we do
> this:
>=20
> # this parsing technique fails for PGDATA pathnames containing spaces,
> # but there's not much I can do about it given systemctl's output format.=
..
> PGDATA=3D`systemctl show -p Environment "${SERVICE_NAME}.service" |
>                sed 's/^Environment=3D//' | tr ' ' '\n' |
>                sed -n 's/^PGDATA=3D//p' | tail -n 1`
>=20
> [...some more code later...]
>=20
> # Get data directory from the service file
> PGDATA=3D`sed -n 's/Environment=3DPGDATA=3D//p' "${SERVICE_FILE}"`
>=20
> So we obviously overwrite any PGDATA setting returned by 'systemctl show'
> earlier. If someone uses service files only, this doesn't heavily matter,
> since SERVICE_FILE is tested against multiple locations. However, drop-in
> configurations are ignored/overwritten with this method. I don't
> understand, why we do the sed approach anyways, since 'systemctl show'
> already covers all cases, afaics. So i suggest to get rid of handling the
> SERVICE_FILE directly and leave 'systemctl show' alone, patch attached.
>=20
> Opinions?
>=20
> [1] <http://www.freedesktop.org/software/systemd/man/systemd.unit.html>

Unfortunately, I=E2=80=99m not that familiar with systemd yet and Devrim is=
 out for a few weeks, so we might not get to this very quickly.

--=20
Sent via pgsql-pkg-yum mailing list (pgsql-pkg-yum@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum