Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.80) (envelope-from ) id 1ZPWqd-0006sN-4t for pgsql-pkg-yum@arkaria.postgresql.org; Wed, 12 Aug 2015 14:17:43 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84) (envelope-from ) id 1ZPWqc-0007Hl-J1 for pgsql-pkg-yum@arkaria.postgresql.org; Wed, 12 Aug 2015 14:17:42 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84) (envelope-from ) id 1ZPWqZ-0007Ee-3l for pgsql-pkg-yum@postgresql.org; Wed, 12 Aug 2015 14:17:39 +0000 Received: from dd2030.kasserver.com ([85.13.128.37]) by makus.postgresql.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84) (envelope-from ) id 1ZPWqV-0004Lw-Hl for pgsql-pkg-yum@postgresql.org; Wed, 12 Aug 2015 14:17:37 +0000 Received: from [172.26.14.170] (wan3.credativ.com [94.79.138.166]) by dd2030.kasserver.com (Postfix) with ESMTPSA id 5FD98E1905 for ; Wed, 12 Aug 2015 16:17:31 +0200 (CEST) Date: Wed, 12 Aug 2015 16:18:06 +0200 From: Bernd Helmle To: pgsql-pkg-yum@postgresql.org Subject: systemd service files vs. postgresql9x-setup Message-ID: <0EDD19E44F05669CE0D68F45@eje.credativ.lan> X-Mailer: Mulberry/4.1.0a3 (Mac OS X) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="==========38E41526E0F9AB8052F0==========" X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-pkg-yum Precedence: bulk Sender: pgsql-pkg-yum-owner@postgresql.org --==========38E41526E0F9AB8052F0========== Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline; size=1241 Hi, Looks like postgresql9[45]-setup is careless when someone tries to use them in customized systemd environments (e.g. via drop-in configurations[1]). Currently we do this: # this parsing technique fails for PGDATA pathnames containing spaces, # but there's not much I can do about it given systemctl's output format... PGDATA=`systemctl show -p Environment "${SERVICE_NAME}.service" | sed 's/^Environment=//' | tr ' ' '\n' | sed -n 's/^PGDATA=//p' | tail -n 1` [...some more code later...] # Get data directory from the service file PGDATA=`sed -n 's/Environment=PGDATA=//p' "${SERVICE_FILE}"` So we obviously overwrite any PGDATA setting returned by 'systemctl show' earlier. If someone uses service files only, this doesn't heavily matter, since SERVICE_FILE is tested against multiple locations. However, drop-in configurations are ignored/overwritten with this method. I don't understand, why we do the sed approach anyways, since 'systemctl show' already covers all cases, afaics. So i suggest to get rid of handling the SERVICE_FILE directly and leave 'systemctl show' alone, patch attached. Opinions? [1] -- Thanks Bernd --==========38E41526E0F9AB8052F0========== Content-Type: application/octet-stream; name="0001-Get-rid-of-sed-magic-to-retrieve-PGDATA-directly-fro.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Get-rid-of-sed-magic-to-retrieve-PGDATA-directly-fro.patch"; size=2726 RnJvbSBhNWE4ZjY4ZWJjZjVkMmMyYjRlNjgwNTIxYzZmYTkxNjgwM2UyMWE4 IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBCZXJuZCBIZWxtbGUg PGJlcm5kLmhlbG1sZUBjcmVkYXRpdi5kZT4KRGF0ZTogV2VkLCAxMiBBdWcg MjAxNSAxNToyODo1MSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIEdldCByaWQg b2Ygc2VkIG1hZ2ljIHRvIHJldHJpZXZlIFBHREFUQSBkaXJlY3RseSBmcm9t IHN5c3RlbWQKIHNlcnZpY2UgZmlsZXMuCgpJbnN0ZWFkIHJlbHkgb24gc3lz dGVtY3RsIG9ubHksIHdoaWNoIGFsc28gYWxsb3dzIHRvIHVzZSBzeXN0ZW1k IGRyb3AtaW4KY29uZmlndXJhdGlvbiBkaXJlY3RpdmVzLgoKVGhlIGZvcm1l ciBjb2RpbmcgYWxzbyBjb250YWlucyBhIGJ1Zywgd2hlcmUgUEdEQVRBIGlz IGFsd2F5cyBvdmVyd3JpdHRlbgpieSBzZXR0aW5ncyBkZXJpdmVkIGZyb20g c2VydmljZSBmaWxlcyBkaXJlY3RseS4KLS0tCiBycG0vcmVkaGF0LzkuNC9w b3N0Z3Jlc3FsL0VMLTcvcG9zdGdyZXNxbDk0LXNldHVwIHwgMTUgLS0tLS0t LS0tLS0tLS0tCiBycG0vcmVkaGF0LzkuNS9wb3N0Z3Jlc3FsL0VMLTcvcG9z dGdyZXNxbDk1LXNldHVwIHwgMTUgLS0tLS0tLS0tLS0tLS0tCiAyIGZpbGVz IGNoYW5nZWQsIDMwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL3JwbS9y ZWRoYXQvOS40L3Bvc3RncmVzcWwvRUwtNy9wb3N0Z3Jlc3FsOTQtc2V0dXAg Yi9ycG0vcmVkaGF0LzkuNC9wb3N0Z3Jlc3FsL0VMLTcvcG9zdGdyZXNxbDk0 LXNldHVwCmluZGV4IDFmMGNiMGYuLjNhNzQ1YmUgMTAwNjQ0Ci0tLSBhL3Jw bS9yZWRoYXQvOS40L3Bvc3RncmVzcWwvRUwtNy9wb3N0Z3Jlc3FsOTQtc2V0 dXAKKysrIGIvcnBtL3JlZGhhdC85LjQvcG9zdGdyZXNxbC9FTC03L3Bvc3Rn cmVzcWw5NC1zZXR1cApAQCAtODMsMjYgKzgzLDExIEBAIGlmIFsgeCIkUEdE QVRBIiA9IHggXTsgdGhlbgogICAgIGV4aXQgMQogZmkKIAotIyBGaW5kIHRo ZSB1bml0IGZpbGUgZm9yIG5ldyB2ZXJzaW9uLgotaWYgWyAtZiAiL2V0Yy9z eXN0ZW1kL3N5c3RlbS8ke1NFUlZJQ0VfTkFNRX0uc2VydmljZSIgXQotdGhl bgotICAgIFNFUlZJQ0VfRklMRT0iL2V0Yy9zeXN0ZW1kL3N5c3RlbS8ke1NF UlZJQ0VfTkFNRX0uc2VydmljZSIKLWVsaWYgWyAtZiAiL2xpYi9zeXN0ZW1k L3N5c3RlbS8ke1NFUlZJQ0VfTkFNRX0uc2VydmljZSIgXQotdGhlbgotICAg IFNFUlZJQ0VfRklMRT0iL2xpYi9zeXN0ZW1kL3N5c3RlbS8ke1NFUlZJQ0Vf TkFNRX0uc2VydmljZSIKLWVsc2UKLSAgICBlY2hvICJDb3VsZCBub3QgZmlu ZCBzeXN0ZW1kIHVuaXQgZmlsZSAke1NFUlZJQ0VfTkFNRX0uc2VydmljZSIK LSAgICBleGl0IDEKLWZpCi0KICMgTG9nIGZpbGUgZm9yIHBnX3VwZ3JhZGUK IFBHVVBMT0c9L3Zhci9saWIvcGdzcWwvJFBHTUFKT1JWRVJTSU9OL3BndXBn cmFkZS5sb2cKICMgTG9nIGZpbGUgZm9yIGluaXRkYgogUEdMT0c9L3Zhci9s aWIvcGdzcWwvOS40L2luaXRkYi5sb2cKIAotIyBHZXQgZGF0YSBkaXJlY3Rv cnkgZnJvbSB0aGUgc2VydmljZSBmaWxlCi1QR0RBVEE9YHNlZCAtbiAncy9F bnZpcm9ubWVudD1QR0RBVEE9Ly9wJyAiJHtTRVJWSUNFX0ZJTEV9ImAKLQog ZXhwb3J0IFBHREFUQQogCiAjIEZvciBTRUxpbnV4IHdlIG5lZWQgdG8gdXNl ICdydW51c2VyJyBub3QgJ3N1JwpkaWZmIC0tZ2l0IGEvcnBtL3JlZGhhdC85 LjUvcG9zdGdyZXNxbC9FTC03L3Bvc3RncmVzcWw5NS1zZXR1cCBiL3JwbS9y ZWRoYXQvOS41L3Bvc3RncmVzcWwvRUwtNy9wb3N0Z3Jlc3FsOTUtc2V0dXAK aW5kZXggNjk3ZTBiNC4uMGVkZTUxZSAxMDA2NDQKLS0tIGEvcnBtL3JlZGhh dC85LjUvcG9zdGdyZXNxbC9FTC03L3Bvc3RncmVzcWw5NS1zZXR1cAorKysg Yi9ycG0vcmVkaGF0LzkuNS9wb3N0Z3Jlc3FsL0VMLTcvcG9zdGdyZXNxbDk1 LXNldHVwCkBAIC04MywyNiArODMsMTEgQEAgaWYgWyB4IiRQR0RBVEEiID0g eCBdOyB0aGVuCiAgICAgZXhpdCAxCiBmaQogCi0jIEZpbmQgdGhlIHVuaXQg ZmlsZSBmb3IgbmV3IHZlcnNpb24uCi1pZiBbIC1mICIvZXRjL3N5c3RlbWQv c3lzdGVtLyR7U0VSVklDRV9OQU1FfS5zZXJ2aWNlIiBdCi10aGVuCi0gICAg U0VSVklDRV9GSUxFPSIvZXRjL3N5c3RlbWQvc3lzdGVtLyR7U0VSVklDRV9O QU1FfS5zZXJ2aWNlIgotZWxpZiBbIC1mICIvbGliL3N5c3RlbWQvc3lzdGVt LyR7U0VSVklDRV9OQU1FfS5zZXJ2aWNlIiBdCi10aGVuCi0gICAgU0VSVklD RV9GSUxFPSIvbGliL3N5c3RlbWQvc3lzdGVtLyR7U0VSVklDRV9OQU1FfS5z ZXJ2aWNlIgotZWxzZQotICAgIGVjaG8gIkNvdWxkIG5vdCBmaW5kIHN5c3Rl bWQgdW5pdCBmaWxlICR7U0VSVklDRV9OQU1FfS5zZXJ2aWNlIgotICAgIGV4 aXQgMQotZmkKLQogIyBMb2cgZmlsZSBmb3IgcGdfdXBncmFkZQogUEdVUExP Rz0vdmFyL2xpYi9wZ3NxbC8kUEdNQUpPUlZFUlNJT04vcGd1cGdyYWRlLmxv ZwogIyBMb2cgZmlsZSBmb3IgaW5pdGRiCiBQR0xPRz0vdmFyL2xpYi9wZ3Nx bC85LjUvaW5pdGRiLmxvZwogCi0jIEdldCBkYXRhIGRpcmVjdG9yeSBmcm9t IHRoZSBzZXJ2aWNlIGZpbGUKLVBHREFUQT1gc2VkIC1uICdzL0Vudmlyb25t ZW50PVBHREFUQT0vL3AnICIke1NFUlZJQ0VfRklMRX0iYAotCiBleHBvcnQg UEdEQVRBCiAKICMgRm9yIFNFTGludXggd2UgbmVlZCB0byB1c2UgJ3J1bnVz ZXInIG5vdCAnc3UnCi0tIAoxLjguMy4xCgo= --==========38E41526E0F9AB8052F0========== Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-pkg-yum mailing list (pgsql-pkg-yum@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-pkg-yum --==========38E41526E0F9AB8052F0==========--