Message-ID: <1431465887.4314.18.camel@gunduz.org>
Subject: Re: pgbouncer logrotate configuration
From: Devrim =?ISO-8859-1?Q?G=FCnd=FCz?= <devrim@gunduz.org>
To: Peter Eisentraut <peter_e@gmx.net>
Cc: pgsql-pkg-yum@postgresql.org
Date: Wed, 13 May 2015 00:24:47 +0300
In-Reply-To: <555211E1.3010805@gmx.net>
References: <555211E1.3010805@gmx.net>
Content-Type: multipart/signed; micalg="pgp-sha256";
 protocol="application/pgp-signature"; boundary="=-JtCJiyjCaNWnW3wNuRnO"
Mime-Version: 1.0
Precedence: bulk
Sender: pgsql-pkg-yum-owner@postgresql.org


--=-JtCJiyjCaNWnW3wNuRnO
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable


Hi,

On Tue, 2015-05-12 at 10:44 -0400, Peter Eisentraut wrote:
> The pgbouncer logrotate configuration seems a bit contradictory:
>=20
> =EF=BB=BF=EF=BB=BF/var/log/pgbouncer.log {
>     missingok
>     notifempty
>     sharedscripts
>     copytruncate
>     create 0640 pgbouncer pgbouncer
>     nodateext
>     postrotate
>         /bin/kill -HUP `cat /var/run/pgbouncer/pgbouncer.pid
> 2>/dev/null` 2> /dev/null || true
>     endscript
> }
>=20
> "create" is ignored if "copytruncate" is used.  And having a postrotate
> script to send a HUP signal is also pointless if copytruncate is used.
> We need to decide on one way to do it: either copytruncate, or rename
> and SIGHUP.
>=20
> It also seems to me that this might be a bit simpler if we created a
> subdirectory /var/log/pgbouncer/ for all the log files.  Then we
> wouldn't have the permissions issues that the "create" directory is
> attempting to solve.

Just committed a fix for this. Can you please pull 9.4 tree and see
whether all problems you reported have been fixed or not? I can push the
packages tomorrow or so.

Regards,


--=20
Devrim G=C3=9CND=C3=9CZ
Principal Systems Engineer @ EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Dan=C4=B1=C5=9Fman=C4=B1/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR


--=-JtCJiyjCaNWnW3wNuRnO
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJVUm+fAAoJENjDPf6Sz261JGEP/iqf2kDSk9eKKI/F/n+2mlBG
Nm8lRlOuoEWMDN3g997pZO4uEIIQNdyg2f1TQgNND+Ic5x1C3xNpMAlvn752tjUH
bV8kLkJ6L6PN/tqbAR/PL/28thMxwmgKbcWHpRe8mnI8Tj8pNrM5oVJUW9tI/GgM
sxpDlZ2bFeNn8CXxU2nmt1tOqEAbMvxSmSqo/FH9VhWUlKHmh4cuiDysGcugLGFx
haRj9hhgTnugYrZEQ1/R12KeVLlE18caeNaRLHE9h4WLSrCkkGz1X85hZR2YNDzm
zg7fxBNf7ABDwVb/WQTvH+a5heKGsOoM+EpmsoaHjaXA18AwAD5+eskkVG+d3sSP
nucumFOJdaajzFm5rWshg0q4pdQSqRwrA94D7dAg9L+wJjQE7+EphlJptOGYYiw/
UtqW82aChOVkJvSja4kYhmXuBzVm5+Ar6zB/9a/vpyKyEHO9zgZtYpfLvuqXqvMH
vW2f+I4VCkSk903WAJzFcCNSqbVwKnFAs30VqqZA/FzL8/MIGv5IqLPdYe0Oh5Hy
pCLxVz0alsMg5hvUr66PXGfS4OG2eukuuCiFu2ukAsF+QEcNsAtxwpcXk3Xs14g5
e5udccfFMskVsVkJNdFhez2dOZSDAd4g3/mEo0EsHRPkinlrRyDmsH6lWXmEyX7S
7pvWpfiaHErna3arA4yZ
=lGOE
-----END PGP SIGNATURE-----

--=-JtCJiyjCaNWnW3wNuRnO--