Message-ID: <1478927631.25953.75.camel@gunduz.org>
Subject: Re: When %nls/%ssl/%xml macro is set to 0
From: Devrim =?ISO-8859-1?Q?G=FCnd=FCz?= <devrim@gunduz.org>
To: Tomoaki Sato <sato@sraoss.co.jp>, pgsql-pkg-yum@postgresql.org
Date: Sat, 12 Nov 2016 08:13:51 +0300
In-Reply-To: <20161103.213544.1900991879530641413.sato@sraoss.co.jp>
References: <20161103.213544.1900991879530641413.sato@sraoss.co.jp>
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-NyssfHqeczUeB2ysAyV7"
Mime-Version: 1.0
Precedence: bulk
Sender: pgsql-pkg-yum-owner@postgresql.org


--=-NyssfHqeczUeB2ysAyV7
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable


Hi Tomoaki,

Wow, good catch! I'll apply the patch soon. Should we release a new version=
, or
just wait for the next minor release? I'm inclined to go with the latter, a=
s I
want to avoid people to restart their instances just for applying this patc=
h.

Regards, Devrim

On Thu, 2016-11-03 at 21:35 +0900, Tomoaki Sato wrote:
> Hi,
>=20
> When %nls macro is set to 0, PostgreSQL 9.6 RPM package build fails.
>=20
> ---
> $ rpmbuild -ba -D 'nls 0' SPECS/postgresql-9.6.spec=C2=A0
> (snip)
> + /usr/bin/cp /dev/null pltcl.lst
> + /usr/bin/cp /dev/null plpython.lst
> + cat libpq5-9.6.lang
> cat: libpq5-9.6.lang: No such file or directory
> error: Bad exit status from /var/tmp/rpm-tmp.ct9Vwi (%install)
>=20
>=20
> RPM build errors:
> =C2=A0=C2=A0=C2=A0 Bad exit status from /var/tmp/rpm-tmp.ct9Vwi (%install=
)
> ----
>=20
> *.lst filename and %endif position for %if %{nls} ... %endif block are
> wrong.
>=20
> Even when %ssl macro is set to 0, it fails.
>=20
> ----
> $ rpmbuild -ba -D 'ssl 0' SPECS/postgresql-9.6.spec
> + cp -pr src/tutorial /home/tom-sato/rpmbuild/BUILDROOT/postgresql96-9.6.=
1-
> 1PGDG.el7.centos.x86_64/usr/share/doc/postgresql96-docs-9.6.1
> + cp -pr doc/html /home/tom-sato/rpmbuild/BUILDROOT/postgresql96-9.6.1-
> 1PGDG.el7.centos.x86_64/usr/share/doc/postgresql96-docs-9.6.1
> + exit 0
> Provides: postgresql-docs postgresql96-docs =3D 9.6.1-1PGDG.el7.centos
> postgresql96-docs(x86-64) =3D 9.6.1-1PGDG.el7.centos
> Requires(rpmlib): rpmlib(CompressedFileNames) <=3D 3.0.4-1 rpmlib(FileDig=
ests)
> <=3D 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <=3D 4.0-1
> Requires: /bin/sh libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit)
> libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.4)(64bit) rtld(GNU_HASH)
> Processing files: postgresql96-contrib-9.6.1-1PGDG.el7.centos.x86_64
> error: File not found: /home/tom-sato/rpmbuild/BUILDROOT/postgresql96-9.6=
.1-
> 1PGDG.el7.centos.x86_64/usr/pgsql-9.6/lib/sslinfo.so
> error: File not found by glob: /home/tom-
> sato/rpmbuild/BUILDROOT/postgresql96-9.6.1-1PGDG.el7.centos.x86_64/usr/pg=
sql-
> 9.6/share/extension/sslinfo*
>=20
>=20
> RPM build errors:
> =C2=A0=C2=A0=C2=A0 File not found: /home/tom-sato/rpmbuild/BUILDROOT/post=
gresql96-9.6.1-
> 1PGDG.el7.centos.x86_64/usr/pgsql-9.6/lib/sslinfo.so
> =C2=A0=C2=A0=C2=A0 File not found by glob: /home/tom-sato/rpmbuild/BUILDR=
OOT/postgresql96-
> 9.6.1-1PGDG.el7.centos.x86_64/usr/pgsql-9.6/share/extension/sslinfo*
> ----=C2=A0=C2=A0=C2=A0=C2=A0
>=20
> sslinfo module isn't excluded from %files list.=C2=A0
>=20
> Even when %xml macro is set to 0, it fails.
>=20
> ----
> $ rpmbuild -ba -D 'xml 0' SPECS/postgresql-9.6.spec
> + cp -pr src/tutorial /home/tom-sato/rpmbuild/BUILDROOT/postgresql96-9.6.=
1-
> 1PGDG.el7.centos.x86_64/usr/share/doc/postgresql96-docs-9.6.1
> + cp -pr doc/html /home/tom-sato/rpmbuild/BUILDROOT/postgresql96-9.6.1-
> 1PGDG.el7.centos.x86_64/usr/share/doc/postgresql96-docs-9.6.1
> + exit 0
> Provides: postgresql-docs postgresql96-docs =3D 9.6.1-1PGDG.el7.centos
> postgresql96-docs(x86-64) =3D 9.6.1-1PGDG.el7.centos
> Requires(rpmlib): rpmlib(CompressedFileNames) <=3D 3.0.4-1 rpmlib(FileDig=
ests)
> <=3D 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <=3D 4.0-1
> Requires: /bin/sh libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit)
> libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.4)(64bit) rtld(GNU_HASH)
> Processing files: postgresql96-contrib-9.6.1-1PGDG.el7.centos.x86_64
> error: File not found by glob: /home/tom-
> sato/rpmbuild/BUILDROOT/postgresql96-9.6.1-1PGDG.el7.centos.x86_64/usr/pg=
sql-
> 9.6/share/extension/xml2*
>=20
>=20
> RPM build errors:
> =C2=A0=C2=A0=C2=A0 File not found by glob: /home/tom-sato/rpmbuild/BUILDR=
OOT/postgresql96-
> 9.6.1-1PGDG.el7.centos.x86_64/usr/pgsql-9.6/share/extension/xml2*
> ----
>=20
> xml2 module isn't excluded from %files list.=C2=A0
>=20
> Send a patch to fix them.
>=20
> Regards,
>=20
>=20
> ----
> Tomoaki Sato <sato@sraoss.co.jp>
> SRA OSS, Inc. Japan

--=20
Devrim G=C3=9CND=C3=9CZ
EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Dan=C4=B1=C5=9Fman=C4=B1/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR

--=-NyssfHqeczUeB2ysAyV7
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJYJqUPAAoJENjDPf6Sz2619SEP/38yg2Bx8MQoeatiYfe9hGhA
ycrVp39C7jmNjUoGgfLSRqoFLW6oIZI9Ghj/LlKExJ/BBckKrjjapXcLG9AD8zFv
K1EiWueodOv7V8OWoZ5Edfm8rrtLa/9dKkD9F+zBImo/zz7R0AMVVQ+0+enSDUMn
daSbwogbB8nQq9kIkQy+E3B+oPPE9wvX1+38G9hcdv86HOUIKDTJMhYVMhg4x7QU
ansk171rClBBcQ/wTVNDBNq/W+T+gvNQSjlrYAJY1tcnVl+xu/5pwOinXSxkTyo+
E5EcnE2Wz61ZVc0+bCuSnOZ7c9owt0BERGTjJyaYIyyH/z8+q6r+qkF3JqUb5xzI
QABSxgNlpcesZR7pfz0nmmSSGkqS8JRnrN+0jVC6ehywJCk1SzRuuIf3gUninXEk
FHiKT6HGt6cc2vBsFOVvvb/EayWNN9LQWQ42IHg31rzKksG3I5iq9CE2J3gdtGLk
THgmNB/bwnd2LJ7lFUi0rnxnbU/CfCrmsRLbGNS+0kQLj8TuSHjVV9iQPd8LVTMF
ZEUWCH13D411hj4G3KSvvDQ2BooP1/GbVbwTB1dtMKwB8/uyhC3wdhHXuira5P0q
395vh5L9tHa+Ijl0MwpsTFOXGh6EwVrGSCXUFhmnALlANgvHQ8acy0rigDnZRgxk
VVXRnpOweu6DnFuAEfMz
=WHs0
-----END PGP SIGNATURE-----

--=-NyssfHqeczUeB2ysAyV7--