Message-ID: <1493386507.11169.12.camel@gunduz.org>
Subject: Re: pgadmin4 RPM broken?
From: Devrim =?ISO-8859-1?Q?G=FCnd=FCz?= <devrim@gunduz.org>
To: John Harvey <john.harvey@crunchydata.com>, pgsql-pkg-yum
	 <pgsql-pkg-yum@postgresql.org>
Date: Fri, 28 Apr 2017 16:35:07 +0300
In-Reply-To: 
 <CABcP5fhYPA-Ds74XW3WHBTr7SKL9G9i3bp4uOkyCCQPSecuTQw@mail.gmail.com>
References: 
	<CABcP5fjE3BmQVr_V91r=NcWUzjXVfdvneK=UGwixq-dCsthqXg@mail.gmail.com>
	 <1493289313.3032.46.camel@gunduz.org>
	 <CABcP5fhYPA-Ds74XW3WHBTr7SKL9G9i3bp4uOkyCCQPSecuTQw@mail.gmail.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-kdFCZqPzjLOMZjw+mzpy"
Mime-Version: 1.0
Precedence: bulk
Sender: pgsql-pkg-yum-owner@postgresql.org


--=-kdFCZqPzjLOMZjw+mzpy
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable


Hi John,

On Thu, 2017-04-27 at 17:38 -0400, John Harvey wrote:

> No worries.=C2=A0 I know that things have been busy.

Yeah :/

> BTW, I did some test building with the latest spec on RHEL7, since you
> mentioned you're thinking of a rebuild/re-release.

Thanks!

> I had a few findings that may be of use, if you are still finalizing the
> spec-file.

Patches always welcome. I shuffled the spec file * a lot * , I'm sure I may
have missed something.

> Some of these are small and have to do with a few of the new
> pgadmin4-python packages.
>=20
> 1) I noticed that there is no pgadmin4-babel directory in the 9.5 folder,
> but it exists in 9.6.=C2=A0 Does it make sense to copy that over to 9.5 (=
and
> pg10) as well?=C2=A0 It is a necessary build dependency
> for pgadmin4-python-flask-babel.

Right, I'll do that.

> 2) Do you think it makes sense to change the name of the pgadmin4-babel
> specfile (babel.spec) to pgadmin4-babel.spec to match the other pgadmin4
> specfile naming conventions?

Thanks, done.
>=20
> 3) In the yum repository, one of the pgadmin4-python RPM's has some stran=
ge
> capitalization in the RPM name:
> pgadmin4-python-Flask-Mail-0.9.1-3.rhel6.noarch.rpm.
> Should this all be lowercase?

I think this comes from the tarball. I'll leave it as is for now.

> 4) When I try building with the current pgadmin4 specfile on RHEL7, I get
> an error at patch-time:
>=20
> + cd pgadmin4-1.3
> + /usr/bin/chmod -Rf a+rX,u+w,g-w,o-w .
> + echo 'Patch #0 (pgadmin4-sphinx-theme.patch):'
> Patch #0 (pgadmin4-sphinx-theme.patch):
> + /usr/bin/cat pgadmin4/SOURCES/pgadmin4-sphinx-theme.patch
> + /usr/bin/patch -p0 --fuzz=3D0
> patching file docs/en_US/conf.py
> + echo 'Patch #4 (pgadmin4-rhel7-sphinx.patch):'
> Patch #4 (pgadmin4-rhel7-sphinx.patch):
> + /usr/bin/cat pgadmin4/SOURCES/pgadmin4-rhel7-sphinx.patch
> + /usr/bin/patch -p0 --fuzz=3D0
> patching file docs/en_US/Makefile.sphinx
> Reversed (or previously applied) patch detected!=C2=A0 Assume -R? [n]
>=20
>=20
> I'm not sure why this occurs.=C2=A0 I'll keep investigating.

Can't reproduce -- can you please clean up your repo and try again?

> 5) I suggest that the pgadmin4 specfile should add the following line:
> BuildRequires: pgadmin4-python-flask-mail
> Without it (assuming I remove the patch line from my issue 4 above), I se=
e
> this when I compile pgadmin4:

<snip>

Done.

> 6) I suggest that the pgadmin4 specfile should add the following line:
> BuildRequires: pgadmin4-python-dateutil

Done.

>=20
> 7) I think the pgadmin4 specfile may need the following line:
> BuildRequires: pgadmin4-python-flask-gravatar

Done.

> I hope these are helpful.

Thank you, they are very useful!

Regards,
--=20
Devrim G=C3=BCnd=C3=BCz
EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Dan=C4=B1=C5=9Fman=C4=B1/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR

--=-kdFCZqPzjLOMZjw+mzpy
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJZA0ULAAoJENjDPf6Sz261WvIQALLC2hRL5jL00WqIOsRh+BdQ
KqZ75wBj94ObZuN6IgR5yXQmOqYiFuw+5ag+5CswAbjjzEEUm1c5YFGkkZGbF4z7
Oi/ULS728IrZRP5HH6+lJ+dPEu5F15CJ4a+STHAY8gY11LatU6FuyUrPUXNzihG4
n/Zg1QN/8GEYtWFlkkt4qhwY3CPOu05zQF3SO/i2vTQYLio5ztiATZlIY4v8c5S7
0c7Wi6ItXZLvPj/ARvvA9/Bq+8lAiNLkVlW9O5yllF+HPikOlMMmBwnbc7Hyl2OP
z14ZRDMzuTOF9wGbwlBUFVpxCC6CQye1LkZ3UOfdrZF2XoWLVMegm0iB10gKF1z3
2EgIbnYlFQQYQkUnyjZzIncksHn/AuugGF+paDu9SkeSMFzfFVMz8r+ToaDwcLrs
Isy2RV+9CIfZKcymP3L0ZEdhBvpKOIowR2ALyJmOvIp/dPolnTHn8/2uOlUjOAv9
MrR/cO8ycaEXmt5bOO49uY5Km36bMLiFHQ9u4OaVYJnVXQLm0oNS1L5EmRUnNCge
yCZgm+ch73cyQB4dXkakT/yk9kgKgUgxJuW7LsvBtOjsHomq6OJV767++s85DPWs
ebPDdLUEI6MM334OvgaUEK2VkKBkio2YsjZ/54qTB7aywotiyfkcvX+yMd0gBcX6
9290064whed67w7Zx7FG
=xScu
-----END PGP SIGNATURE-----

--=-kdFCZqPzjLOMZjw+mzpy--