Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtp (Exim 4.84_2)
	(envelope-from
 <pgsql-pkg-yum-owner+M1153=pgsql-pkg-yum-arkari@postgresql.org>)
	id 1d4xcg-0002jp-C2
	for pgsql-pkg-yum@arkaria.postgresql.org; Sun, 30 Apr 2017 22:47:22 +0000
Received: from localhost ([127.0.0.1] helo=postgresql.org)
	by malur.postgresql.org with smtp (Exim 4.84_2)
	(envelope-from
 <pgsql-pkg-yum-owner+M1153=pgsql-pkg-yum-arkari@postgresql.org>)
	id 1d4xcf-0004kC-GL
	for pgsql-pkg-yum@arkaria.postgresql.org; Sun, 30 Apr 2017 22:47:21 +0000
Received: from makus.postgresql.org ([2001:4800:1501:1::229])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <devrim@gunduz.org>)
	id 1d4xce-0004k2-Sm
	for pgsql-pkg-yum@postgresql.org; Sun, 30 Apr 2017 22:47:21 +0000
Received: from ns5.gunduz.org ([107.170.136.15] helo=ns1.gunduz.org)
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.84_2)
	(envelope-from <devrim@gunduz.org>)
	id 1d4xcb-0001l7-OD
	for pgsql-pkg-yum@postgresql.org; Sun, 30 Apr 2017 22:47:19 +0000
Received: from asus-laptop03.gunduz.org (unknown [88.248.122.226])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by ns1.gunduz.org (Postfix) with ESMTPSA id 2299B3FD64;
	Sun, 30 Apr 2017 22:47:15 +0000 (UTC)
Message-ID: <1493541308.14590.2.camel@gunduz.org>
Subject: Re: pgadmin4 RPM broken?
From: Devrim =?ISO-8859-1?Q?G=FCnd=FCz?= <devrim@gunduz.org>
To: John Harvey <john.harvey@crunchydata.com>, pgsql-pkg-yum
	 <pgsql-pkg-yum@postgresql.org>
In-Reply-To: 
 <CABcP5fjGADmGE+C6krYo-bAQUv73gyo4JxsqXpWDuGJX+OvX=Q@mail.gmail.com>
References: 
	<CABcP5fjE3BmQVr_V91r=NcWUzjXVfdvneK=UGwixq-dCsthqXg@mail.gmail.com>
	 <1493289313.3032.46.camel@gunduz.org>
	 <CABcP5fhYPA-Ds74XW3WHBTr7SKL9G9i3bp4uOkyCCQPSecuTQw@mail.gmail.com>
	 <1493386507.11169.12.camel@gunduz.org>
	 <CABcP5fjGADmGE+C6krYo-bAQUv73gyo4JxsqXpWDuGJX+OvX=Q@mail.gmail.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
	protocol="application/pgp-signature"; boundary="=-Wu4bJOeiJ1OBa0A8kSC3"
Date: Sun, 30 Apr 2017 11:35:09 +0300
Mime-Version: 1.0
X-Mailer: Evolution 3.22.6 (3.22.6-2.fc25) 
X-Pg-Spam-Score: -0.9 (/)
List-Archive: <http://archives.postgresql.org/pgsql-pkg-yum>
List-Help: <mailto:majordomo@postgresql.org?body=help>
List-ID: <pgsql-pkg-yum.postgresql.org>
List-Owner: <mailto:pgsql-pkg-yum-owner@postgresql.org>
List-Post: <mailto:pgsql-pkg-yum@postgresql.org>
List-Subscribe: <mailto:majordomo@postgresql.org?body=sub%20pgsql-pkg-yum>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-pkg-yum>
X-Mailing-List: pgsql-pkg-yum
Precedence: bulk
Sender: pgsql-pkg-yum-owner@postgresql.org


--=-Wu4bJOeiJ1OBa0A8kSC3
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable


Hi John,

On Fri, 2017-04-28 at 16:05 -0400, John Harvey wrote:
> I found two more specfile recommendations today after some more testing:
>=20
> 1) I would suggest adding "BuildRequires: pgadmin4-python-simplejson" to
> the pgadmin4 specfile.
>=20
> Without it, I see this trace in the build log:

<snip>

Added.


> 2) I think that two Requires lines may need to change, specifically aroun=
d
> python-itsdangerous
>=20
> Requires:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0python3-itsdangerous >=
=3D 0.24
> Requires:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0python-itsdangerous >=
=3D 0.24
>=20
> On CentOS 7, python-itsdangerous-0.23-2.el7.noarch is available from the
> @extras packages
> On RHEL 7, python-itsdangerous-0.23-2.el7.noarch is available from the
> @rhel-7-server-extras-rpms packages
> Unfortunately, these are too low of a version.=C2=A0=C2=A0I'm guessing we=
 want to use
> the PGDG-built version.
>=20
> I think that these lines should actually now be moved to:
> Requires:=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0pgadmin4-python-itsdan=
gerous >=3D 0.24
>=20
> Is that a correct assumption?

I changed Python2 part only, and that was a great catch. Thanks!

The new spec file is in the repo now. Thanks for looking at this, it was gr=
eat!

Regards,
--=20
Devrim G=C3=BCnd=C3=BCz
EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Dan=C4=B1=C5=9Fman=C4=B1/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR

--=-Wu4bJOeiJ1OBa0A8kSC3
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAABCAAGBQJZBaG8AAoJENjDPf6Sz261S10P/Rwt6Lgc5JDG/++wCYlxxDuk
84Z7L4me2bUMyo0dAenMRN6CBr7AneOJCRslWGPzSGS6VBXyjDyJm89+C85lSkut
NiLLyV/S3ETxwkHoRpsGODT+JM0GLlLzkOD3WGPU3/aFVbxkh6tvTMrVtMRvNIu4
zDWrCWbRoYcbBXsF+tOz1bw8rKiA3TIyJtP1osjhiDiVExYW0Djx2UdpvW+9iUIr
k4M6ArKThAkXhsFIbOaNMyeJmR+q0/tw4SniAmRmp99GjJPy/BL8UKc3mUtnN8fj
VaeK/uu1BjiCdVZkDCCoP2YZC1g+rXyN3woMbYcavO5FTHgXTokpaHag3FicJMzV
7M/NOHwhrejNkuFm0deLTbqzWWuWNb8oL7A8Q3Kc/rzn4QJ2T74QsFd0FIl0x+wI
Y4NwU6PIM59cdx06Cj8+1zhM7tQRxKP6acSUf1b0D+Ngg7Vi+ElxOu4KfIQl+SFg
rtJU60Nyi85MyZ2FsXkOKHFkZXZz8esj/GiJ1x+yjfN0ucX5jyNOCvZJfXCtX6DM
qTo1cACR/GsGov0GSYUEN2ghxDqSyGZRRgxMGlEUSF87X7K1TCz8r7eHpUXE6iXw
45Ph5/uGlLz+W2CCLozDHXTP5KlxQWTvIWoqEmR0kP18vC0tTcbp6rluzHQvlm8U
J0VBW3QMQ9byDA0o087d
=yUbv
-----END PGP SIGNATURE-----

--=-Wu4bJOeiJ1OBa0A8kSC3--