Date: Mon, 9 Nov 2020 11:50:34 +0100
From: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
To: Craig Ringer <craig.ringer@enterprisedb.com>
Cc: pgsql-pkg-yum@postgresql.org
Subject: Re: missing perl test modules in postgresqlXX-devel ?
Message-ID: <20201109115034.38cf15d3@firost>
In-Reply-To: 
 <CAGRY4nwOVh8JayrjLE98UFF-jUODapQ-k2Lvgu=FGTz4Xa9x-g@mail.gmail.com>
References: <20201105190206.4358b61d@firost>
	<CAGRY4nygZarpXPaqVC1sfSWP7Ba=uw_XqCS+6pn+NusEoSNvVw@mail.gmail.com>
	<CAGRY4nwOVh8JayrjLE98UFF-jUODapQ-k2Lvgu=FGTz4Xa9x-g@mail.gmail.com>
Organization: Dalibo
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 9 Nov 2020 10:33:07 +0800
Craig Ringer <craig.ringer@enterprisedb.com> wrote:

> Looking at the web, I can find old memories [1] where postgresql12-devel
> >> installed them in /usr/pgsql-12/lib/pgxs/src/test/perl/
> >>  
> >
> > We really need some consistency and cross checks between the RPMs and debs.
> >  
> 
> Ah. I just noticed you said they're installed with the *client* packages.

Yes, under Debian. This was just for comparison and I was surprised as well.

Under EL7, I installed -devel packages as written in $subject

> So that's an example of how we actually need some postgres packaging
> guidance that applies to rpms, debs, EDB's binary installers, and anything
> else, separate to any particular packaging method or team.
> 
> In this case I think it's a bit silly to put the test perl modules along
> with the client.

This is a bit out of the scope of $subject, but I'll answer here anyway, as far
as it could be interesting.

> They can't really be used without the server installed, and they're not
> useful for much unless you're building extensions. They should be in a -dev
> package IMO. They should preferably not be in the test package along with the
> actual test input files, though, since they're used by extensions to run
> their own tests and extensions only have to depend on server-dev not on a
> -test package.

I agree they should live in -dev packages. But I should admit I have no idea
why Debian put them in -client ones. Maybe they have some other constraints
bound to the postgresql-common debian wrapper?

I am currently writing TAP tests for check_pgactivity and rely on PostgresNode
and friends to write and run them. They are very valuable and saves a lot of
time.

> Anyway, I hope the above answers your questions about where they live.

I had no doubt about where they live, sorry for the confusion.

Thank you,

/Jehan-Guillaume de Rorthais