Date: Fri, 13 Nov 2020 10:47:29 +0100
From: Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
To: Craig Ringer <craig.ringer@enterprisedb.com>
Cc: pgsql-pkg-yum@postgresql.org
Subject: Re: missing perl test modules in postgresqlXX-devel ?
Message-ID: <20201113104729.3e4f28c9@firost>
In-Reply-To: 
 <CAGRY4nwhfqJm=fqwhkhqK8u=2FxS+m4h2HNLNtp8bKS=MQ-hyA@mail.gmail.com>
References: <20201105190206.4358b61d@firost>
	<CAGRY4nygZarpXPaqVC1sfSWP7Ba=uw_XqCS+6pn+NusEoSNvVw@mail.gmail.com>
	<20201109114034.2cc8aab5@firost>
	<CAGRY4nz+xcczzYXVuNva8=r+ucgp5pYMt0_eM-nBv4iPNCmyKw@mail.gmail.com>
	<20201110145627.07954db0@firost>
	<CAGRY4nxwwyxMCcWaSZMRm+opbd5sVVtzhXaPNqvvTpzEYZE6RQ@mail.gmail.com>
	<20201112113632.627b8749@firost>
	<CAGRY4nwhfqJm=fqwhkhqK8u=2FxS+m4h2HNLNtp8bKS=MQ-hyA@mail.gmail.com>
Organization: Dalibo
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Fri, 13 Nov 2020 13:38:05 +0800
Craig Ringer <craig.ringer@enterprisedb.com> wrote:

> On Thu, Nov 12, 2020 at 6:36 PM Jehan-Guillaume de Rorthais <jgdr@dalibo.com>
> wrote:
> > Note that the package came from rhel-7-server-rpms:
> >
> >   $ sudo yum history packages-info perl-Test-Simple|grep ^From
> >   From repo      : rhel-7-server-rpms
> >
> > RHEL official documentation confirm the package is available in base
> > repository:
> >
> >
> > https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/7/html/package_manifest/package_lists_base_repository
> >
> >
> Based on this, I think it's appropriate to modify the EL-7 spec file for
> all Pg versions (example patch is for -10) something like the following.
> 
> Note that I removed a duplicate guard for "&& 0%{?suse_version} >= 1315"
> where the test for "enabletaptests" already excluded that. And I made sure
> that both fedora and rhel require both IPC::Run and Test::More ; I don't
> see why that was ever not be the case.

All these changes seem fine to me.

Thank you,