Date: Mon, 22 Mar 2021 10:20:34 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Stephen Frost <sfrost@snowman.net>
Cc: Devrim =?iso-8859-1?B?R/xuZPx6?= <devrim@gunduz.org>,
	pgsql-pkg-yum@postgresql.org
Subject: Re: please build packages --with-lz4
Message-ID: <20210322152034.GM4203@telsasoft.com>
References: <20210322020359.GF4203@telsasoft.com>
 <20210322144507.GV20766@tamriel.snowman.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210322144507.GV20766@tamriel.snowman.net>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20210322152034.GM4203%40telsasoft.com>
Precedence: bulk

On Mon, Mar 22, 2021 at 10:45:08AM -0400, Stephen Frost wrote:
> Greetings,
> 
> * Justin Pryzby (pryzby@telsasoft.com) wrote:
> > Would you plan to build packages --with-lz4 ?
> > 
> > See commit bbe0a81db69bd10bd166907c3701492a29aca294
> >     Allow configurable LZ4 TOAST compression.
> > 
> > Also, a reminder about this old thread.
> > The devel packages should be built with a versions like (I think)
> > 0.1.14.0-alpha*
> 
> I have to wonder why we aren't just automatically checking if lz4 is
> available and enabling it when it is...

I assume you mean at compile time, regarding autoconf macros ?

This probably doesn't apply to PGDG, but as I recall at least within debian,
there's a preference to build either --with-... or --without-.., so that a
library which happens to be installed doesn't create a package with an
unintentional dependency, or a library which is not installed or something
broken/incompatible doesn't result in a package without the intended
dependency.

-- 
Justin