Date: Mon, 22 Mar 2021 11:58:13 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Devrim =?iso-8859-1?B?R/xuZPx6?= <devrim@gunduz.org>,
	pgsql-pkg-yum@postgresql.org
Subject: Re: please build packages --with-lz4
Message-ID: <20210322155813.GX20766@tamriel.snowman.net>
References: <20210322020359.GF4203@telsasoft.com>
 <20210322144507.GV20766@tamriel.snowman.net>
 <20210322152034.GM4203@telsasoft.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="RDUyZ6QwRKTcomAW"
Content-Disposition: inline
In-Reply-To: <20210322152034.GM4203@telsasoft.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: 
 <https://www.postgresql.org/message-id/20210322155813.GX20766%40tamriel.snowman.net>
Precedence: bulk


--RDUyZ6QwRKTcomAW
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Justin Pryzby (pryzby@telsasoft.com) wrote:
> On Mon, Mar 22, 2021 at 10:45:08AM -0400, Stephen Frost wrote:
> > * Justin Pryzby (pryzby@telsasoft.com) wrote:
> > > Would you plan to build packages --with-lz4 ?
> > >=20
> > > See commit bbe0a81db69bd10bd166907c3701492a29aca294
> > >     Allow configurable LZ4 TOAST compression.
> > >=20
> > > Also, a reminder about this old thread.
> > > The devel packages should be built with a versions like (I think)
> > > 0.1.14.0-alpha*
> >=20
> > I have to wonder why we aren't just automatically checking if lz4 is
> > available and enabling it when it is...
>=20
> I assume you mean at compile time, regarding autoconf macros ?

Yes, talking about picking things up at compile time.

> This probably doesn't apply to PGDG, but as I recall at least within debi=
an,
> there's a preference to build either --with-... or --without-.., so that a
> library which happens to be installed doesn't create a package with an
> unintentional dependency, or a library which is not installed or something
> broken/incompatible doesn't result in a package without the intended
> dependency.

I'm just voicing my annoyence that we don't just automatically pick
things up when they're available- sure, packagers might want to go
through and add --without-whatever in situations where they don't want
something, but making everyone have to go add --with-whatever whenever
we add new dependencies doesn't strike me as useful.

Thanks,

Stephen

--RDUyZ6QwRKTcomAW
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJgWL6VAAoJEO1sijiDR2RVNrgP/1CeSYh3kUCKbxz/cq2AeRKR
Zv//yUOeLFrfyCIHZapxC892YU4Po099gT1zJMy48pAHvMzp72to6zzjd8AQk6hQ
lF9zDMsFlp3vo3V5tU4eddthzHZOakzDyva7iJNbb2kngAQi8AcjCrhkNoY0Unet
nAgxdZYIgmj4GMM7pWT9nEXVL/tFiFMuE4sB2qJYgESmfsV/xbgLGc60iYdmIe0f
Cr2EI2+0wVAndG5F7OfELZFHk5j9O7pO4aJUrpgsKWRTpidmO++eVQdvq3Cw5PMd
1Z5o63Omfn+PZcivUTw2yjBtdfoHWBt7Qx9B5JkwZx1wt5tgnhkHZ6QsbkuuCsix
ZkGPQE0fDy5fxJe21uChTrbnmdCWxwze/WJoGbXV7HWm4b+IAIpGcG9D/dLiSGer
cHHmW3EgoGcZ7WSQa6U4wvgwC9K8vIfpLfyahsur/xGAMkFcRTSXtzieEDAo+IsH
tr4vLOCETY6C7oGdhFQ0SELEhfvEVLyRzp0R4/pOqYS7D8ysthcN56JUGTakJRq5
PhSEWy57nDfS4XJlqCxNG6ckYljpXoN/NshAIQRHo3hxNsulNZ/hoZYSOpyVi2L9
rJq2FNpNsEs55xnIJla2BkgnN4+dmPYRgcPKEWgBswQu/JU4gkYwhhzwL8STc1qD
JgtiBwWdbnvjIDtfTEZN
=gh4+
-----END PGP SIGNATURE-----

--RDUyZ6QwRKTcomAW--