From: Andrew N Golovkov <andor000@ya.ru>
Envelope-From: andor000@yandex.ru
To: Jeff Frost <jeff@pgexperts.com>
Cc: "pgsql-pkg-yum@postgresql.org" <pgsql-pkg-yum@postgresql.org>
In-Reply-To: <B0BA3096-C59D-405E-A9E3-C2BEA6BB7613@pgexperts.com>
References: <306581442235608@web6m.yandex.ru>
 <F5B8EE67-19BD-4224-B71D-CD03E826CE61@pgexperts.com>
 <280191442580051@web12h.yandex.ru>
 <89FABBBA-D585-4AA9-889F-962595C2DE1A@pgexperts.com>
 <1964951442604225@web16j.yandex.ru>
 <FD559878-19B3-4E6C-B944-FC8069FBDE27@pgexperts.com>
 <1325321442612766@web4j.yandex.ru>
 <B0BA3096-C59D-405E-A9E3-C2BEA6BB7613@pgexperts.com>
Subject: Re: init script for pgpool
MIME-Version: 1.0
Message-Id: <236381442615195@web8j.yandex.ru>
Date: Sat, 19 Sep 2015 01:26:35 +0300
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=utf-8
Precedence: bulk
Sender: pgsql-pkg-yum-owner@postgresql.org

git diff -b: https://bpaste.net/show/89b37acb8f0a

Removed `switch' action, because not supported at least from 3.3.3, where init-script changed in upstream;

Every call stop/start/reload with correct calls and use variable `$PGPOOLUSER'
Removed unhandled arguments from `failure' and `success' function calls;
Cleanup useless commands and exit's.

Every line aligned with tabs;

Version in comment is 3.4 as proposed Devrim.

19.09.2015, 00:50, "Jeff Frost" <jeff@pgexperts.com>:
>  Could you use diff -b so it doesn’t show lines with just whitespace different?
>
>>   On Sep 18, 2015, at 2:46 PM, Andrew N Golovkov <andor000@ya.ru> wrote:
>>
>>   And again.
>>
>>   https://bpaste.net/show/20ee48a0fc81
>>
>>   Diff with your script and my (with little cosmetic changes from previous version).
>>
>>   18.09.2015, 23:45, "Jeff Frost" <jeff@pgexperts.com>:
>>>   http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.init;hb=jf/pgpool_fixes_3
>>>
>>>>    On Sep 18, 2015, at 12:23 PM, Andrew N Golovkov <andor000@ya.ru> wrote:
>>>>
>>>>    You load /etc/sysconfig/pgpool file _before_ you set variables like PGPOOLUSER and other.
>>>>    Also you set PGPOOLUSER but run commands with hardcoded `postgres' user:
>>>>>    $SU -l postgres -c "$PGPOOLDAEMON -f $PGPOOLCONF $OPTS & " >> "$PGPOOLLOG" 2>&1 < /dev/null
>>>>
>>>>    Please, look at my script i'v posted today.
>>>>
>>>>    18.09.2015, 20:17, "Jeff Frost" <jeff@pgexperts.com>:
>>>>>    Nice catch! I found a couple other things as well, so here’s an updated version:
>>>>>
>>>>>    http://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob_plain;f=rpm/redhat/9.2/pgpool-II/EL-6/pgpool.init;hb=jf/pgpool_fixes_3
>>>>>
>>>>>    It seems to work in my vagrant, so let me know if it works for you and I’ll get it merged, then the next time we build, we’ll have it in the repo.
>>>>>
>>>>>>     On Sep 18, 2015, at 5:40 AM, Andrew N Golovkov <andor000@ya.ru> wrote:
>>>>>>
>>>>>>     You forget $pidfile and $PGPOOLUSER and some more comments.
>>>>>>
>>>>>>     Check script in attach. I'm tested in my centos-6 and pgpool-II-92.<pgpool.init>
>>>>>>     --
>>>>>>     Sent via pgsql-pkg-yum mailing list (pgsql-pkg-yum@postgresql.org)
>>>>>>     To make changes to your subscription:
>>>>>>     http://www.postgresql.org/mailpref/pgsql-pkg-yum
>>>>>
>>>>>    ---
>>>>>    Jeff Frost <jeff@pgexperts.com>
>>>>>    CTO, PostgreSQL Experts, Inc.
>>>>>    Phone: 1-888-PG-EXPRT x506
>>>>>    FAX: 415-762-5122
>>>>>    http://www.pgexperts.com/
>>>
>>>   ---
>>>   Jeff Frost <jeff@pgexperts.com>
>>>   CTO, PostgreSQL Experts, Inc.
>>>   Phone: 1-888-PG-EXPRT x506
>>>   FAX: 415-762-5122
>>>   http://www.pgexperts.com/
>
>  ---
>  Jeff Frost <jeff@pgexperts.com>
>  CTO, PostgreSQL Experts, Inc.
>  Phone: 1-888-PG-EXPRT x506
>  FAX: 415-762-5122
>  http://www.pgexperts.com/


-- 
Sent via pgsql-pkg-yum mailing list (pgsql-pkg-yum@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum