public inbox for [email protected]
help / color / mirror / Atom feedwhat sub-package shoudl we use for pg_rewind
6+ messages / 2 participants
[nested] [flat]
* what sub-package shoudl we use for pg_rewind
@ 2016-01-06 20:50 Pavel Raiskup <[email protected]>
2016-01-06 21:09 ` Re: what sub-package shoudl we use for pg_rewind Devrim GÜNDÜZ <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Pavel Raiskup @ 2016-01-06 20:50 UTC (permalink / raw)
To: pgsql-pkg-yum; +Cc: [email protected]
Hi Devrim,
I'm tempted to put pg_rewind tool into 'postgresql-server.rpm', but
postgresql-9.5.spec in pgrms installs this into 'postgresql.rpm'.
What is better approach?
Thanks, Pavel
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: what sub-package shoudl we use for pg_rewind
2016-01-06 20:50 what sub-package shoudl we use for pg_rewind Pavel Raiskup <[email protected]>
@ 2016-01-06 21:09 ` Devrim GÜNDÜZ <[email protected]>
2016-01-06 21:17 ` Re: what sub-package shoudl we use for pg_rewind Pavel Raiskup <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Devrim GÜNDÜZ @ 2016-01-06 21:09 UTC (permalink / raw)
To: Pavel Raiskup <[email protected]>; pgsql-pkg-yum; +Cc: [email protected]
Hi Pavel,
On Wed, 2016-01-06 at 21:50 +0100, Pavel Raiskup wrote:
> I'm tempted to put pg_rewind tool into 'postgresql-server.rpm', but
> postgresql-9.5.spec in pgrms installs this into 'postgresql.rpm'.
>
> What is better approach?
Awesome question. Here are the list of binaries that we install with
each RPM:
$ rpm -ql postgresql95|grep bin
/usr/pgsql-9.5/bin/clusterdb
/usr/pgsql-9.5/bin/createdb
/usr/pgsql-9.5/bin/createlang
/usr/pgsql-9.5/bin/createuser
/usr/pgsql-9.5/bin/dropdb
/usr/pgsql-9.5/bin/droplang
/usr/pgsql-9.5/bin/dropuser
/usr/pgsql-9.5/bin/pg_archivecleanup
/usr/pgsql-9.5/bin/pg_basebackup
/usr/pgsql-9.5/bin/pg_config
/usr/pgsql-9.5/bin/pg_dump
/usr/pgsql-9.5/bin/pg_dumpall
/usr/pgsql-9.5/bin/pg_isready
/usr/pgsql-9.5/bin/pg_receivexlog
/usr/pgsql-9.5/bin/pg_restore
/usr/pgsql-9.5/bin/pg_rewind
/usr/pgsql-9.5/bin/pg_test_fsync
/usr/pgsql-9.5/bin/pg_test_timing
/usr/pgsql-9.5/bin/pg_upgrade
/usr/pgsql-9.5/bin/pg_xlogdump
/usr/pgsql-9.5/bin/pgbench
/usr/pgsql-9.5/bin/psql
/usr/pgsql-9.5/bin/reindexdb
/usr/pgsql-9.5/bin/vacuumdb
$ rpm -ql postgresql95-server|grep bin
/usr/pgsql-9.5/bin/initdb
/usr/pgsql-9.5/bin/pg_controldata
/usr/pgsql-9.5/bin/pg_ctl
/usr/pgsql-9.5/bin/pg_resetxlog
/usr/pgsql-9.5/bin/postgres
/usr/pgsql-9.5/bin/postgresql95-check-db-dir
/usr/pgsql-9.5/bin/postgresql95-setup
/usr/pgsql-9.5/bin/postmaster
I pushed it into main package, because it is not a "server" tool, and
more like a utility. It is not something like pg_ctl or initdb.
Why do you want to push it into -server subpackage?
Regards,
--
Devrim GÜNDÜZ
Principal Systems Engineer @ EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR
Attachments:
[application/pgp-signature] signature.asc (819B, 2-signature.asc)
download
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: what sub-package shoudl we use for pg_rewind
2016-01-06 20:50 what sub-package shoudl we use for pg_rewind Pavel Raiskup <[email protected]>
2016-01-06 21:09 ` Re: what sub-package shoudl we use for pg_rewind Devrim GÜNDÜZ <[email protected]>
@ 2016-01-06 21:17 ` Pavel Raiskup <[email protected]>
2016-01-06 21:22 ` Re: what sub-package shoudl we use for pg_rewind Devrim GÜNDÜZ <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Pavel Raiskup @ 2016-01-06 21:17 UTC (permalink / raw)
To: Devrim GÜNDÜZ <[email protected]>; +Cc: pgsql-pkg-yum; [email protected]
On Wednesday 06 of January 2016 23:09:32 Devrim GÜNDÜZ wrote:
> On Wed, 2016-01-06 at 21:50 +0100, Pavel Raiskup wrote:
> > I'm tempted to put pg_rewind tool into 'postgresql-server.rpm', but
> > postgresql-9.5.spec in pgrms installs this into 'postgresql.rpm'.
> >
> > What is better approach?
>
> [..]
> I pushed it into main package, because it is not a "server" tool, and
> more like a utility. It is not something like pg_ctl or initdb.
>
> Why do you want to push it into -server subpackage?
It kind of sounds like tool useful for implementing slave-to-master
promotion (but both-ways). And, given by tool's parameters, at least one
"data directory" needs to be local.
Thus I would bet it does not make sense to have this tool installed
without server package.
Pavel
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: what sub-package shoudl we use for pg_rewind
2016-01-06 20:50 what sub-package shoudl we use for pg_rewind Pavel Raiskup <[email protected]>
2016-01-06 21:09 ` Re: what sub-package shoudl we use for pg_rewind Devrim GÜNDÜZ <[email protected]>
2016-01-06 21:17 ` Re: what sub-package shoudl we use for pg_rewind Pavel Raiskup <[email protected]>
@ 2016-01-06 21:22 ` Devrim GÜNDÜZ <[email protected]>
2016-01-06 21:50 ` Re: what sub-package shoudl we use for pg_rewind Pavel Raiskup <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Devrim GÜNDÜZ @ 2016-01-06 21:22 UTC (permalink / raw)
To: Pavel Raiskup <[email protected]>; +Cc: pgsql-pkg-yum; [email protected]
Hi,
On Wed, 2016-01-06 at 22:17 +0100, Pavel Raiskup wrote:
> It kind of sounds like tool useful for implementing slave-to-master
> promotion (but both-ways). And, given by tool's parameters, at least
> one "data directory" needs to be local.
>
> Thus I would bet it does not make sense to have this tool installed
> without server package.
Good point, so then we will need to move pg_basebackup,
pg_archivecleanup, pg_receivexlog, etc, to the server package, right?
I'd like to include only the core-server related tools in that
subpackage.
Jeff, what do you think?
Regards,
--
Devrim GÜNDÜZ
Principal Systems Engineer @ EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR
Attachments:
[application/pgp-signature] signature.asc (819B, 2-signature.asc)
download
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: what sub-package shoudl we use for pg_rewind
2016-01-06 20:50 what sub-package shoudl we use for pg_rewind Pavel Raiskup <[email protected]>
2016-01-06 21:09 ` Re: what sub-package shoudl we use for pg_rewind Devrim GÜNDÜZ <[email protected]>
2016-01-06 21:17 ` Re: what sub-package shoudl we use for pg_rewind Pavel Raiskup <[email protected]>
2016-01-06 21:22 ` Re: what sub-package shoudl we use for pg_rewind Devrim GÜNDÜZ <[email protected]>
@ 2016-01-06 21:50 ` Pavel Raiskup <[email protected]>
2016-01-06 21:59 ` Re: what sub-package shoudl we use for pg_rewind Devrim GÜNDÜZ <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Pavel Raiskup @ 2016-01-06 21:50 UTC (permalink / raw)
To: Devrim GÜNDÜZ <[email protected]>; +Cc: pgsql-pkg-yum; [email protected]
On Wednesday 06 of January 2016 23:22:25 Devrim GÜNDÜZ wrote:
>
> Hi,
>
> On Wed, 2016-01-06 at 22:17 +0100, Pavel Raiskup wrote:
> > It kind of sounds like tool useful for implementing slave-to-master
> > promotion (but both-ways). And, given by tool's parameters, at least
> > one "data directory" needs to be local.
> >
> > Thus I would bet it does not make sense to have this tool installed
> > without server package.
>
> Good point, so then we will need to move pg_basebackup,
> pg_archivecleanup, pg_receivexlog, etc, to the server package, right?
Ah, I missed those are in postgresql-9.5.rpm too -- so IMO yes. Except
that in Fedora we install pg_archivecleanup into postgresql-contrib (which
reflects that it is in ./contrib/ subdirectory in upstream source, since
the dist-git commit 4753f369).
Thanks, Pavel
> I'd like to include only the core-server related tools in that
> subpackage.
>
> Jeff, what do you think?
>
> Regards,
>
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: what sub-package shoudl we use for pg_rewind
2016-01-06 20:50 what sub-package shoudl we use for pg_rewind Pavel Raiskup <[email protected]>
2016-01-06 21:09 ` Re: what sub-package shoudl we use for pg_rewind Devrim GÜNDÜZ <[email protected]>
2016-01-06 21:17 ` Re: what sub-package shoudl we use for pg_rewind Pavel Raiskup <[email protected]>
2016-01-06 21:22 ` Re: what sub-package shoudl we use for pg_rewind Devrim GÜNDÜZ <[email protected]>
2016-01-06 21:50 ` Re: what sub-package shoudl we use for pg_rewind Pavel Raiskup <[email protected]>
@ 2016-01-06 21:59 ` Devrim GÜNDÜZ <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Devrim GÜNDÜZ @ 2016-01-06 21:59 UTC (permalink / raw)
To: Pavel Raiskup <[email protected]>; +Cc: pgsql-pkg-yum; [email protected]
Hi,
On Wed, 2016-01-06 at 22:50 +0100, Pavel Raiskup wrote:
> > Good point, so then we will need to move pg_basebackup,
> > pg_archivecleanup, pg_receivexlog, etc, to the server package,
> right?
>
> Ah, I missed those are in postgresql-9.5.rpm too -- so IMO yes.
> Except that in Fedora we install pg_archivecleanup into postgresql-
> contrib (which reflects that it is in ./contrib/ subdirectory in
> upstream source, since the dist-git commit 4753f369).
Well, I'll leave RH packaging decision to you, for sure. It's been a
while since PGDG RPMs and RH packages have chosen separate ways (like
postgresql-setup stuff). and our multi version paths. I still think
what we do in PGDG RPMs are consistent at some point, but I am open to
hear ideas from other people, too.
Regards,
--
Devrim GÜNDÜZ
Principal Systems Engineer @ EnterpriseDB: http://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR
Attachments:
[application/pgp-signature] signature.asc (819B, 2-signature.asc)
download
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2016-01-06 21:59 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-01-06 20:50 what sub-package shoudl we use for pg_rewind Pavel Raiskup <[email protected]>
2016-01-06 21:09 ` Devrim GÜNDÜZ <[email protected]>
2016-01-06 21:17 ` Pavel Raiskup <[email protected]>
2016-01-06 21:22 ` Devrim GÜNDÜZ <[email protected]>
2016-01-06 21:50 ` Pavel Raiskup <[email protected]>
2016-01-06 21:59 ` Devrim GÜNDÜZ <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox