Subject: Re: pgbouncer logrotate configuration
To: =?UTF-8?B?RGV2cmltIEfDvG5kw7x6?= <devrim@gunduz.org>
References: <555211E1.3010805@gmx.net> <1431465887.4314.18.camel@gunduz.org>
 <5553BA44.7090701@gmx.net>
Cc: pgsql-pkg-yum@postgresql.org
From: Peter Eisentraut <peter_e@gmx.net>
Message-ID: <5601A349.3000901@gmx.net>
Date: Tue, 22 Sep 2015 14:51:53 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0)
 Gecko/20100101 Thunderbird/38.2.0
MIME-Version: 1.0
In-Reply-To: <5553BA44.7090701@gmx.net>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Precedence: bulk
Sender: pgsql-pkg-yum-owner@postgresql.org

On 5/13/15 4:55 PM, Peter Eisentraut wrote:
> On 5/12/15 5:24 PM, Devrim Gündüz wrote:
>>
>> Hi,
>>
>> On Tue, 2015-05-12 at 10:44 -0400, Peter Eisentraut wrote:
>>> The pgbouncer logrotate configuration seems a bit contradictory:
>>>
>>> ﻿﻿/var/log/pgbouncer.log {
>>>     missingok
>>>     notifempty
>>>     sharedscripts
>>>     copytruncate
>>>     create 0640 pgbouncer pgbouncer
>>>     nodateext
>>>     postrotate
>>>         /bin/kill -HUP `cat /var/run/pgbouncer/pgbouncer.pid
>>> 2>/dev/null` 2> /dev/null || true
>>>     endscript
>>> }
>>>
>>> "create" is ignored if "copytruncate" is used.  And having a postrotate
>>> script to send a HUP signal is also pointless if copytruncate is used.
>>> We need to decide on one way to do it: either copytruncate, or rename
>>> and SIGHUP.
>>>
>>> It also seems to me that this might be a bit simpler if we created a
>>> subdirectory /var/log/pgbouncer/ for all the log files.  Then we
>>> wouldn't have the permissions issues that the "create" directory is
>>> attempting to solve.
>>
>> Just committed a fix for this. Can you please pull 9.4 tree and see
>> whether all problems you reported have been fixed or not? I can push the
>> packages tomorrow or so.
> 
> I haven't tested it, but I think the currently committed logrotate file
> won't work at all, because *both* the copytruncate the the postrotate
> script were removed.  You need to keep at least one.
> 
> Also, I think the /var/log/pgbouncer/ directory needs to be created
> somewhere in the spec file.

This is still not fixed.


-- 
Sent via pgsql-pkg-yum mailing list (pgsql-pkg-yum@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum