To: pgsql-pkg-yum@postgresql.org
From: =?UTF-8?Q?Mart=c3=adn_Marqu=c3=a9s?= <martin@2ndquadrant.com>
Subject: repmgr init script
Message-ID: <5609B7AF.3010903@2ndquadrant.com>
Date: Mon, 28 Sep 2015 18:57:03 -0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.1.0
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------070705050708090504030207"
Precedence: bulk
Sender: pgsql-pkg-yum-owner@postgresql.org

This is a multi-part message in MIME format.
--------------070705050708090504030207
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit

Hi all,

I've been going over the configuration of an already installed repmgr
cluster from PGDG rpms and found that the init-script doesn't seem to be
performing the correct commands.

I found a dangling dash which I have no idea what it's there for.

So, mainly I think the start exec should be changed to something like:

$SU -l $REPMGRD_USER -c "${REPMGRD_BIN} ${REPMGRD_OPTS} \
-p ${REPMGRD_PIDFILE} &" >> "${REPMGRD_LOG}" 2>&1 < /dev/null

This means having all the repmgrd options set in ${REPMGRD_OPTS} in a
sysconfig file instead of placing them one by one in the init script.

This would mean that all the configuration should be set in
sysconfig/repmgrd, not by editing the init script.

Attached is a patch for EL-6, plus the missing sysconfig file.

On EL-7 we need to have a nice systemd file. I'll see if I can get that
done later.

Also, the init script's service should be called repmgrd, not repmgr.

Kind regards,

-- 
Martín Marqués                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

--------------070705050708090504030207
Content-Type: text/x-diff;
 name="repmgr.init.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
 filename="repmgr.init.diff"

diff --git a/rpm/redhat/9.4/repmgr/EL-6/repmgr.init b/rpm/redhat/9.4/repmgr/EL-6/repmgr.init
index c900170..fd0fdd2 100644
--- a/rpm/redhat/9.4/repmgr/EL-6/repmgr.init
+++ b/rpm/redhat/9.4/repmgr/EL-6/repmgr.init
@@ -29,32 +29,63 @@ user=repmgr
 prog=repmgrd
 pidfile=/var/run/repmgr/repmgrd-9.4.pid
 lockfile=/var/lock/subsys/$prog
+REPMGRD_ENABLED=no
+REPMGRD_OPTS=
 REPMGRDCONF=/etc/repmgr/9.4/repmgr.conf
 REPMGRDLOG=/var/log/repmgr/repmgrd-9.4.log
 
 # Get config.
 . /etc/sysconfig/network
 
+# Read configuration variable file if it is present
+[ -r /etc/sysconfig/$prog ] && . /etc/sysconfig/$prog
+
+# For SELinux we need to use 'runuser' not 'su'
+if [ -x /sbin/runuser ]
+then
+    SU=runuser
+else
+    SU=su
+fi
+
+test -x $exec || exit 0
+
+case "$REPMGRD_ENABLED" in
+    [Yy]*)
+	break
+	;;
+    *)
+	exit 0
+	;;
+esac
+
+if [ -z "${REPMGRD_OPTS}" ]
+then
+    echo "Not starting ${prog}, REPMGRD_OPTS not set in /etc/sysconfig/${prog}"
+    exit 0
+fi
+
 # Check that networking is up.
 [ "${NETWORKING}" = "no" ] && exit 6
 start(){
         [ -x $exec ] || exit 5
-        [ -f "$REPMGRDCONF" ] || exit 6
+        [ -f "${REPMGRDCONF}" ] || exit 6
         echo -n "Starting $prog: "
 
         # Make sure startup-time log file is valid
-        if [ ! -e "$REPMGRDLOG" -a ! -h "$REPMGRDLOG" ]
+        if [ ! -e "${REPMGRDLOG}" -a ! -h "${REPMGRDLOG}" ]
         then
-                touch "$REPMGRDLOG" || exit 1
-                chown $user: "$REPMGRDLOG"
-                chmod go-rwx "$REPMGRDLOG"
-                [ -x /usr/bin/chcon ] && /usr/bin/chcon -u system_u -r object_r -t postgresql_log_t "$REPMGRDLOG" 2>/dev/null
+                touch "${REPMGRDLOG}" || exit 1
+                chown $user: "${REPMGRDLOG}"
+                chmod go-rwx "${REPMGRDLOG}"
+                [ -x /usr/bin/chcon ] && /usr/bin/chcon -u system_u -r object_r -t postgresql_log_t "${REPMGRDLOG}" 2>/dev/null
         fi
 
         mkdir -p $(dirname $pidfile)
         chown $user: $(dirname $pidfile)
 
-	su -l repmgr -c "$exec -f $REPMGRDCONF -p $pidfile -d ->> $REPMGRDLOG 2>&1" $user # --monitoring-history --verbose
+	${SU} -l -c "${exec} -f ${REPMGR_CONF} ${REPMGRD_OPTS} -p ${pidfile} >> ${REPMGRDLOG} 2>&1" ${user} < /dev/null
+	sleep 2
         retval=$?
 	[ $retval -eq 0 ] && success 
         echo

--------------070705050708090504030207
Content-Type: text/plain; charset=UTF-8;
 name="repmgrd.sysconfig"
Content-Transfer-Encoding: base64
Content-Disposition: attachment;
 filename="repmgrd.sysconfig"

IyBkZWZhdWx0IHNldHRpbmdzIGZvciByZXBtZ3JkLiBUaGlzIGZpbGUgaXMg
c291cmNlIGJ5IC9iaW4vc2ggZnJvbQojIC9ldGMvaW5pdC5kL3JlcG1ncmQK
CiMgZGlzYWJsZSByZXBtZ3JkIGJ5IGRlZmF1bHQgc28gaXQgd29uJ3QgZ2V0
IHN0YXJ0ZWQgdXBvbiBpbnN0YWxsYXRpb24KIyB2YWxpZCB2YWx1ZXM6IHll
cy9ubwpSRVBNR1JEX0VOQUJMRUQ9bm8KCiMgUmVwbWdyIGNvbmYgZmlsZQpS
RVBNR1JfQ09ORj0vdmFyL2xpYi9wZ3NxbC9yZXBtZ3IvcmVwbWdyLmNvbmYK
CiMgT3B0aW9ucyBmb3IgcmVwbWdyZCAocmVxdWlyZWQpCiNSRVBNR1JEX09Q
VFM9Ii0tdmVyYm9zZSAtZCAiCgojIFVzZXIgdG8gcnVuIHJlcG1ncmQgYXMK
I1JFUE1HUkRfVVNFUj1wb3N0Z3JlcwoKIyByZXBtZ3JkIGJpbmFyeQojUkVQ
TUdSRF9CSU49L3Vzci9iaW4vcmVwbWdyZAoKIyBwaWQgZmlsZQojUkVQTUdS
RF9QSURGSUxFPS92YXIvbGliL3Bnc3FsL3JlcG1nci9yZXBtZ3JkLnBpZAoK
IyBsb2cgZmlsZQojUkVQTUdSRF9MT0c9L3Zhci9saWIvcGdzcWwvcmVwbWdy
L3JlcG1ncmQubG9nCg==

--------------070705050708090504030207
Content-Type: text/plain
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0


-- 
Sent via pgsql-pkg-yum mailing list (pgsql-pkg-yum@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum

--------------070705050708090504030207--